fix(condition): treat condition input the same as the code subblock

[waleedlatif1]

Summary

• treat condition input the same as the code subblock

Type of Change

• Bug fix

Testing

Tested manually

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
docs	Skipped			Nov 15, 2025 7:12am

[greptile-apps]

Greptile Overview

Greptile Summary

Aligned the condition input's syntax highlighting logic with the code subblock by adding a shouldHighlight boolean field to placeholder objects. This ensures that only valid references (those passing the shouldHighlightReference check) are highlighted in blue, while invalid <...> patterns remain unhighlighted.

Key changes:

• Added shouldHighlight: boolean field to placeholder type definition
• Set shouldHighlight: true for all environment variables ({{...}})
• Set shouldHighlight: true only for variable references that pass validation
• Added check in restoration loop to skip highlighting when shouldHighlight is false

This fix prevents the condition input from highlighting invalid or inaccessible variable references, bringing it into alignment with the code subblock's behavior.

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The change is a focused bugfix that aligns two components' behavior. It adds a boolean field to track highlighting decisions and uses it during the restoration phase, which is a clean and logical implementation that mirrors the code subblock pattern. No logic errors, security issues, or breaking changes detected.
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel-new/components/editor/components/sub-block/components/condition-input/condition-input.tsx	5/5	Aligned placeholder handling with code subblock by adding shouldHighlight boolean field to track highlighting decisions

Sequence Diagram

sequenceDiagram
    participant User
    participant Editor as ConditionInput Editor
    participant Highlight as Highlight Function
    participant Placeholders as Placeholder Array

    User->>Editor: Types code with {{env}} or <var>
    Editor->>Highlight: highlight(codeToHighlight)
    
    Note over Highlight: Process environment variables
    Highlight->>Placeholders: push({placeholder, original, type: 'env', shouldHighlight: true})
    
    Note over Highlight: Process variable references
    Highlight->>Highlight: shouldHighlightReference(match)
    alt Should Highlight
        Highlight->>Placeholders: push({placeholder, original, type: 'var', shouldHighlight: true})
    else Should Not Highlight
        Highlight->>Highlight: Keep original match
    end
    
    Note over Highlight: Apply Prism.js syntax highlighting
    Highlight->>Highlight: highlight(processedCode)
    
    Note over Highlight: Restore placeholders with highlighting
    loop For each placeholder
        alt shouldHighlight === true
            Highlight->>Highlight: Replace with highlighted span
        else shouldHighlight === false
            Highlight->>Highlight: Skip restoration
        end
    end
    
    Highlight->>Editor: Return highlighted HTML
    Editor->>User: Display syntax-highlighted code

Loading

[greptile-apps]

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}