Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • add share button, serve public templates routes for unauthenticated users and workspace one for authenticated users
  • improve settings style and organization

Type of Change

  • Bug fix
  • New feature

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…es for unauthenticated users and workspace one for authenticated users, improve settings style and organization
@vercel
Copy link

vercel bot commented Nov 13, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
docs Skipped Skipped Nov 13, 2025 4:55am

@icecrasher321 icecrasher321 marked this pull request as ready for review November 13, 2025 05:27
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 13, 2025

Greptile Overview

Greptile Summary

This PR implements a dual-routing system for templates, serving public routes for unauthenticated users and workspace-scoped routes for authenticated users, while also improving the settings UI organization.

Key Changes

  • Public template access: Unauthenticated users can now view templates at /templates and /templates/[id] for SEO and discovery purposes, with only approved templates visible
  • Workspace-scoped templates: Authenticated users are automatically redirected to workspace-scoped routes (/workspace/[workspaceId]/templates) with star tracking and workspace context
  • Share functionality: Added share button to template detail pages with options to copy link, share on X (Twitter), and share on LinkedIn
  • Template card redesign: Replaced horizontal card layout with vertical cards featuring workflow preview, using IntersectionObserver for performance optimization
  • Settings UI improvements: Reorganized team management settings with collapsible sections for cleaner information hierarchy
  • Simplified template usage flow: Removed workspace selector dropdown for authenticated users; clicking "Use template" now navigates directly to the template detail page

Architecture

The implementation uses Next.js layouts and server-side redirects to manage routing:

  • Middleware allows public access to both /templates and /workspace/[workspaceId]/templates routes
  • Layout components (templates/[id]/layout.tsx) handle authentication-based redirects server-side
  • Workspace membership is verified before granting access to workspace-scoped pages
  • Public pages query only approved templates; workspace pages include star status and respect super-user permissions

Confidence Score: 5/5

  • This PR is safe to merge with proper authentication boundaries and no critical issues
  • The implementation properly handles authentication at multiple layers (middleware, layout, page), correctly verifies workspace membership, filters templates based on authentication state, and includes appropriate security measures. The code follows established patterns, includes performance optimizations, and maintains backward compatibility.
  • No files require special attention - all changes follow security best practices

Important Files Changed

File Analysis

Filename Score Overview
apps/sim/middleware.ts 5/5 Added public access rules for /templates and /workspace/[workspaceId]/templates routes to support unauthenticated template viewing
apps/sim/app/templates/page.tsx 5/5 Refactored to redirect authenticated users to workspace-scoped templates; serves only approved templates for unauthenticated users
apps/sim/app/templates/[id]/layout.tsx 5/5 New layout that redirects authenticated users from public template detail pages to workspace-scoped pages
apps/sim/app/workspace/[workspaceId]/templates/[id]/page.tsx 5/5 Workspace-scoped template detail page with authentication and membership verification; redirects unauthenticated users to public pages
apps/sim/app/templates/[id]/template.tsx 5/5 Added share button with X, LinkedIn, and copy link options; removed workspace selector dropdown for authenticated users; simplified "Use template" button flow
apps/sim/app/templates/components/template-card.tsx 5/5 Major redesign: replaced horizontal card layout with vertical card featuring workflow preview, added IntersectionObserver for performance optimization, improved memoization
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components-new/settings-modal/components/team-management/team-management.tsx 5/5 Reorganized layout to prioritize seats overview and members list; collapsed team info and billing sections into collapsible details elements for cleaner UI

Sequence Diagram

sequenceDiagram
    participant User
    participant Middleware
    participant TemplatesPage
    participant TemplateLayout
    participant TemplateDetail
    participant WorkspaceTemplates
    participant DB

    alt Unauthenticated User
        User->>Middleware: GET /templates
        Middleware->>TemplatesPage: Allow access
        TemplatesPage->>DB: Query approved templates only
        DB-->>TemplatesPage: Return templates
        TemplatesPage-->>User: Display public templates
        
        User->>Middleware: GET /templates/[id]
        Middleware->>TemplateLayout: Allow access
        TemplateLayout->>TemplateDetail: Render (isWorkspaceContext=false)
        TemplateDetail-->>User: Show template detail with "Sign in to use" button
    else Authenticated User
        User->>Middleware: GET /templates
        Middleware->>TemplatesPage: Allow access
        TemplatesPage->>DB: Query user's first workspace
        DB-->>TemplatesPage: Return workspace ID
        TemplatesPage->>User: redirect(/workspace/[workspaceId]/templates)
        
        User->>Middleware: GET /workspace/[workspaceId]/templates
        Middleware->>WorkspaceTemplates: Verify session & membership
        WorkspaceTemplates->>DB: Verify workspace membership
        DB-->>WorkspaceTemplates: Confirmed
        WorkspaceTemplates->>DB: Query templates with star status
        DB-->>WorkspaceTemplates: Return templates
        WorkspaceTemplates-->>User: Display workspace templates
        
        User->>Middleware: GET /templates/[id]
        Middleware->>TemplateLayout: Allow access
        TemplateLayout->>DB: Query user's first workspace
        DB-->>TemplateLayout: Return workspace ID
        TemplateLayout->>User: redirect(/workspace/[workspaceId]/templates/[id])
        
        User->>Middleware: GET /workspace/[workspaceId]/templates/[id]
        Middleware->>TemplateDetail: Verify session & membership
        TemplateDetail->>DB: Verify workspace membership
        DB-->>TemplateDetail: Confirmed
        TemplateDetail-->>User: Show template detail (isWorkspaceContext=true)
    end
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

28 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@icecrasher321 icecrasher321 merged commit 304fb28 into staging Nov 13, 2025
9 checks passed
@waleedlatif1 waleedlatif1 deleted the improvement/templates branch November 14, 2025 01:49
Sg312 pushed a commit that referenced this pull request Nov 14, 2025
…es for unauthenticated users and workspace one for authenticated users, improve settings style and organization (#1962)

* improvement(templates): add share button, serve public templates routes for unauthenticated users and workspace one for authenticated users, improve settings style and organization

* fix lint

---------

Co-authored-by: Vikhyath Mondreti <vikhyath@simstudio.ai>
Sg312 added a commit that referenced this pull request Nov 21, 2025
* Edit workflow returns workflow

* Condense workflkow conosle

* Limit console results to 2

* mark checkoff v1

* Mark and checkoff todo

* Fixes

* Plan mode

* fix agent output

* broken

* Fixes

* Fix diff mode persist

* Fix diff coloring

* Undo/redo

* Checkpoint udno redo

* fix(templates): fix templates details page (#1942)

* Fix template details

* Fix deps

* fix(templates-details): restore approval feature, and keep details UI consistent, smoothen out creation of profile (#1943)

* fix(templates): view current ui

* update UI to be less cluttered

* make state management for creating user profile smoother

* fix autoselect logic

* fix lint

* fix(landing): need to propagate landing page copilot prompt (#1944)

* fix(wand): subblocks should not be overwritten after wand gen (#1946)

* fix(settings): fix broken api keys, help modal, logs, workflow renaming (#1945)

* fix(settings): fix broken api keys, help modal, logs, workflow renaming

* fix build

* cleanup

* use emcn

* fix(files): changed file input value sample from string -> object (#1947)

* improvement: usage-indicator UI (#1948)

* fix(deploy): fix button (#1949)

* fix(executor): consolidate execution hooks (#1950)

* fix(autoconnect): should check if triggermode is set from the toolbar drag event directly (#1951)

* improvement: templates styling (#1952)

* improvement: template use button (#1954)

* feat(newgifs): added new gifs (#1953)

* new gifs

* changed wording

* changed wording

* lowercase

* changed wording

* remove blog stuff

---------

Co-authored-by: aadamgough <adam@sim.ai>
Co-authored-by: waleed <walif6@gmail.com>

* feat(drizzle): added ods for analytics from drizzle (#1956)

* feat(drizzle): added ods for analytics from drizzle

* clean

* fix(sheets): file selector had incorrect provider (#1958)

* feat(docs): added docs analytics drizzle ods (#1957)

* feat(docs): added docs analytics drizzle ods

* fix build

* fix provider for docs selector (#1959)

* fix(custom-tools): updates to legacy + copilot generated custom tools  (#1960)

* fix(custom-tools): updates to existing tools

* don't reorder custom tools in modal based on edit time

* restructure custom tools to persist copilot generated tools

* fix tests

* fix(slack): remove update message incorrect canonical param (#1964)

* fix(slack): send message tool

* add logging

* add more logs

* add more logs

* fix canonical param

* improvement(templates): add share button, serve public templates routes for unauthenticated users and workspace one for authenticated users, improve settings style and organization (#1962)

* improvement(templates): add share button, serve public templates routes for unauthenticated users and workspace one for authenticated users, improve settings style and organization

* fix lint

---------

Co-authored-by: Vikhyath Mondreti <vikhyath@simstudio.ai>

* fix(onedrive): incorrect canonical param (#1966)

* fix(onedrive): incorrect canonical param

* fix download file

* fix

* fix

* Revert "fix"

This reverts commit f68ccd7.

* Revert "fix"

This reverts commit f3d8ace.

* fix(executor): streaming after tool calls (#1963)

* Provider changes

* Fix lint

* fix(code): readd wand to code subblock (#1969)

* fix(cmd-k): z-index + reoder tools, triggers (#1970)

* fix(cmd-k): z-index + reoder tools, triggers

* fix more z-index styling

* fix(executor): streaming response format (#1972)

* fix(workflow-block): fix redeploy header to not repeatedly show redeploy when redeploy is not necessary (#1973)

* fix(workflow-block): fix redeploy header to not repeatedly show redeploy when redeploy is not necessary

* cleanup

* improvement(platform): chat, emcn, terminal, usage-limit (#1974)

* improvement(usage-indicator): layout

* improvement: expand default terminal height

* fix: swap workflow block ports

* improvement: chat initial positioning

* improvement(chat): display; improvement(emcn): popover attributes

* fix lint

* feat(settings): added reactquery for settings, removed zustand stores, added apollo, added workflow block selector dropdown search, added add environment variable option to empty env var dropdown (#1971)

* feat(settings): added reactquery for settings, removed zustand stores, added apollo, added workflow block selector dropdown search, added add environment variable option to empty env var dropdown

* fix delete dialog for copilot keys

* simplify combobox

* fix more z indices

* consolidated duplicate hooks

---------

Co-authored-by: Vikhyath Mondreti <vikhyath@simstudio.ai>

* fix(copilot-subflows): copilot-added subflows id mismatch (#1977)

* feat(i18n): update translations (#1978)

* feat(i18n): update translations

* fix build

---------

Co-authored-by: waleedlatif1 <waleedlatif1@users.noreply.github.com>

* fix(logs): show block inputs (#1979)

* Fix executor lgos block inputs

* Fix Comment

* fix(onedrive): parse array values correctly (#1981)

* fix(onedrive): parse array values correctly

* fix onedrive

* fix

* fix onedrive input parsing by reusing code subblock

* fix type

* feat(files): add presigned URL generation support for execution files (#1980)

* fix(popovers): billed account + async example command (#1982)

* fix(settings): update usage data in settings > subs to use reactquery hooks (#1983)

* fix(settings): update usage data in settings > subs to use reactquery hooks

* standardize usage pills calculation

* fix(output-selector): z-index in chat deploy modal (#1984)

* improvement(logs): improved logs search (#1985)

* improvement(logs): improved logs search

* more

* ack PR comments

* feat(slack): added slack full message object in response (#1987)

* feat(slack): add better error messages, reminder to add bot to app (#1990)

* feat(i18n): update translations (#1989)

Co-authored-by: waleedlatif1 <waleedlatif1@users.noreply.github.com>

* fix(landing): hero stripe icon (#1988)

* Temp

* Update

* Update

* Update

* Progress

* Diff store fixes

* simplify sockets ops for diff store

* Search patterns tool

* Better tool calls

* Fix sanitizationg

* Context window display

* fix(variables): fix double stringification (#1991)

* improvement(variables): support dot notation for nested objects (#1992)

* improvement(tanstack): migrate multiple stores (#1994)

* improvement(tanstack): migrate folders, knowledge to tanstack

* fix types

* fix(folders): duplicate (#1996)

* fix(variables): fix variables block json resolution (#1997)

* Improvement(ui/ux): signup, command-list, cursors, search modal, workflow runs, usage indicator (#1998)

* improvement: signup loading, command-list, cursors, search modal ordering

* improvement: workflow runs, search modal

* improvement(usage-indicator): ui/ux

* test(pr): hackathon (#1999)

* test(pr): github trigger (#2000)

* fix(usage-indicator): conditional rendering, upgrade, and ui/ux (#2001)

* fix: usage-limit indicator and render conditonally on is billing enabled

* fix: upgrade render

* fix(notes): fix notes, tighten spacing, update deprecated zustand function, update use mention data to ignore block positon (#2002)

* fix(pdfs): use unpdf instead of pdf-parse (#2004)

* fix(modals): fix z-index for various modals and output selector and variables (#2005)

* fix(condition): treat condition input the same as the code subblock (#2006)

* feat(models): added gpt-5.1 (#2007)

* improvement: runpath edges, blocks, active (#2008)

* feat(i18n): update translations (#2009)

* fix(triggers): check triggermode and consolidate block type (#2011)

* fix(triggers): disabled trigger shouldn't be added to dag (#2012)

* Fix disabled blocks

* Comments

* Fix api/chat trigger not found message

* fix(tags): only show start block upstream if is ancestor (#2013)

* fix(variables): Fix resolution on double < (#2016)

* Fix variable <>

* Ling

* Clean

* feat(billing): add notif for first failed payment, added upgrade email from free, updated providers that supported granular tool control to support them, fixed envvar popover, fixed redirect to wrong workspace after oauth connect (#2015)

* feat(billing): add notif for first failed payment, added upgrade email from free, updated providers that supported granular tool control to support them, fixed envvar popover, fixed redirect to wrong workspace after oauth connect

* fix build

* ack PR comments

* feat(performance): added reactquery hooks for workflow operations, for logs, fixed logs reloading, fix subscription UI (#2017)

* feat(performance): added reactquery hooks for workflow operations, for logs, fixed logs reloading, fix subscription UI

* use useInfiniteQuery for logs fetching

* fix(copilot): run workflow supports input format and fix run id (#2018)

* fix(router): fix error edge in router block + fix source handle problem (#2019)

* Fix router block error port handling

* Remove comment

* Fix edge execution

* improvement: code subblock, action bar, connections (#2024)

* improvement: action bar, connections

* fix: code block draggable resize

* fix(response): fix response block http format (#2027)

* Fix response block

* Lint

* fix(notes): fix notes block spacing, additional logs for billing transfer route (#2029)

* fix(usage-data): refetch on usage limit update in settings (#2032)

* fix(overage): fix pill calculation in the usage indicator to be consistent across views (#2034)

* fix(workflows): fixed workflow loading in without start block, added templates RQ hook, cleaned up unused templates code (#2035)

* fix(triggers): dedup + not surfacing deployment status log (#2033)

* fix(triggers): dedup + not surfacing deployment status log

* fix ms teams

* change to microsoftteams

* Revert "change to microsoftteams"

This reverts commit 217f808.

* fix

* fix

* fix provider name

* fix oauth for msteams

* improvement(undo-redo): expand undo-redo store to store 100 ops instead of 15 (#2036)

* improvement(undo-redo): expand undo-redo store to store 100 ops instead of 15

* prevent undo-redo from interfering with subblock browser text undo

* improvement(docs): remove copy page from mobile view on docs (#2037)

* improvement(docs): remove copy page from mobile view on docs

* bring title and pagenav lower on mobile

* added cursor pointer to clickable components in docs

* fix(workflow-block): clearing child workflow input format field must lazy cascade parent workflow state deletion (#2038)

* Error tools

* Ui tools

* Navigate ui tool

* Combine env vars and oauth tools

* Plan mode section

* Plan mode v1

* Plan mode v1

* Plan mode improvements

* Build plan button

* Make workflow plan editable

* Tool improvements

* Fix build plan button

* Lint

* Fix

* Fix lint

* Fix plan

* Remove migrations

* fix undo/redo settling of ops

* Add migratinos back

* Smoothen out diff store

* Hide plan mode

* Fix lint

* Edit run workflow params

* Fix lint

* Fix tests

* Fix typing

* Fix build errors and lint

* Fix build

* Fix tests

---------

Co-authored-by: Vikhyath Mondreti <vikhyathvikku@gmail.com>
Co-authored-by: Waleed <walif6@gmail.com>
Co-authored-by: Emir Karabeg <78010029+emir-karabeg@users.noreply.github.com>
Co-authored-by: Adam Gough <77861281+aadamgough@users.noreply.github.com>
Co-authored-by: aadamgough <adam@sim.ai>
Co-authored-by: Vikhyath Mondreti <vikhyath@simstudio.ai>
Co-authored-by: Emir Karabeg <emirkarabeg@berkeley.edu>
Co-authored-by: waleedlatif1 <waleedlatif1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants