fix(logs): show block inputs

[Sg312]

Summary

Show block inputs

Type of Change

• Bug fix

Testing

Manual

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
docs	Skipped			Nov 14, 2025 2:15am

[greptile-apps]

Greptile Overview

Greptile Summary

This PR adds block input logging to the execution flow by capturing resolved inputs in the blockLog.input field, improving observability for workflow execution debugging.

Key Changes:

• Block Input Logging: Added blockLog.input = resolvedInputs after input resolution in block-executor.ts:75-77, ensuring resolved inputs are captured in logs alongside outputs
• Environment Detection: Changed isHosted from hardcoded true to dynamic check based on NEXT_PUBLIC_APP_URL, enabling proper distinction between hosted and self-hosted instances

Issues Found:

• The isHosted change is a semantic breaking change that will cause isHosted to be false for any self-hosted instance where NEXT_PUBLIC_APP_URL is not set to the exact production or staging URLs. This affects multiple critical code paths including API key rotation and authentication middleware.

Confidence Score: 3/5

• This PR introduces a breaking change to environment detection logic that may affect self-hosted deployments
• The block input logging change is solid and safe (5/5), but the isHosted change introduces a semantic breaking change that will affect self-hosted instances. The new logic assumes NEXT_PUBLIC_APP_URL is explicitly set to production/staging URLs for hosted instances, but self-hosted instances may have this unset or set to different values, causing isHosted to flip from true to false. This affects critical features like API key rotation and auth redirects.
• Pay close attention to apps/sim/lib/environment.ts - the isHosted change may break self-hosted deployments

Important Files Changed

File Analysis

Filename	Score	Overview
apps/sim/executor/execution/block-executor.ts	5/5	Added block input logging to blockLog.input after input resolution - straightforward and correct implementation
apps/sim/lib/environment.ts	3/5	Changed isHosted from hardcoded true to dynamic URL check - potential breaking change for self-hosted instances

Sequence Diagram

sequenceDiagram
    participant Executor
    participant BlockExecutor
    participant VariableResolver
    participant BlockHandler
    participant BlockLog

    Executor->>BlockExecutor: execute(ctx, node, block)
    BlockExecutor->>BlockExecutor: findHandler(block)
    
    alt not sentinel block
        BlockExecutor->>BlockLog: createBlockLog()
        BlockExecutor->>BlockLog: push to ctx.blockLogs
        BlockExecutor->>Executor: onBlockStart callback
    end
    
    BlockExecutor->>VariableResolver: resolveInputs(ctx, node.id, params, block)
    VariableResolver-->>BlockExecutor: resolvedInputs
    
    Note over BlockExecutor,BlockLog: NEW: Log resolved inputs
    BlockExecutor->>BlockLog: blockLog.input = resolvedInputs
    
    BlockExecutor->>BlockHandler: execute(ctx, block, resolvedInputs)
    BlockHandler-->>BlockExecutor: output
    
    BlockExecutor->>BlockExecutor: normalizeOutput(output)
    BlockExecutor->>BlockLog: update endedAt, durationMs, success, output
    
    alt not sentinel block
        BlockExecutor->>Executor: onBlockComplete callback
    end
    
    BlockExecutor-->>Executor: normalizedOutput

Loading

[greptile-apps]

_{2 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

logic: isHosted will be false if NEXT_PUBLIC_APP_URL is undefined or set to any other value. Before this change, isHosted was always true. This semantic change may break self-hosted instances that depend on hosted-only features (like API key rotation in providers/utils.ts:629 or redirect logic in middleware.ts:30).

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/sim/lib/environment.ts
Line: 24:26

Comment:
**logic:** `isHosted` will be `false` if `NEXT_PUBLIC_APP_URL` is undefined or set to any other value. Before this change, `isHosted` was always `true`. This semantic change may break self-hosted instances that depend on hosted-only features (like API key rotation in `providers/utils.ts:629` or redirect logic in `middleware.ts:30`).

How can I resolve this? If you propose a fix, please make it concise.