Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve data snapshots pagination navigation fix #12548 #12552

Merged
merged 4 commits into from
Sep 22, 2024
Merged

Improve data snapshots pagination navigation fix #12548 #12552

merged 4 commits into from
Sep 22, 2024

Conversation

TCOTC
Copy link
Contributor

@TCOTC TCOTC commented Sep 22, 2024 •
edited
Loading

  • 把按钮移到左边，文本在右边，避免文本宽度影响按钮位置（各语种的按钮位置都有偏差，用起来怪怪的）
  • 数字和文本之间添加间隔（一个空格）
  • 文本简化为单个 span 元素、像搜索界面顶部的文本一样显示为灰色、窗口宽度减小之后文本不换行
    <span class="ft__on-surface fn__flex-shrink ft__selectnone">共 1 页, 2 个快照</span>

原来的样式：

image

参考搜素界面：

image

本 PR 修改后的样式：

image

@TCOTC TCOTC marked this pull request as ready for review September 22, 2024 11:30
@TCOTC TCOTC changed the title Improve data snapshots pagination navigation Improve data snapshots pagination navigation fix #12548 Sep 22, 2024
@TCOTC
Copy link
Contributor Author

TCOTC commented Sep 22, 2024

可以 Review 了

@TCOTC TCOTC mentioned this pull request Sep 22, 2024
Closed
2 tasks
@TCOTC TCOTC mentioned this pull request Sep 22, 2024
Closed
@88250 88250 merged commit 5d97e4f into siyuan-note:dev Sep 22, 2024
1 check passed
@88250
Copy link
Member

88250 commented Sep 22, 2024

感谢你的贡献，思源有你更精彩！
Thank you for your contribution. SiYuan will be more wonderful with you!

@TCOTC TCOTC deleted the dev-pagination-navigation branch September 22, 2024 14:35
This was referenced Sep 22, 2024
Merged
Merged
88250 pushed a commit that referenced this pull request Sep 23, 2024
@TCOTC
🎨 Improve pagination navigation fix #12552 #12563 (#12567)
a8f183a 
* Improve pagination navigation

* const pageElement

* remove fn__none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@88250 88250 88250 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TCOTC @88250