Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File history support pagination navigation #12563

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

frostime
Copy link
Contributor

Feature or bug? 特性或者缺陷?

image

Multilingual or copywriting? 多语言或者文案?

Please submit directly, we will evaluate.
请直接提交,我们会进行评估。

Dev branch!

Any changes should be submitted to the dev branch.
任何改动,请提交到 dev 分支。

@TCOTC
Copy link
Contributor

TCOTC commented Sep 23, 2024

@88250 先合并 #12562 ,然后在这个 PR 增加一行意大利语

@TCOTC
Copy link
Contributor

TCOTC commented Sep 23, 2024

要不把我在 #12552 写的 total-page 也改成 data-totalpage

p.s. 中间的 p 需不需要用大写 P?

@frostime
Copy link
Contributor Author

要不把我在 #12552 写的 total-page 也改成 data-totalpage

p.s. 中间的 p 需不需要用大写 P?

这个任意吧。

之前的 total-page 是 classname,这个 data-totalpage 是元素的 dataset 属性,我写的时候想起来似乎 js 会自动对 dataset 中的名称进行转换又记不清细节了,怕出错又懒得查就连在一起小写了。

@TCOTC
Copy link
Contributor

TCOTC commented Sep 23, 2024

那就先不管了(主要是 data- 我感觉好像更顺眼一点)

@frostime
Copy link
Contributor Author

frostime commented Sep 23, 2024 via email

@TCOTC TCOTC mentioned this pull request Sep 22, 2024
2 tasks
@88250 88250 added this to the 3.1.7 milestone Sep 23, 2024
@TCOTC

This comment was marked as outdated.

@88250 88250 changed the title 对文件历史也添加页面跳转 File history support pagination navigation Sep 23, 2024
@88250 88250 merged commit 8c8c7c9 into siyuan-note:dev Sep 23, 2024
2 checks passed
@88250
Copy link
Member

88250 commented Sep 23, 2024

感谢你的贡献,思源有你更精彩!
Thank you for your contribution. SiYuan will be more wonderful with you!

@TCOTC
Copy link
Contributor

TCOTC commented Sep 23, 2024

@88250 记得顺便在 ${y} 前面加空格

@88250
Copy link
Member

88250 commented Sep 23, 2024

哪个地方?

88250 added a commit that referenced this pull request Sep 23, 2024
@TCOTC
Copy link
Contributor

TCOTC commented Sep 23, 2024

image

88250 added a commit that referenced this pull request Sep 23, 2024
@88250
Copy link
Member

88250 commented Sep 23, 2024

好的,ok 了

PS:这个 pending 的状态没有提交,我这里看不到的
image

@TCOTC
Copy link
Contributor

TCOTC commented Sep 23, 2024

一直理解错了,原来这个 pending 是没提交的意思,不是待回复的意思。

参考:https://github.com/orgs/community/discussions/10369

image

@88250
Copy link
Member

88250 commented Sep 23, 2024

嗯,review 完要提交的。

88250 pushed a commit that referenced this pull request Sep 23, 2024
* Improve pagination navigation

* const pageElement

* remove fn__none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants