Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nv/optimize slinky adapter #18

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

Nv/optimize slinky adapter #18

wants to merge 36 commits into from

Conversation

nivasan1
Copy link

Changelist

[Describe or list the changes made in this PR]

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

dydxwill and others added 30 commits March 15, 2024 15:54
@dydxwill
rename metric (dydxprotocol#1183)
085b88e
@dydxwill
fix stats prefix for trading rewards API (dydxprotocol#1184)
1a971d0
@tqin7
[TRA-116] add x/vault total shares store (dydxprotocol#1179)
434bf65 
* add x/vault total shares store

* return error if shares is negative
@tqin7
refactor cancel order msg server logic into a keeper method (dydxprot…
dd3f00c 
…ocol#1175)
@vincentwschau
[TRA-80] Update subaccount-to-subaccount transfers for collateral poo…
f0fe4cc 
…ls. (dydxprotocol#1178)
@tqin7
refactor place order msg server logic into keeper (dydxprotocol#1180)
00cd3d5
@dydxwill
use read replica rather than main instance (dydxprotocol#1190)
1482a88
@shrenujb
Add subaccountNumber field in fills response result (dydxprotocol#1192)
b458799 
Signed-off-by: Shrenuj Bansal <shrenuj@dydx.exchange>
@jonfung-dydx
Fix mock gen (dydxprotocol#1194)
cbf85cb
@jonfung-dydx
[Fix mock gen pt 2] oracle client mock in its own file (dydxprotocol#…
ab14ab8 
…1195)

* oracle client mock in its own file

* remove the dupe
@shrenujb
[TRA-102] add subaccountNumber field in assetPositions return result (d…
f6afd11 
…ydxprotocol#1187)


Signed-off-by: Shrenuj Bansal <shrenuj@dydx.exchange>
@tqin7
[TRA-85] scaffold x/vault endblocker (dydxprotocol#1197)
d7333d4 
* scaffold x/vault endblocker
@jonfung-dydx
[CT-515] Combine place, cancel, batch cancel rate limiters (dydxproto…
be4ba54 
…col#1165)

* combine place and cancel rate limiters, add batch cancel

* fixups

* remove cancel rate limit genesis

* fix json files for genesis

* update sample pregenesis

* get tests to work

* update protos to deprecate instead of remove

* lint fix

* empty commit

* fix tests

* lint

* basic tests with only batch cancel orders submitted

* fix cli rate limit test

* e2e tests

* rate limit 2 -> 3

* more explicit replay test

* todo comment

* linty lint

* constants for the tests

* rate limit proto deprecate => reserved

* sample pregenesis update

* indexer proto regen

* fix tests

* fix test

* upgrade handler for batch cancel configs

* upgrade handler

* proto swap reserved back to deprecated

* more test fix

* try upgrade

* fix test

* regen indexer protos

* proto lint

* test fix

* upgrade file comment
@dydxwill
Do not emit stat if we are skipping block (dydxprotocol#1202)
a550d20
@Eric-Warehime
test: Fix flaky slinky client test (dydxprotocol#1199)
7312cc1 
* Move slinky daemon tests into single suite

* Move grpc listen out of test suite

* Remove server

* Move to singular model

* Remove unncessary test vars
@Eric-Warehime
feat: Enforce MarketParam.Pair uniqueness constraint (dydxprotocol#1193)
0e816e5 
* Enforce MarketParam.Pair uniqueness constraint

* Fix perps tests

* Fix the rest of the tests

* Prevent updating MarketParam.Pair

* Fix lint

* Fix prices test

* Allow updates again
@vincentwschau
[TRA-108] Add market type to indexer events. (dydxprotocol#1201)
9888453
@jonfung-dydx
[CT-509] Batch Cancel CLI + additional validation (dydxprotocol#1204)
75cc26a
@Eric-Warehime
feat: Slinky full integration PR (dydxprotocol#1141)
12e9e28 
* Squashed commit of the following:

commit 96d900d
Author: Eric <eric.warehime@gmail.com>
Date:   Tue Mar 5 08:51:29 2024 -0800

    Fix non-initialized return values

commit 9ec7992
Author: Eric <eric.warehime@gmail.com>
Date:   Tue Mar 5 08:42:48 2024 -0800

    Upstream compat

commit 47809c7
Merge: 7607b9e f6b594c
Author: Eric <eric.warehime@gmail.com>
Date:   Tue Mar 5 08:40:34 2024 -0800

    Merge remote-tracking branch 'upstream' into eric/protocol-feature-flags

commit 7607b9e
Author: Eric <eric.warehime@gmail.com>
Date:   Mon Mar 4 14:58:06 2024 -0800

    Fix accidental deletes

commit 297b592
Author: Eric <eric.warehime@gmail.com>
Date:   Mon Mar 4 14:22:06 2024 -0800

    Merge

commit 6c32623
Merge: 5811502 daad125
Author: Eric <eric.warehime@gmail.com>
Date:   Mon Mar 4 13:50:26 2024 -0800

    Merge remote-tracking branch 'origin/eric/ve-logic' into eric/protocol-feature-flags

commit 5811502
Merge: 6adf756 7feaddb
Author: Eric <eric.warehime@gmail.com>
Date:   Mon Mar 4 13:49:23 2024 -0800

    Merge remote-tracking branch 'origin/eric/proposal-logic' into eric/protocol-feature-flags

commit 6adf756
Merge: c84eb82 88675f5
Author: Eric <eric.warehime@gmail.com>
Date:   Mon Mar 4 13:44:46 2024 -0800

    Merge remote-tracking branch 'origin/eric/sidecar-integration' into eric/protocol-feature-flags

commit daad125
Author: Eric <eric.warehime@gmail.com>
Date:   Mon Mar 4 10:51:23 2024 -0800

    VoteExtension slinky logic

commit 7feaddb
Author: Eric <eric.warehime@gmail.com>
Date:   Sun Mar 3 21:28:32 2024 -0800

    Fix import order

commit 382d45c
Author: Eric <eric.warehime@gmail.com>
Date:   Sun Mar 3 21:24:41 2024 -0800

    Prepare and Process logic for Slinky

commit 88675f5
Author: Eric <eric.warehime@gmail.com>
Date:   Tue Feb 27 12:46:33 2024 -0800

    Register daemon with health monitor

commit 8438d54
Author: Eric <eric.warehime@gmail.com>
Date:   Tue Feb 27 12:32:36 2024 -0800

    PR updates

commit 3046d69
Author: Eric <eric.warehime@gmail.com>
Date:   Mon Feb 26 15:05:52 2024 -0800

    Make unflaky

commit 7799d29
Author: Eric <eric.warehime@gmail.com>
Date:   Mon Feb 26 15:01:18 2024 -0800

    Lints, more tests

commit e0a8c37
Author: Eric <eric.warehime@gmail.com>
Date:   Mon Feb 26 14:35:11 2024 -0800

    Add tests

commit d8e5e90
Author: Eric <eric.warehime@gmail.com>
Date:   Sat Feb 24 21:01:35 2024 -0800

    Add interfaces, generate mocks

commit 3a8ebec
Author: Eric <eric.warehime@gmail.com>
Date:   Sat Feb 24 10:18:33 2024 -0800

    Lint

commit 5cdd35f
Author: Eric <eric.warehime@gmail.com>
Date:   Sat Feb 24 10:09:56 2024 -0800

    Initial commit of sidecar integration

* Don't update min_exchanges

* go mod tidy

* Fix error

* Update sample pregenesis

* Remove unncessary updates

* Update flags and handlers

* Don't chain mock makefile

* Remove oracle_client

* Update init

* Update opts

* update app

* Fix rewards test

* Fix clob tests

* Fix prices cli test
@tqin7
[TRA-134] construct simple vault orders (dydxprotocol#1206)
bd041ab 
* construct simple vault orders

* simplify test and address comments
@nivasan1
bug: Handle paginated querying to prices-keeper in slinky + pricefeed…
852930e 
… daemon (dydxprotocol#1177)

* implement paginated querying

* tests

* lint

* lint

* move to shared pkg

* linting

* lint
@vincentwschau
[TRA-126] Add E2E test for isolated subaccount transfers. (dydxprotoc…
1249edf 
…ol#1188)
@jonfung-dydx
Fix upgrade rate limit config logic, add helpful logs (dydxprotocol#1212
9310bb2 
)

* fix upgrade rate limit config bug to correct value

* less aggressive newline
@roy-dydx
Upgrade cosmos fork to use libsecp256k1 from go-ethereum (dydxprotoco…
42cbee6 
…l#1210)
@dydxwill
pass initial kafka timestamp from Ender -> Vulcan for better e2e orde…
293bb47 
…r latency tracking (dydxprotocol#1211)
@Eric-Warehime
Remove smoothed prices (dydxprotocol#1215)
45c91d7
@jayy04
[CT-700] separate indexer and grpc streaming events (dydxprotocol#1209)
75937e1 
* [CT-700] separate indexer and grpc streaming events

* fix tests

* comments

* update
@shrenujb
[TRA-103] Add parentSubaccountNumber endpoint for fills (dydxprotocol…
f5556ac 
…#1205)


Signed-off-by: Shrenuj Bansal <shrenuj@dydx.exchange>
@jayy04
[CT-700] only send response when there is at least one update (dydxpr…
83ce840 
…otocol#1216)
@Christopher-Li
Update go version to 1.22 in README.md (dydxprotocol#1196)
33038ff
@nivasan1 nivasan1 force-pushed the nv/optimize-slinky-adapter branch from 4534aa5 to 6ad0520 Compare March 21, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@nivasan1 @dydxwill @tqin7 @vincentwschau @shrenujb @jonfung-dydx @Eric-Warehime @roy-dydx @jayy04 @Christopher-Li