[Feat] Sui Core changes #19193
Merged
[Feat] Sui Core changes #19193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
stackman27
requested review from
0xAustinWang,
KodeyThomas,
b-gopalswami,
makramkd,
matYang,
mateusz-sekara and
winder
product-security-plaid-test
bot
requested review from
ChrisAmora,
pavel-raykov and
vicentevieytes
FelixFan1992
reviewed
Sep 4, 2025
| } | ||
|
|
||
| // newFrom creates a new Account from a provided random reader | ||
| func newFrom(reader io.Reader) (Key, error) { |
Contributor
There was a problem hiding this comment.
looking at the issue raised below, do we use this function in production or only in test?
Contributor
|
You could consider updating |
cfal
previously approved these changes
Sep 15, 2025
jmank88
previously approved these changes
Sep 16, 2025
|
jmank88
approved these changes
Sep 16, 2025
winder
approved these changes
Sep 16, 2025
chris-de-leon-cll
approved these changes
Sep 16, 2025
b-gopalswami
approved these changes
Sep 16, 2025
This was referenced Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Supports
imported changes from: #17618