Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement replication between different buckets and within the same bucket #220

Closed
wants to merge 16 commits into from
Closed

Implement replication between different buckets and within the same bucket #220

wants to merge 16 commits into from

Conversation

yuejuSDS
Copy link
Contributor

@yuejuSDS yuejuSDS commented Dec 1, 2019 •
edited
Loading

image
image2

This PR is dependent on https://github.com/opensds/opensds-dashboard/issues/219

change:
1.Copy between different buckets；
2.Copy in the same bucket

@anvithks @wisererik Please check whether it can be merged.

@anvithks anvithks added the DAITO label Dec 2, 2019
@anvithks anvithks added this to the Daito SODA v1.0 milestone Dec 2, 2019
@anvithks
Copy link
Member

anvithks commented Dec 2, 2019

@yuejuSDS @jimccfun Please attach screenshots for the screens that are implemented.

anvithks and others added 9 commits December 2, 2019 22:17
@anvithks @wisererik
Fixed incorrect accessProtocol values in create Profile. Uppercase va…
a584fea 
…lues to lowercase. (sodafoundation#221)
@anvithks
Fixed Object listing page to match changed Backend response
09cae18
@kumarashit
Merge pull request sodafoundation#223 from anvithks/development
4a14daa 
Fixed Object listing page to match changed Backend response
@anvithks
Fixes sodafoundation#225. Fix Display host details.
c6adc4c
@anvithks
Fixes sodafoundation#227. Fixed host dropdown in volume provision ser…
b23f015 
…vice.
@anvithks
Added date pipes to created and modified time. Fixed some display and…
c8e8370 
… alignment issues.
@anvithks
Fixes sodafoundation#229. Added Missing Label in Attach host and othe…
4611968 
…r style issues.
@kumarashit
Merge pull request sodafoundation#226 from anvithks/host-details225
d3ad5b2 
Fixes sodafoundation#225. Fix Display host details.
@kumarashit
Merge pull request sodafoundation#228 from anvithks/orch-dropdown
7bb8daf 
Fixes sodafoundation#227. Fixed host dropdown in volume provision service.
anvithks
anvithks requested changes Dec 5, 2019
View reviewed changes
Copy link
Member

@anvithks anvithks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimccfun Please rebase your code and make the changes please.
the list of objects had to be changed as the backend response is different now.

src/app/business/block/bucket-detail/bucket-detail.component.html Show resolved Hide resolved
anvithks
anvithks requested changes Dec 6, 2019
View reviewed changes
Copy link
Member

@anvithks anvithks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please attach screenshots of the final screens and address the review comments.
EDIT: I did not see the attachments before this comment. Please address review comments.

src/app/business/block/bucket-detail/bucket-detail.component.ts Show resolved Hide resolved
src/app/business/block/bucket-detail/bucket-detail.component.ts Show resolved Hide resolved
src/app/business/block/bucket-detail/bucket-detail.component.ts Show resolved Hide resolved
anvithks
anvithks approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@anvithks anvithks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anvithks anvithks added feature New feature and removed on-hold labels Dec 6, 2019
@anvithks anvithks mentioned this pull request Dec 7, 2019
Closed
anvithks
anvithks requested changes Dec 11, 2019
View reviewed changes
Copy link
Member

@anvithks anvithks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuejuSDS @jimccfun Could you please link the Backend PR that implement the feature.
There is a confusion between Copy Object and Replication between Buckets.

Is your PR supporting this PR from opensds/multi-cloud #728

@yuejuSDS yuejuSDS closed this Dec 12, 2019
@yuejuSDS yuejuSDS reopened this Dec 12, 2019
@anvithks
Copy link
Member

Please rebase your branch and push your changes.
@yuejuSDS @jimccfun

@yuejuSDS yuejuSDS closed this Dec 12, 2019
@yuejuSDS yuejuSDS deleted the new_dev branch December 12, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anvithks anvithks anvithks requested changes

Assignees
No one assigned
Labels
DAITO feature New feature
Projects
None yet
Milestone
Daito SODA v1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@yuejuSDS @anvithks @jimccfun @kumarashit @wisererik