Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resync issue #425

Merged
merged 1 commit into from
Dec 19, 2020
Merged

Conversation

ThisIsClark
Copy link
Collaborator

What this PR does / why we need it:
Set update_at of the specific storage before starting to sync the storage.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #424

Special notes for your reviewer:

Release note:

1. Send sync request, the request can be handled successfully
2. Send sync request, and before sync task is done, send the same request again, it throwed StorageIsSyncing exception
3. Send sync request after 30 mins of last sync task, and before sync task is done, send the same request again, it throwed StorageIsSyncing exception
4. Send sync request, and if sync task is not done after 30 mins, send the sync request again, the request can be handled.

@ThisIsClark ThisIsClark changed the base branch from master to v0.8.0-maint December 10, 2020 08:11
NajmudheenCT
NajmudheenCT previously approved these changes Dec 14, 2020
Copy link
Member

@NajmudheenCT NajmudheenCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kumarashit
kumarashit previously approved these changes Dec 14, 2020
Copy link
Collaborator

@kumarashit kumarashit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NajmudheenCT
Copy link
Member

@ThisIsClark Can you push a dummy commit to trigger the CI again

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #425 (a58c895) into v0.8.0-maint (2bbaeb7) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           v0.8.0-maint     #425      +/-   ##
================================================
- Coverage         67.10%   67.09%   -0.02%     
================================================
  Files                93       93              
  Lines              6688     6689       +1     
  Branches            777      777              
================================================
  Hits               4488     4488              
- Misses             1942     1943       +1     
  Partials            258      258              
Impacted Files Coverage Δ
delfin/api/v1/storages.py 72.22% <0.00%> (-0.58%) ⬇️

Copy link
Member

@NajmudheenCT NajmudheenCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kumarashit kumarashit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wisererik wisererik merged commit 87e65f3 into sodafoundation:v0.8.0-maint Dec 19, 2020
joseph-v pushed a commit to joseph-v/delfin that referenced this pull request Dec 23, 2020
joseph-v pushed a commit to joseph-v/delfin that referenced this pull request Dec 23, 2020
kumarashit pushed a commit that referenced this pull request Jan 2, 2021
* Code improvement (#363)

* ibm storwize_svc add sshpool and fixed some issue (#381)

Add storage driver for IBM Storwize and svc series

* add hitachi vsp storage driver to community (#388)

Add hitachi vsp driver

* Fix vsp driver issue

* change pool status and some optimize for vsp (#395)

* rest api change timeout and fix trap parse (#401)

* fix ssh excption error when the port is wrong and do some optimize (#402)

* Update the value of 'update_at' of storage when going to sync the storage (#425)

* Code improvement (#363)

* ibm storwize_svc add sshpool and fixed some issue (#381)

Add storage driver for IBM Storwize and svc series

* add hitachi vsp storage driver to community (#388)

Add hitachi vsp driver

* Fix vsp driver issue

* change pool status and some optimize for vsp (#395)

* rest api change timeout and fix trap parse (#401)

* fix ssh excption error when the port is wrong and do some optimize (#402)

* Update the value of 'update_at' of storage when going to sync the storage (#425)

* Fix rebase issue

* Fixing CI failure issues

Co-authored-by: ThisIsClark <liuyuchibubao@gmail.com>
Co-authored-by: jiangyutan <69443713+jiangyutan@users.noreply.github.com>
Co-authored-by: Joseph Vazhappilly <josephvp@gmail.com>
Co-authored-by: root <pravin ranjan>
amanr032 pushed a commit to amanr032/delfin that referenced this pull request Dec 5, 2022
* add gelato-ha install and uninstall roles

* updated the branch

* fix review comments

* Installer changes for dashboard integration to Multi-Cloud HA

* update branch

* resolve review comments

* fix review comments

* update multicloud variables in gelato-ha.yml

* update branch

* resolve review comments

* resolve review comments

* use mulitcloud_api_ip instead of api_ip

* update branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync request can be sent again when the storage is already syncing
4 participants