-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix resync issue #425
Fix resync issue #425
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ThisIsClark Can you push a dummy commit to trigger the CI again |
a58c895
8031c9b
to
a58c895
Compare
Codecov Report
@@ Coverage Diff @@
## v0.8.0-maint #425 +/- ##
================================================
- Coverage 67.10% 67.09% -0.02%
================================================
Files 93 93
Lines 6688 6689 +1
Branches 777 777
================================================
Hits 4488 4488
- Misses 1942 1943 +1
Partials 258 258
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Code improvement (#363) * ibm storwize_svc add sshpool and fixed some issue (#381) Add storage driver for IBM Storwize and svc series * add hitachi vsp storage driver to community (#388) Add hitachi vsp driver * Fix vsp driver issue * change pool status and some optimize for vsp (#395) * rest api change timeout and fix trap parse (#401) * fix ssh excption error when the port is wrong and do some optimize (#402) * Update the value of 'update_at' of storage when going to sync the storage (#425) * Code improvement (#363) * ibm storwize_svc add sshpool and fixed some issue (#381) Add storage driver for IBM Storwize and svc series * add hitachi vsp storage driver to community (#388) Add hitachi vsp driver * Fix vsp driver issue * change pool status and some optimize for vsp (#395) * rest api change timeout and fix trap parse (#401) * fix ssh excption error when the port is wrong and do some optimize (#402) * Update the value of 'update_at' of storage when going to sync the storage (#425) * Fix rebase issue * Fixing CI failure issues Co-authored-by: ThisIsClark <liuyuchibubao@gmail.com> Co-authored-by: jiangyutan <69443713+jiangyutan@users.noreply.github.com> Co-authored-by: Joseph Vazhappilly <josephvp@gmail.com> Co-authored-by: root <pravin ranjan>
* add gelato-ha install and uninstall roles * updated the branch * fix review comments * Installer changes for dashboard integration to Multi-Cloud HA * update branch * resolve review comments * fix review comments * update multicloud variables in gelato-ha.yml * update branch * resolve review comments * resolve review comments * use mulitcloud_api_ip instead of api_ip * update branch
What this PR does / why we need it:
Set update_at of the specific storage before starting to sync the storage.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #424Special notes for your reviewer:
Release note: