Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delfin 0.8.0 to master #439

Merged
merged 20 commits into from
Jan 2, 2021
Merged

delfin 0.8.0 to master #439

merged 20 commits into from
Jan 2, 2021

Conversation

PravinRanjan10
Copy link
Contributor

@PravinRanjan10 PravinRanjan10 commented Dec 31, 2020 •
edited by NajmudheenCT
Loading

What this PR does / why we need it:

Rebasing 0.8.0 to master

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Test Report:
Some basic sanity on below functionality usng fake driver

  • register storage
  • list storage resources
  • sync
  • sync all
  • delete
  • register alert source
  • sync alert
  • list alerts
  • register storage for performance collection
  • exporting to prometheus
  • exporting to kafka
  • exporting alert to alert manager

Release note:

ThisIsClark and others added 19 commits November 2, 2020 11:16
@ThisIsClark
Code improvement (sodafoundation#363)
4d8429d
@jiangyutan
ibm storwize_svc add sshpool and fixed some issue (sodafoundation#381)
068fcc8 
Add storage driver for IBM Storwize and svc series
@jiangyutan
add hitachi vsp storage driver to community (sodafoundation#388)
ae88070 
Add hitachi vsp driver
@jiangyutan
Fix vsp driver issue
deb23be
@jiangyutan
change pool status and some optimize for vsp (sodafoundation#395)
a8ca53b
@jiangyutan
rest api change timeout and fix trap parse (sodafoundation#401)
7be276d
@jiangyutan
fix ssh excption error when the port is wrong and do some optimize (s…
2bbaeb7 
…odafoundation#402)
@ThisIsClark
Update the value of 'update_at' of storage when going to sync the sto…
87e65f3 
…rage (sodafoundation#425)
@ThisIsClark @joseph-v
Code improvement (sodafoundation#363)
34b0314
@jiangyutan @joseph-v
ibm storwize_svc add sshpool and fixed some issue (sodafoundation#381)
5d7edd8 
Add storage driver for IBM Storwize and svc series
@jiangyutan @joseph-v
add hitachi vsp storage driver to community (sodafoundation#388)
64aa602 
Add hitachi vsp driver
@jiangyutan @joseph-v
Fix vsp driver issue
02fb1de
@jiangyutan @joseph-v
change pool status and some optimize for vsp (sodafoundation#395)
ff83713
@jiangyutan @joseph-v
rest api change timeout and fix trap parse (sodafoundation#401)
8c03adc
@jiangyutan @joseph-v
fix ssh excption error when the port is wrong and do some optimize (s…
7a09a64 
…odafoundation#402)
@ThisIsClark @joseph-v
Update the value of 'update_at' of storage when going to sync the sto…
74a15af 
…rage (sodafoundation#425)
@joseph-v
Fix rebase issue
282fe68
@joseph-v
Merge branch 'v0.8.0-maint' into v0.8.0-maint
61d3626
Fixing CI failure issues
9944731
@PravinRanjan10 PravinRanjan10 changed the title Joseph 0.8.0 to master delfin 0.8.0 to master Dec 31, 2020
@codecov
Copy link

codecov bot commented Dec 31, 2020 •
edited
Loading

Codecov Report

Merging #439 (91ff7af) into master (e1f1934) will increase coverage by 0.02%.
The diff coverage is 66.79%.

@@            Coverage Diff             @@
##           master     #439      +/-   ##
==========================================
+ Coverage   67.91%   67.94%   +0.02%     
==========================================
  Files         104      109       +5     
  Lines        7178     7858     +680     
  Branches      798      885      +87     
==========================================
+ Hits         4875     5339     +464     
- Misses       2066     2232     +166     
- Partials      237      287      +50
Impacted Files Coverage Δ
delfin/alert_manager/snmp_validator.py 61.79% <ø> (-0.43%) ⬇️
delfin/api/v1/storages.py 72.22% <0.00%> (-0.58%) ⬇️
...rs/dell_emc/vmax/alert_handler/unisphere_alerts.py 34.21% <0.00%> (ø)
delfin/drivers/dell_emc/vmax/client.py 72.90% <ø> (ø)
delfin/drivers/hpe/hpe_3par/rest_handler.py 50.00% <0.00%> (-0.93%) ⬇️
delfin/drivers/huawei/oceanstor/rest_client.py 71.79% <0.00%> (-1.13%) ⬇️
delfin/drivers/manager.py 55.55% <0.00%> (-8.38%) ⬇️
delfin/task_manager/tasks/alerts.py 31.57% <9.09%> (-9.17%) ⬇️
delfin/task_manager/manager.py 38.09% <20.00%> (-0.24%) ⬇️
delfin/task_manager/rpcapi.py 58.62% <33.33%> (-2.92%) ⬇️
... and 34 more

@sushanthakumar
Copy link
Collaborator

sushanthakumar commented Jan 2, 2021 •
edited
Loading

Sanity Test with fake storage:
Resource collection and alert sync during device registration:
image

Alert source registrtaion:
image

Clear alert API flow:
image

Snmp trap flow:
image

Sync alert api flow:
image

NajmudheenCT
NajmudheenCT approved these changes Jan 2, 2021
View reviewed changes
Copy link
Member

@NajmudheenCT NajmudheenCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kumarashit
kumarashit approved these changes Jan 2, 2021
View reviewed changes
Copy link
Collaborator

@kumarashit kumarashit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Branch sync, tests done

@kumarashit kumarashit merged commit 1073b05 into sodafoundation:master Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumarashit kumarashit kumarashit approved these changes

@NajmudheenCT NajmudheenCT NajmudheenCT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@PravinRanjan10 @sushanthakumar @NajmudheenCT @kumarashit @ThisIsClark @jiangyutan @joseph-v