rest api change timeout and fix trap parse #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v0.8.0-maint #401 +/- ##
================================================
- Coverage 67.07% 67.05% -0.02%
================================================
Files 93 93
Lines 6701 6700 -1
Branches 784 784
================================================
- Hits 4495 4493 -2
Misses 1943 1943
- Partials 263 264 +1
|
ThisIsClark
reviewed
Dec 1, 2020
| return result_json | ||
|
|
||
| def get_all_pools(self): | ||
| url = '%s/%s/pools' % \ | ||
| (RestHandler.COMM_URL, self.storage_device_id) | ||
| result_json = self.get_rest_info(url) | ||
| result_json = self.get_rest_info(url, timeout=consts.SOCKET_TIMEOUT) |
There was a problem hiding this comment.
This could be a default parameter
joseph-v
pushed a commit
to joseph-v/delfin
that referenced
this pull request
Dec 23, 2020
joseph-v
pushed a commit
to joseph-v/delfin
that referenced
this pull request
Dec 23, 2020
kumarashit
pushed a commit
that referenced
this pull request
Jan 2, 2021
* Code improvement (#363) * ibm storwize_svc add sshpool and fixed some issue (#381) Add storage driver for IBM Storwize and svc series * add hitachi vsp storage driver to community (#388) Add hitachi vsp driver * Fix vsp driver issue * change pool status and some optimize for vsp (#395) * rest api change timeout and fix trap parse (#401) * fix ssh excption error when the port is wrong and do some optimize (#402) * Update the value of 'update_at' of storage when going to sync the storage (#425) * Code improvement (#363) * ibm storwize_svc add sshpool and fixed some issue (#381) Add storage driver for IBM Storwize and svc series * add hitachi vsp storage driver to community (#388) Add hitachi vsp driver * Fix vsp driver issue * change pool status and some optimize for vsp (#395) * rest api change timeout and fix trap parse (#401) * fix ssh excption error when the port is wrong and do some optimize (#402) * Update the value of 'update_at' of storage when going to sync the storage (#425) * Fix rebase issue * Fixing CI failure issues Co-authored-by: ThisIsClark <liuyuchibubao@gmail.com> Co-authored-by: jiangyutan <69443713+jiangyutan@users.noreply.github.com> Co-authored-by: Joseph Vazhappilly <josephvp@gmail.com> Co-authored-by: root <pravin ranjan>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
rest api change timeout and fix trap parse
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: