Fixes for code analysis warnings #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add content missing from the README.md taken from the Yotta/Mbed OS 3 Readme.
Numerous changes to language, grammar, and corrections, following review.
For Windows-formatted SD card, it is not partitioned (no MBR), but its PBR has the same boot signature (0xaa55) as MBR. We would easily mis-recognize this SD card has valid partitions if we only check partition type. We add check by only accepting 0x00 (inactive) /0x80 (active) for valid partition status.
Copy edit file.
Update the LowPowerTickerWrapper class logic to stop using its internal Timeout object for scheduling LP ticker interrupts after the wrapper has been suspended. Fixes ARMmbed#8278
- Hide protected member structures from doxygen. - Add some more details/comments to the example. - Add some defined/undefined behaviours. - Add some additional details to function documentation
Make minor copy edits, mostly to existing text before this PR.
Copy edit file, including existing text.
The issue is that the process_oob check would only return immediately if no data at all on entry, or when receiving a known OOB. Any other line noise or unknown OOBs could lead to a timeout delay - read the noise or unknown OOB then timeout waiting for another line of input. This revised version modifies the parser to recheck readable after each line end when only looking for OOBs, so it can immediate exit.
Drivers: fix typos in doxygen
…socket_h Fix the incorrect comment for set_blocking()
Correct types passed to debug() calls - as part of this, block size and erase size are changed to be 32-bit - using 64-bit variables for these will cause unnecessary code bloat. Many uses of bd_size_t in the BlockDevice API should really be uint32_t or size_t, but that would be a bigger API change.
system_reset is MBED_NORETURN
Platform: fix missing namespace for SharedPtr
Build and run latest released doxygen in Travis CI
…_handling ATCmdParser: Fix OOB handling performance-wise
Phy drivers: Added S2-LP driver
DISCO_F769NI: Add bootloader support
Fix Ice Tea test execution order to be sorted by names.
Update python module versions in requirements.txt
…-python-3 Fix Makefile export with Python 3
Rework make.py CLI to avoid treating apps as tests
Add format checking to printf-type APIs
|
Oops, wrong place. |
Softagram Impact Report for pull/26 (head commit: e29b9ba)Target: K64F⭐ Visual OverviewChanged elements and changed dependencies. ⭐ Change ImpactHow the changed files are used by the rest of the project 📄 Full report
Give feedback of this report to support@softagram.com |
No worries, we are happy to give you impact reports of any pull request you open here ;) In this case we didn't keep the master branch up-to-date so the report is not valid for your single commit. |
|
FYI @SenRamakri, here's your pull request visualized correctly: #27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes for code analysis warnings raised from PVS studio - See ARMmbed#8517
Pull request type