Set up machinery for testing HTTP interactions of HTTP registry #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 23, 2023
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
This implementation focuses solely on local registries, and it has almost no security. --- **Stack**: - #819 - #818 - #809 - #808 - #807 - #806 - #805 - #803 - #802 - #799 - #798 - #793 - #790 ⬅⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do not merge manually using the UI - doing so may have unexpected results.*
mkaput
force-pushed
the
spr/main/ca3e5f93
branch
from
e854b6f to
f5d20ce
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
There are some rough untested edges, but in general this command is capable of building a local registry from scratch 🎉 --- **Stack**: - #819 - #818 - #809 - #808 - #807 - #806 - #805 - #803 - #802 - #799 - #798 - #793 ⬅⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do not merge manually using the UI - doing so may have unexpected results.*
mkaput
force-pushed
the
spr/main/97fc578f
branch
from
95e0a46 to
d293563
Compare
mkaput
force-pushed
the
spr/main/ca3e5f93
branch
from
f5d20ce to
3b300c3
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
These tests depend on both #790 and #793, hence they come in separate PR. --- **Stack**: - #819 - #818 - #809 - #808 - #807 - #806 - #805 - #803 - #802 - #799 - #798 ⬅⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do not merge manually using the UI - doing so may have unexpected results.*
mkaput
force-pushed
the
spr/main/97fc578f
branch
from
d293563 to
8268aa2
Compare
mkaput
force-pushed
the
spr/main/ca3e5f93
branch
from
3b300c3 to
1529ca2
Compare
mkaput
force-pushed
the
spr/main/ca3e5f93
branch
from
1529ca2 to
cfe44d5
Compare
mkaput
force-pushed
the
spr/main/97fc578f
branch
from
8268aa2 to
b7b62c1
Compare
mkaput
force-pushed
the
spr/main/97fc578f
branch
from
b7b62c1 to
b039be7
Compare
mkaput
force-pushed
the
spr/main/ca3e5f93
branch
from
cfe44d5 to
5aa2ddc
Compare
mkaput
force-pushed
the
spr/main/97fc578f
branch
from
b039be7 to
74e0606
Compare
mkaput
force-pushed
the
spr/main/ca3e5f93
branch
from
5aa2ddc to
1ee6e2f
Compare
This was referenced Oct 30, 2023
mkaput
force-pushed
the
spr/main/ca3e5f93
branch
from
0f9d6b5 to
bd285e4
Compare
mkaput
force-pushed
the
spr/main/97fc578f
branch
from
12c9170 to
5b767e2
Compare
mkaput
force-pushed
the
spr/main/ca3e5f93
branch
from
bd285e4 to
2cb880a
Compare
mkaput
force-pushed
the
spr/main/97fc578f
branch
from
5b767e2 to
89b884a
Compare
mkaput
force-pushed
the
spr/main/ca3e5f93
branch
from
2cb880a to
b62b9f8
Compare
mkaput
force-pushed
the
spr/main/97fc578f
branch
from
89b884a to
d2e41f1
Compare
mkaput
force-pushed
the
spr/main/ca3e5f93
branch
from
b62b9f8 to
423eb95
Compare
mkaput
force-pushed
the
spr/main/ca3e5f93
branch
from
423eb95 to
e7b3c11
Compare
mkaput
force-pushed
the
spr/main/97fc578f
branch
from
d2e41f1 to
a9a4b50
Compare
Merged
mkaput
force-pushed
the
spr/main/ca3e5f93
branch
from
e7b3c11 to
c2e84ea
Compare
maciektr
approved these changes
Nov 10, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 13, 2023
This PR lays groundwork for implementing caching of `RegistryClient` instances. It just sets up all the types and refactors, no caching is done yet. There is also a small functional change: local registry client does not print `Unpacking` status in normal mode. This wasn't a big deal, and it allowed removing the `is_offline` method from `RegistryClient`. --- **Stack**: - #892 - #846 - #845 - #844 - #819 - #818 - #809 - #808 ⬅⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do not merge manually using the UI - doing so may have unexpected results.* Signed-off-by: Marek Kaput <marek.kaput@swmansion.com>
mkaput
force-pushed
the
spr/main/ca3e5f93
branch
from
c2e84ea to
4d96c55
Compare
mkaput
force-pushed
the
spr/main/97fc578f
branch
from
3df7e3a to
266de6b
Compare
szymmis
approved these changes
Nov 13, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 13, 2023
NOTE: Nothing is cached actually yet, because no registry client uses hooks provided by this code. This will come in subsequent PRs. --- **Stack**: - #892 - #846 - #845 - #844 - #819 - #818 - #809 ⬅⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do not merge manually using the UI - doing so may have unexpected results.*
Signed-off-by: Marek Kaput <marek.kaput@swmansion.com> commit-id:ca3e5f93
mkaput
force-pushed
the
spr/main/ca3e5f93
branch
from
4d96c55 to
d67d59f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marek Kaput marek.kaput@swmansion.com
Stack:
CloneforFilesystem#845AsyncFileLockGuard#844