Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement records caching on HttpRegistryClient level #819

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Implement records caching on HttpRegistryClient level #819

merged 1 commit into from
Nov 16, 2023

Conversation

mkaput
Copy link
Member

@mkaput mkaput commented Oct 23, 2023 •
edited
Loading

This was referenced Oct 23, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 25, 2023
@mkaput
Initial implementation of RegistrySource (#790)
b78262e 
This implementation focuses solely on local registries, and it has
almost no security.

---

**Stack**:
- #819
- #818
- #809
- #808
- #807
- #806
- #805
- #803
- #802
- #799
- #798
- #793
- #790 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@mkaput mkaput force-pushed the spr/main/ca3e5f93 branch from e854b6f to f5d20ce Compare October 25, 2023 12:21
@mkaput mkaput force-pushed the spr/main/bc758880 branch from f2f469e to c8220ea Compare October 25, 2023 12:21
github-merge-queue bot pushed a commit that referenced this pull request Oct 25, 2023
@mkaput
Initial implementation of scarb publish (#793)
6189e64 
There are some rough untested edges, but in general this command is
capable of building a local registry from scratch 🎉

---

**Stack**:
- #819
- #818
- #809
- #808
- #807
- #806
- #805
- #803
- #802
- #799
- #798
- #793 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@mkaput mkaput force-pushed the spr/main/bc758880 branch from c8220ea to 1df1beb Compare October 27, 2023 12:44
@mkaput mkaput force-pushed the spr/main/ca3e5f93 branch from f5d20ce to 3b300c3 Compare October 27, 2023 12:44
github-merge-queue bot pushed a commit that referenced this pull request Oct 27, 2023
@mkaput
Add basic tests for local registry (#798)
0b65002 
These tests depend on both #790 and #793, hence they come in separate
PR.

---

**Stack**:
- #819
- #818
- #809
- #808
- #807
- #806
- #805
- #803
- #802
- #799
- #798 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@mkaput mkaput force-pushed the spr/main/bc758880 branch from 1df1beb to f2bd5d4 Compare October 27, 2023 13:24
github-merge-queue bot pushed a commit that referenced this pull request Oct 27, 2023
@mkaput
Implement simple http server for testing HTTP registries (#799)
40325cf 
**Stack**:
- #819
- #818
- #809
- #808
- #807
- #806
- #805
- #803
- #802
- #799 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@mkaput mkaput force-pushed the spr/main/ca3e5f93 branch from 1529ca2 to cfe44d5 Compare October 27, 2023 14:16
@mkaput mkaput force-pushed the spr/main/bc758880 branch from f2bd5d4 to 3c828a9 Compare October 27, 2023 14:16
github-merge-queue bot pushed a commit that referenced this pull request Oct 27, 2023
@mkaput
Set up reqwest HTTP client (#802)
2713975 
**Stack**:
- #819
- #818
- #809
- #808
- #807
- #806
- #805
- #803
- #802 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@mkaput mkaput force-pushed the spr/main/bc758880 branch from 3c828a9 to 8d40f5e Compare October 27, 2023 14:51
github-merge-queue bot pushed a commit that referenced this pull request Oct 27, 2023
@mkaput
Initial implementation of HTTP registry client (#803)
a4ed802 
**Stack**:
- #819
- #818
- #809
- #808
- #807
- #806
- #805
- #803 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@mkaput mkaput force-pushed the spr/main/bc758880 branch from 8d40f5e to ca23a28 Compare October 27, 2023 15:52
github-merge-queue bot pushed a commit that referenced this pull request Oct 27, 2023
@mkaput
Expand registry specification to registry URL when packaging (#805)
1cede5d 
**Stack**:
- #819
- #818
- #809
- #808
- #807
- #806
- #805 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@mkaput mkaput force-pushed the spr/main/bc758880 branch from ca23a28 to 8348f7b Compare October 30, 2023 16:14
@mkaput mkaput force-pushed the spr/main/ca3e5f93 branch from 1ee6e2f to 0f9d6b5 Compare October 30, 2023 16:14
@mkaput mkaput force-pushed the spr/main/ca3e5f93 branch from 2cb880a to b62b9f8 Compare November 7, 2023 14:27
@mkaput mkaput force-pushed the spr/main/bc758880 branch from 44c40e4 to 2b76407 Compare November 7, 2023 14:27
@mkaput mkaput force-pushed the spr/main/ca3e5f93 branch from b62b9f8 to 423eb95 Compare November 8, 2023 08:57
@mkaput mkaput force-pushed the spr/main/bc758880 branch from 2b76407 to 094c31c Compare November 8, 2023 08:57
@mkaput mkaput requested review from maciektr and szymmis November 8, 2023 08:59
@mkaput mkaput force-pushed the spr/main/ca3e5f93 branch from 423eb95 to e7b3c11 Compare November 8, 2023 10:39
@mkaput mkaput force-pushed the spr/main/bc758880 branch from 094c31c to 78efb00 Compare November 8, 2023 10:39
@mkaput mkaput mentioned this pull request Nov 9, 2023
Merged
@mkaput mkaput force-pushed the spr/main/bc758880 branch from 78efb00 to ec27844 Compare November 9, 2023 15:25
github-merge-queue bot pushed a commit that referenced this pull request Nov 13, 2023
@mkaput
Introduce RegistryClientCache stub (#808)
7149881 
This PR lays groundwork for implementing caching of `RegistryClient`
instances.
It just sets up all the types and refactors, no caching is done yet.

There is also a small functional change: local registry client does not
print
`Unpacking` status in normal mode. This wasn't a big deal, and it
allowed removing
the `is_offline` method from `RegistryClient`.

---

**Stack**:
- #892
- #846
- #845
- #844
- #819
- #818
- #809
- #808 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

Signed-off-by: Marek Kaput <marek.kaput@swmansion.com>
github-merge-queue bot pushed a commit that referenced this pull request Nov 13, 2023
@mkaput
Implement caching of records returned from registry clients (#809)
a747a60 
NOTE: Nothing is cached actually yet, because no registry client uses
hooks provided by this code. This will come in subsequent PRs.

---

**Stack**:
- #892
- #846
- #845
- #844
- #819
- #818
- #809 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
Base automatically changed from spr/main/ca3e5f93 to main November 13, 2023 14:01
github-merge-queue bot pushed a commit that referenced this pull request Nov 13, 2023
@mkaput
Set up machinery for testing HTTP interactions of HTTP registry (#818)
ecebc03 
Signed-off-by: Marek Kaput <marek.kaput@swmansion.com>

---

**Stack**:
- #892
- #846
- #845
- #844
- #819
- #818 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@mkaput mkaput mentioned this pull request Nov 14, 2023
Merged
@mkaput
Implement records caching on HttpRegistryClient level
5f69d77 
Signed-off-by: Marek Kaput <marek.kaput@swmansion.com>

commit-id:bc758880
@mkaput mkaput mentioned this pull request Nov 15, 2023
Merged
@mkaput mkaput added this pull request to the merge queue Nov 16, 2023
Merged via the queue into main with commit aa772d1 Nov 16, 2023
11 checks passed
@mkaput mkaput deleted the spr/main/bc758880 branch November 16, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szymmis szymmis szymmis approved these changes

@maciektr maciektr maciektr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkaput @maciektr @szymmis