Impl Clone for Filesystem
#845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 30, 2023
Merged
Merged
mkaput
force-pushed
the
spr/main/ebda97d6
branch
from
c95c9bb to
c825636
Compare
mkaput
force-pushed
the
spr/main/f7f37d16
branch
from
3683911 to
480b179
Compare
mkaput
force-pushed
the
spr/main/ebda97d6
branch
from
c825636 to
b3e6ce2
Compare
mkaput
force-pushed
the
spr/main/f7f37d16
branch
2 times, most recently
from
5557402 to
44c62bf
Compare
mkaput
force-pushed
the
spr/main/ebda97d6
branch
from
b3e6ce2 to
06cecd1
Compare
mkaput
force-pushed
the
spr/main/f7f37d16
branch
from
44c62bf to
9b78cb8
Compare
Merged
mkaput
force-pushed
the
spr/main/f7f37d16
branch
from
9b78cb8 to
f445030
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 13, 2023
This PR lays groundwork for implementing caching of `RegistryClient` instances. It just sets up all the types and refactors, no caching is done yet. There is also a small functional change: local registry client does not print `Unpacking` status in normal mode. This wasn't a big deal, and it allowed removing the `is_offline` method from `RegistryClient`. --- **Stack**: - #892 - #846 - #845 - #844 - #819 - #818 - #809 - #808 ⬅⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do not merge manually using the UI - doing so may have unexpected results.* Signed-off-by: Marek Kaput <marek.kaput@swmansion.com>
mkaput
force-pushed
the
spr/main/ebda97d6
branch
from
e16fa52 to
deffacc
Compare
mkaput
force-pushed
the
spr/main/f7f37d16
branch
from
f445030 to
ce4687b
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 13, 2023
NOTE: Nothing is cached actually yet, because no registry client uses hooks provided by this code. This will come in subsequent PRs. --- **Stack**: - #892 - #846 - #845 - #844 - #819 - #818 - #809 ⬅⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do not merge manually using the UI - doing so may have unexpected results.*
mkaput
force-pushed
the
spr/main/f7f37d16
branch
from
ce4687b to
85b44e7
Compare
mkaput
force-pushed
the
spr/main/ebda97d6
branch
from
deffacc to
75f0a8e
Compare
mkaput
force-pushed
the
spr/main/ebda97d6
branch
from
75f0a8e to
8445138
Compare
mkaput
force-pushed
the
spr/main/f7f37d16
branch
from
85b44e7 to
37c5323
Compare
maciektr
approved these changes
Nov 13, 2023
mkaput
force-pushed
the
spr/main/f7f37d16
branch
from
37c5323 to
f379ee6
Compare
mkaput
force-pushed
the
spr/main/ebda97d6
branch
from
1d6bc6a to
c1e0523
Compare
mkaput
force-pushed
the
spr/main/f7f37d16
branch
from
f379ee6 to
1416306
Compare
mkaput
force-pushed
the
spr/main/ebda97d6
branch
from
c1e0523 to
fa8650e
Compare
mkaput
force-pushed
the
spr/main/f7f37d16
branch
from
1416306 to
a5be8ec
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
This data structure will be later used in Tokio-based code which writes to the file protected by this guard. Signed-off-by: Marek Kaput <marek.kaput@swmansion.com> --- **Stack**: - #909 - #906 - #892 - #846 - #845 - #844 ⬅⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do not merge manually using the UI - doing so may have unexpected results.*
This surprisingly small addition required some bigger changes. Filesystems are now lifetime-unbound, and rely on internal `Arc`s instead of references. Technically this means higher heap pressure and slower code due to increased use of atomics, but `Filesystem`s are by nature not part of hot paths, so this is fine. Signed-off-by: Marek Kaput <marek.kaput@swmansion.com> commit-id:f7f37d16
mkaput
force-pushed
the
spr/main/f7f37d16
branch
from
a5be8ec to
3558547
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This surprisingly small addition required some bigger changes. Filesystems are now lifetime-unbound, and rely on internal
Arcs instead of references. Technically this means higher heap pressure and slower code due to increased use of atomics, butFilesystems are by nature not part of hot paths, so this is fine.Signed-off-by: Marek Kaput marek.kaput@swmansion.com
Stack:
checksumfield toPackageLockand add Builder pattern there #909CloneforFilesystem#845 ⬅