Added ssh configurations to YANG model #13338
Conversation
ycoheNvidia
force-pushed
the
sonic-buildimage-ssh_config
branch
from
e6ff14c
to
3c3738a
Compare
|
/azpw run |
|
/AzurePipelines run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
| leaf ports { | ||
| description "ssh port numbers"; | ||
| type string { | ||
| pattern '[0-9]+(,[0-9]+)*' { |
There was a problem hiding this comment.
Is there any limit to the number of ports that can be defined?
There was a problem hiding this comment.
there is no limit that I am aware of (at least not in openSSH)
updated ports pattern to allow only port numbers in range 1 to 65536
@ycoheNvidia Please update the configuration schema |
|
@ycoheNvidia please review recent comments and update following conflicts. once done please ping the reviewers for next step |
|
|
@ycoheNvidia Can you please check the configuration.md diff? It is showing the entire file as diff. We need to have only the sections related to the feature as diff |
I took the latest file from master and added the relevant lines. It looks like a problem in Github. If you compare the texts manually you will be able to see changes are minimal |
ycoheNvidia
force-pushed
the
sonic-buildimage-ssh_config
branch
from
fbeae0b
to
51c1370
Compare
|
@ganglyu @qiluo-msft all comments addressed |
Please double check src/sonic-yang-models/yang-models/sonic-ssh-server.yang, I can still find tab in this file. |
fixed |
|
/azpw run |
|
/AzurePipelines run |
|
No commit pushedDate could be found for PR 13338 in repo sonic-net/sonic-buildimage |
|
@ganglyu @qiluo-msft need your approval - had to rebase in order to resolve CI issue (no merge issues) |
- Why I did it Implemented ssh configurations - How I did it Added ssh config table in configDB, once changed - hostcfgd will change the relevant OS files (sshd_config) - How to verify it Tests in sonic-host-services. Change relevant configs in configDB such as ports, and see sshd port was modified
…sonic-buildimage into internal Fix conflict for rsyslog. Skip partial DNS unit test in internal branch after confirmed with Gang. Related work items: sonic-net#113, sonic-net#131, sonic-net#132, sonic-net#134, sonic-net#321, sonic-net#331, sonic-net#381, sonic-net#382, sonic-net#2525, sonic-net#2676, sonic-net#2698, sonic-net#2737, sonic-net#2789, sonic-net#2839, sonic-net#2845, sonic-net#2850, sonic-net#2882, sonic-net#2885, sonic-net#2887, sonic-net#2890, sonic-net#2895, sonic-net#13338, sonic-net#14105, sonic-net#15142, sonic-net#15223, sonic-net#15456, sonic-net#15487, sonic-net#15520, sonic-net#15726, sonic-net#15727, sonic-net#15758, sonic-net#15764, sonic-net#15765, sonic-net#15772, sonic-net#15779, sonic-net#15782, sonic-net#15785, sonic-net#15797, sonic-net#15798, sonic-net#15810, sonic-net#15811, sonic-net#15821
Why I did it
Implemented ssh configurations
Work item tracking
How I did it
Added ssh config table in configDB, once changed - hostcfgd will change the relevant OS files (sshd_config)
How to verify it
Tests in sonic-host-services. Change relevant configs in configDB such as ports, and see sshd port was modified
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Added ssh config infrastructure
Link to config_db schema for YANG module changes
https://github.com/sonic-net/SONiC/blob/master/doc/ssh_config/ssh_config.md
A picture of a cute animal (not mandatory but encouraged)
A picture of a cute animal
