Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python3 packages to sonic-mgmt-docker #15726

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

wsycqyz
Copy link
Contributor

@wsycqyz wsycqyz commented Jul 6, 2023

Why I did it

This is part of sonic-mgmt-docker Python3 migration project.
Currently Python3 packages are in the Python3 virtual environment. This PR will add Python3 packages to real file system.
After we migrate all script to use Python3 in real file system, the Python3 venv will be deleted.

After this PR, in sonic-mgmt-docker,
Directly run cmd - pytest will use Python2's version.
python3 -m pytest will use Python3's version.

Work item tracking
  • Microsoft ADO: 24397921

How I did it

Modify sonic-mgmt-docker j2 script.

How to verify it

Build a private sonic-mgmt-docker and run basic test case with Python3.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@wangxin wangxin merged commit c589230 into sonic-net:master Jul 11, 2023
@wsycqyz wsycqyz deleted the shiyanwang/sonic-mgmt-docker-py3 branch July 13, 2023 01:13
sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
Why I did it
This is part of sonic-mgmt-docker Python3 migration project.
Currently Python3 packages are in the Python3 virtual environment. This PR will add Python3 packages to real file system.
After we migrate all script to use Python3 in real file system, the Python3 venv will be deleted.

After this PR, in sonic-mgmt-docker,
Directly run cmd - pytest will use Python2's version.
python3 -m pytest will use Python3's version.

How I did it
Modify sonic-mgmt-docker j2 script.

How to verify it
Build a private sonic-mgmt-docker and run basic test case with Python3.
@aaronpayment
Copy link
Contributor

Can this be backported to 202305 branch?

@wsycqyz
Copy link
Contributor Author

wsycqyz commented Nov 29, 2023

@aaronpayment There is only one version of sonic-mgmt-docker. All branch will use the same sonic-mgmt-docker. This PR has no relationship to sonic-mgmt branch. Please pay attention to the difference between sonic-mgmt-docker and sonic-mgmt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants