[interfaces]: Combine vlan_interfaces and lag_interfaces file and add allow-hotplug #381

stcheng · 2017-03-07T02:33:01Z

start interface <interface_name> when the kernel detects
a hotplug event from the interface

ref: https://www.debian.org/doc/manuals/debian-reference/ch05.en.html

Signed-off-by: Shuotian Cheng shuche@microsoft.com

stcheng · 2017-03-07T02:33:13Z

To address the issue: sonic-net/sonic-swss#165

lguohan · 2017-03-07T07:05:07Z

what about vlan interface>

stcheng · 2017-03-07T10:18:44Z

vlan interfaces are different here.

for regular front panel ports, the host interfaces are created by calling the sai function calls.

for teamd instances, the host interfaces are created by the teamd daemon.

but for vlan interfaces, manual commands are needed to create them AFTER all the regular front panel ports' host interfaces are created.

we have two ways of creating vlan interfaces:

use the command ifup --all --force --interfaces /etc/network/interfaces.d/vlan_interfaces to bring up all the vlan interfaces in a one-shot command. it will automatically create the bridge and add interfaces into the bridge and bring up the interface. in order to use ifup, the only requirement is the auto key word in the interfaces file.
use the command brctl addbr and brctl addif commands. then we will also need to wait until all the regular host interfaces are created. this could be down by putting the commands into the start.sh file and checking the db if all the host interfaces are created. otherwise, if we add some interfaces which are not created, we will get an error indicating that the interfaces are not existing. for this case, allow-hotplug will be needed because we create the interfaces via the brctl and they are by default not admin up.

that's why allow-hotplug is not needed for vlan interfaces in this case as we are using ifup. (it doesn't hurt to add this stanza to vlan interfaces, it just doesn't take effect.

[DEPRECATED]

lguohan · 2017-03-15T04:04:39Z

let's try to add the interface to the bridge when we try to bring up the interface that belongs to vlan.

stcheng · 2017-03-15T08:17:37Z

this pull request is updated:

[interfaces]: Combine vlan_interfaces and lag_interfaces file and add allow-hotplug

1. Remove vlan_interfaces and lag_interfaces file
2. Add all interfaces to /etc/network/interfaces file
3. Add allow-hotplug stanza
4. Add up <command> to automatically add interfaces to VLAN and LAG
5. Add unique_name filter to minigraph.py to remove duplicate interface names

Signed-off-by: Shuotian Cheng <shuche@microsoft.com>

lguohan · 2017-03-15T08:22:35Z

files/image_config/interfaces/interfaces.j2

+auto {{ interface }}
+allow-hotplug {{ interface }}
+iface {{ interface }} inet manual
+    pre-up /sbin/ifconfig {{ interface }} up


why do we need this here but not for team member port?

because teamdctl can only add the member when the member is down. if the interface is up, it cannot be added to the teamd instance.

then for team member, it should be pre-up?

and for vlan, it can be

post-up brctl addif {{ vlan_interface['name'] }} {{ interface }}

svc-acs · 2017-03-15T08:27:16Z

files/image_config/interfaces/interfaces.j2

 iface {{ interface['alias'] }} {{ 'inet' if interface['addr'] | ipv4 else 'inet6' }} static
    address {{ interface['addr'] }}
    netmask {{ interface['mask'] }}
 #
 {% endfor %}
-{% endblock front_panel_interface %}
+{% for vlan_interface in minigraph_vlan_interfaces|unique_name %}


why are we having duplicated vlan_interface names? we should prevent that from happening in the first place.

same as below. also currently we don't have ipv6 vlan interfaces.

svc-acs · 2017-03-15T08:27:47Z

files/image_config/interfaces/interfaces.j2

+#
+{% endfor %}
+{% endfor %}
+{% for pc_interface in minigraph_portchannel_interfaces|unique_name %}


why are we having duplicated vlan_interface names? we should prevent that from happening in the first place.

it is to remove the duplicated interfaces entries when the same interface is having both ipv4 and ipv6 addresses. otherwise we will end up having two same member entries.

lguohan

as comments

stcheng · 2017-03-15T08:35:58Z

comments answered.

stcheng · 2017-03-15T08:55:17Z

updated.
also add brctl to base image.

lguohan · 2017-03-15T09:22:27Z

files/image_config/interfaces/interfaces.j2

+auto {{ interface }}
+allow-hotplug {{ interface }}
+iface {{ interface }} inet manual
+    pre-up teamdctl {{ pc_interface['name'] }} port add {{ interface }}


what if the teamd interface does not exist?

what if teamd starts after swss, in that case you have ports up but no teamd ports, then teamdctl add will fail.

i think under the teamd interface section, we could add same commands so that once the teamd interface goes up, it will also try to add all its members. there is no harm adding one member twice.

teamd always tries to add members on start (in case of our configuration).

From what I see:

If swss starts first, then interfaces are added to LAGs by teamd itself on startup;

if teamd starts first, then pre-up command do its job;

@stcheng Do I understand it correctly?

@marian-pritsak I see what you mean. currently I just remove the members from the teamd.j2 configurations. I think i still need to add them back.

yes, I think we should add it back.

In reply to: 106252590 [](ancestors = 106252590)

lguohan · 2017-03-15T17:57:25Z

build failure, can you check?

jleveque

Just curious about the submodule updates. They all claim 0 files have changed but they all seem to be moving back to commits that are about a month old.

ETA: This might be the source of your build failures.

- start interface <interface_name> when the kernel detects a hotplug event from the interface ref: https://www.debian.org/doc/manuals/debian-reference/ch05.en.html Signed-off-by: Shuotian Cheng <shuche@microsoft.com>

stcheng · 2017-03-15T19:00:02Z

@jleveque thanks! yes. i updated the commit so that the submodules are untouched.

stcheng · 2017-03-15T20:01:55Z

@lguohan added sonic-swss submodule update

lguohan · 2017-03-16T03:17:39Z

src/sonic-config-engine/minigraph.py

+		        if intfname in pc_map:
+		            pc_map[intfname].append(intf)
+		        else:
+		            pc_map[intfname] = [intf]


convert into spaces

lguohan · 2017-03-16T03:17:52Z

src/sonic-config-engine/sonic-cfggen

+    new_list = []
+    for item in l:
+        if item['name'] not in name_list:
+	    name_list.append(item['name'])


convert into spaces

lguohan · 2017-03-16T03:19:33Z

files/image_config/interfaces/interfaces.j2

+auto {{ interface }}
+allow-hotplug {{ interface }}
+iface {{ interface }} inet manual
+    pre-up teamdctl {{ pc_interface['name'] }} port add {{ interface }}


pre-up teamdctl {{ pc_interface['name'] }} port add {{ interface }} [](start = 4, length = 67)

since this could fail, we should add "|| true" in the end.

… allow-hotplug 1. Remove vlan_interfaces and lag_interfaces file and members in teamd.j2 2. Add all interfaces to /etc/network/interfaces file 3. Add allow-hotplug stanza 4. Add up <command> to automatically add interfaces to VLAN and LAG 5. Add unique_name filter to minigraph.py to remove duplicate interface names 6. Add brctl to base image 7. Update sonic-swss submodule Signed-off-by: Shuotian Cheng <shuche@microsoft.com>

stcheng · 2017-03-16T05:13:42Z

Updated 🆙

sonic-sairedis * 398d24a 2018-11-16 | Add comments aspell check (sonic-net#382) (master) [Kamil Cudnik] * 08fccb0 2018-11-15 | Add buffer pool logic and unittests (sonic-net#381) [Kamil Cudnik] * 4d5a7bb 2018-11-15 | Rebuild VS local metadata on warm boot (sonic-net#380) [Kamil Cudnik] * b011f3d 2018-11-15 | Add cold discovered oids (sonic-net#379) [Kamil Cudnik] * 11c386e 2018-11-14 | [syncd] always log ASIC operations performed after warm restart (sonic-net#378) [Ying Xie] * ebb9b7a 2018-11-14 | [syncd] provide docker name when checking warm restart (sonic-net#377) [Ying Xie] * 72d8cc3 2018-11-12 | Add warm boot support for virtual switch (sonic-net#374) [Kamil Cudnik] * 333c5ff 2018-11-11 | Refactor sairedis (sonic-net#375) [Kamil Cudnik] sonic-utilities * c6b4fe7 2018-11-15 | Adding bgp's warmrestart timer and on-off knob (sonic-net#378) (HEAD, origin/master, origin/HEAD, master) [Rodny Molina] * 45d85c9 2018-11-15 | [warm boot] move warm reboot/fast reboot knowledge to syncd service script (sonic-net#372) [Ying Xie] sonic-swss * 067928d 2018-11-17 | [aclorch]: Use the Observer class to listen to port changes (sonic-net#689) (HEAD, origin/master, origin/HEAD) [Shuotian Cheng] * d7d887a 2018-11-15 | [test]: Remove deprecated TODO comment (sonic-net#688) (master) [Shuotian Cheng] * b42710a 2018-11-15 | [teammgrd]: Check if port is enslaved on all conditions (sonic-net#687) [Shuotian Cheng] * 75972e7 2018-11-13 | Restore port oper status form appDB port table during restore phase o… (sonic-net#683) [Jipan Yang] * 48c3bfb 2018-11-13 | [WarmStart]: Use right docker name for the teammgrd checkWarmStart (sonic-net#685) [pavel-shirshov] * 6292786 2018-11-13 | [teammgrd]: Add kernel master check for port before enslaving (sonic-net#681) [Shuotian Cheng] * a42ef4c 2018-11-12 | Adjust schema to match bgp warm-restart timer interval (sonic-net#682) [Rodny Molina] * dc2ff77 2018-11-12 | [portsorch]: Move status comparison outside updatePortOperStatus function (sonic-net#679) [Shuotian Cheng] Signed-off-by: Guohan Lu <gulv@microsoft.com>

sonic-sairedis * 398d24a 2018-11-16 | Add comments aspell check (#382) (master) [Kamil Cudnik] * 08fccb0 2018-11-15 | Add buffer pool logic and unittests (#381) [Kamil Cudnik] * 4d5a7bb 2018-11-15 | Rebuild VS local metadata on warm boot (#380) [Kamil Cudnik] * b011f3d 2018-11-15 | Add cold discovered oids (#379) [Kamil Cudnik] * 11c386e 2018-11-14 | [syncd] always log ASIC operations performed after warm restart (#378) [Ying Xie] * ebb9b7a 2018-11-14 | [syncd] provide docker name when checking warm restart (#377) [Ying Xie] * 72d8cc3 2018-11-12 | Add warm boot support for virtual switch (#374) [Kamil Cudnik] * 333c5ff 2018-11-11 | Refactor sairedis (#375) [Kamil Cudnik] sonic-utilities * c6b4fe7 2018-11-15 | Adding bgp's warmrestart timer and on-off knob (#378) (HEAD, origin/master, origin/HEAD, master) [Rodny Molina] * 45d85c9 2018-11-15 | [warm boot] move warm reboot/fast reboot knowledge to syncd service script (#372) [Ying Xie] sonic-swss * 067928d 2018-11-17 | [aclorch]: Use the Observer class to listen to port changes (#689) (HEAD, origin/master, origin/HEAD) [Shuotian Cheng] * d7d887a 2018-11-15 | [test]: Remove deprecated TODO comment (#688) (master) [Shuotian Cheng] * b42710a 2018-11-15 | [teammgrd]: Check if port is enslaved on all conditions (#687) [Shuotian Cheng] * 75972e7 2018-11-13 | Restore port oper status form appDB port table during restore phase o… (#683) [Jipan Yang] * 48c3bfb 2018-11-13 | [WarmStart]: Use right docker name for the teammgrd checkWarmStart (#685) [pavel-shirshov] * 6292786 2018-11-13 | [teammgrd]: Add kernel master check for port before enslaving (#681) [Shuotian Cheng] * a42ef4c 2018-11-12 | Adjust schema to match bgp warm-restart timer interval (#682) [Rodny Molina] * dc2ff77 2018-11-12 | [portsorch]: Move status comparison outside updatePortOperStatus function (#679) [Shuotian Cheng] Signed-off-by: Guohan Lu <gulv@microsoft.com>

* Add cold discovered oids * Add cold discovered oids * Add buffer pool logic and unittests * Bring back logging

Update sonic-platform-common submodule pointer to include the following: * 4d270f0 [actions] Support Semgrep by Github Actions ([sonic-net#383](sonic-net/sonic-platform-common#383)) * 74ddd4e Fix issue: should use 'Value' column to calculate the health percentage ([sonic-net#381](sonic-net/sonic-platform-common#381)) Signed-off-by: dprital <drorp@nvidia.com>

… automatically (#15577) #### Why I did it src/sonic-platform-common ``` * 459ffaa - (HEAD -> 202211, origin/202211) Fix issue: should use 'Value' column to calculate the health percentage (#381) (3 hours ago) [Junchao-Mellanox] ``` #### How I did it #### How to verify it #### Description for the changelog

…D automatically (#15810) #### Why I did it src/sonic-platform-daemons ``` * d73808c - (HEAD -> master, origin/master, origin/HEAD) Added PCIe transaction check for all peripherals on the bus (#331) (9 hours ago) [Ashwin Srinivasan] * 432602a - Update active application selected code in transceiver_info table aft… (#381) (13 hours ago) [Michael Wang - TW] ``` #### How I did it #### How to verify it #### Description for the changelog

…D automatically (#16062) #### Why I did it src/sonic-platform-daemons ``` * 6c47906 - (HEAD -> 202305, origin/202305) Update active application selected code in transceiver_info table aft… (#381) (13 hours ago) [Michael Wang - TW] ``` #### How I did it #### How to verify it #### Description for the changelog

…D automatically (#16108) src/sonic-platform-daemons * f5a0ffc - (HEAD -> 202205, origin/202205) Update active application selected code in transceiver_info table aft… (#381) (4 hours ago) [Michael Wang - TW]

…D automatically (sonic-net#15810) #### Why I did it src/sonic-platform-daemons ``` * d73808c - (HEAD -> master, origin/master, origin/HEAD) Added PCIe transaction check for all peripherals on the bus (sonic-net#331) (9 hours ago) [Ashwin Srinivasan] * 432602a - Update active application selected code in transceiver_info table aft… (sonic-net#381) (13 hours ago) [Michael Wang - TW] ``` #### How I did it #### How to verify it #### Description for the changelog

…sonic-buildimage into internal Fix conflict for rsyslog. Skip partial DNS unit test in internal branch after confirmed with Gang. Related work items: sonic-net#113, sonic-net#131, sonic-net#132, sonic-net#134, sonic-net#321, sonic-net#331, sonic-net#381, sonic-net#382, sonic-net#2525, sonic-net#2676, sonic-net#2698, sonic-net#2737, sonic-net#2789, sonic-net#2839, sonic-net#2845, sonic-net#2850, sonic-net#2882, sonic-net#2885, sonic-net#2887, sonic-net#2890, sonic-net#2895, sonic-net#13338, sonic-net#14105, sonic-net#15142, sonic-net#15223, sonic-net#15456, sonic-net#15487, sonic-net#15520, sonic-net#15726, sonic-net#15727, sonic-net#15758, sonic-net#15764, sonic-net#15765, sonic-net#15772, sonic-net#15779, sonic-net#15782, sonic-net#15785, sonic-net#15797, sonic-net#15798, sonic-net#15810, sonic-net#15811, sonic-net#15821

…tomatically (#18290) #### Why I did it src/sonic-linux-kernel ``` * 45295bf - (HEAD -> master, origin/master, origin/HEAD) Fix the issue with signed kernel compilation for ARM64 architecture (#381) (54 minutes ago) [Oleksandr Ivantsiv] ``` #### How I did it #### How to verify it #### Description for the changelog

…tomatically (sonic-net#18290) #### Why I did it src/sonic-linux-kernel ``` * 45295bf - (HEAD -> master, origin/master, origin/HEAD) Fix the issue with signed kernel compilation for ARM64 architecture (sonic-net#381) (54 minutes ago) [Oleksandr Ivantsiv] ``` #### How I did it #### How to verify it #### Description for the changelog

stcheng changed the title ~~[files]: Add allow-hotplug stanza to interfaces files~~ [interfaces]: Combine vlan_interfaces and lag_interfaces file and add allow-hotplug Mar 15, 2017

lguohan reviewed Mar 15, 2017

View reviewed changes

svc-acs reviewed Mar 15, 2017

View reviewed changes

lguohan requested changes Mar 15, 2017

View reviewed changes

stcheng self-assigned this Mar 15, 2017

stcheng added the Enhancement ➕ label Mar 15, 2017

lguohan reviewed Mar 15, 2017

View reviewed changes

jleveque reviewed Mar 15, 2017

View reviewed changes

[files]: Add allow-hotplug stanza to interfaces files

54d0ab8

- start interface <interface_name> when the kernel detects a hotplug event from the interface ref: https://www.debian.org/doc/manuals/debian-reference/ch05.en.html Signed-off-by: Shuotian Cheng <shuche@microsoft.com>

stcheng mentioned this pull request Mar 15, 2017

[portsyncd]: Removing manual commands to bring up interfaces sonic-net/sonic-swss#174

Merged

lguohan reviewed Mar 16, 2017

View reviewed changes

lguohan approved these changes Mar 16, 2017

View reviewed changes

stcheng merged commit 05e6b36 into sonic-net:master Mar 16, 2017

stcheng deleted the stanza branch March 16, 2017 18:22

stcheng mentioned this pull request Mar 17, 2017

Remove unique_name filter in sonic-cfggen and update interfaces.j2 #409

Closed

taoyl-ms mentioned this pull request Mar 17, 2017

[minigraph]: Add portchannels/vlans dictionary and update teamd templates #408

Merged

stcheng mentioned this pull request Mar 24, 2017

port is not brought up after init sonic-net/sonic-swss#130

Closed

jleveque added the Submodule Update ⏫ label Apr 17, 2017

lguohan mentioned this pull request Nov 18, 2018

[submodule]: update swss, sairedis and utilities #2270

Merged

madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020

point build badge to new build server (sonic-net#381)

d9bb152

dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this pull request Aug 31, 2020

Add buffer pool logic and unittests (sonic-net#381)

08fccb0

* Add cold discovered oids * Add cold discovered oids * Add buffer pool logic and unittests * Bring back logging

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[interfaces]: Combine vlan_interfaces and lag_interfaces file and add allow-hotplug #381

[interfaces]: Combine vlan_interfaces and lag_interfaces file and add allow-hotplug #381

stcheng commented Mar 7, 2017

stcheng commented Mar 7, 2017

lguohan commented Mar 7, 2017

stcheng commented Mar 7, 2017 •

edited

Loading

lguohan commented Mar 15, 2017

stcheng commented Mar 15, 2017

lguohan Mar 15, 2017

stcheng Mar 15, 2017

lguohan Mar 15, 2017

lguohan Mar 15, 2017

svc-acs Mar 15, 2017

stcheng Mar 15, 2017

lguohan Mar 15, 2017

svc-acs Mar 15, 2017

stcheng Mar 15, 2017

lguohan left a comment

stcheng commented Mar 15, 2017

stcheng commented Mar 15, 2017

lguohan Mar 15, 2017

lguohan Mar 15, 2017

stcheng Mar 15, 2017

marian-pritsak Mar 15, 2017 •

edited

Loading

stcheng Mar 15, 2017

lguohan Mar 16, 2017

lguohan commented Mar 15, 2017

jleveque left a comment •

edited

Loading

stcheng commented Mar 15, 2017

stcheng commented Mar 15, 2017

lguohan Mar 16, 2017

lguohan Mar 16, 2017

lguohan Mar 16, 2017

stcheng commented Mar 16, 2017

[interfaces]: Combine vlan_interfaces and lag_interfaces file and add allow-hotplug #381

[interfaces]: Combine vlan_interfaces and lag_interfaces file and add allow-hotplug #381

Conversation

stcheng commented Mar 7, 2017

stcheng commented Mar 7, 2017

lguohan commented Mar 7, 2017

stcheng commented Mar 7, 2017 • edited Loading

lguohan commented Mar 15, 2017

stcheng commented Mar 15, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lguohan left a comment

Choose a reason for hiding this comment

stcheng commented Mar 15, 2017

stcheng commented Mar 15, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marian-pritsak Mar 15, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lguohan commented Mar 15, 2017

jleveque left a comment • edited Loading

Choose a reason for hiding this comment

stcheng commented Mar 15, 2017

stcheng commented Mar 15, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stcheng commented Mar 16, 2017

stcheng commented Mar 7, 2017 •

edited

Loading

marian-pritsak Mar 15, 2017 •

edited

Loading

jleveque left a comment •

edited

Loading