Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[device & platform] led and transceiver deamon for inventec switch d7032 and d7054 #1678

Merged
merged 3 commits into from
Aug 12, 2018
Merged

[device & platform] led and transceiver deamon for inventec switch d7032 and d7054 #1678

merged 3 commits into from
Aug 12, 2018
+2,412 −12

Conversation

klhaung
Copy link
Contributor

@klhaung klhaung commented May 7, 2018

- What I did

  • Add front panel led support for Inventec-d7032
  • Add transceiver monitor daemon for Inventec-d7054
  • Follow new porting guide to have modified broadcom config under device folder
  • BugFix in sfputil.py used for inventec-d7032

- How I did it

  • Add two pythons scripts which is spawned by debian init script for monitoring port status
  • Add led initialization file for Inventec-d7032
  • Have modified broadcom config under device folder for Inventec-d7032 and Inventec-d7054

- How to verify it

  • Build image, install on device platform to and make sure it is worked properly

- Description for the changelog

Add front panel led support and transceiver monitor for invnetec d7054 and d7032

- A picture of a cute animal (not mandatory but encouraged)

klhaung added 2 commits May 7, 2018 09:52
@klhaung
[device]: Modify SFPUtil for inventec-d7032
aee48b4 
[device]: Add front panel led support for Inventec-d7032
[platform]: Add transceiver monitor daemon for Inventec-d7032 and Inventec-d7054
@klhaung
[device] follow new porting guide to have broadcom config under devic…
4401949 
…e folder
@klhaung klhaung changed the title led and transceiver deamon for inventec switch d7032 and d7054 [device & platform] led and transceiver deamon for inventec switch d7032 and d7054 May 14, 2018
lguohan
lguohan reviewed Jun 23, 2018
View reviewed changes
platform/broadcom/sonic-platform-modules-inventec/common/utils/transceiver_monitor.py Outdated
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove license from the file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, done in commit commit 4ddf83d

lguohan
lguohan reviewed Jun 23, 2018
View reviewed changes
platform/broadcom/sonic-platform-modules-inventec/common/utils/led_proc.py Outdated
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove license from the file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. done in commit 4ddf83d

lguohan
lguohan requested changes Jun 23, 2018
View reviewed changes
Copy link
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove license from the code.

@klhaung
Copy link
Contributor Author

klhaung commented Jun 26, 2018

We have removed the license in commit 4ddf83d. Please help to merge the fix into SONiC. Thanks.

@lguohan
Copy link
Collaborator

lguohan commented Aug 12, 2018

retest this please

@lguohan lguohan merged commit 58db7f1 into sonic-net:master Aug 12, 2018
@klhaung
Copy link
Contributor Author

klhaung commented Aug 13, 2018

Thanks, lguohan.

lguohan pushed a commit that referenced this pull request Apr 8, 2021
@stepanblyschak
[sonic-swss] update sonic-swss submodule (#7263)
4351db7 
5c63670 (HEAD, origin/master, origin/HEAD) [intfmgrd] reach reconciled state at start when there are no interfaces configuration to process (#1695)
66e1aab [Dynamic Buffer Calc] Enhancement: coding style and LGTM alerts (#1693)
637e8d0 Skip Macsec test case till macsec orch code is made SAIv1.8.0 compatible (#1688)
872b5cb [ci]: archive swss pytests (#1690)
73cbd91 [Makefile] Reorder libsaimetadata and libswsscommon (#1689)
cba6576 Correct the sflow default sample rate (#1623)
aac71e6 Don't update pools when ingress_lossless_pool is created but the initialization hasn't finished yet (#1685)
ae5f051 Fix dynamic buffer bug occuring in rare condition (#1678)
691bd30 [voq/systemlag] Voq system lag functionality (#1605)

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
daall added a commit to daall/sonic-buildimage that referenced this pull request Apr 13, 2021
@daall
[202012][submodule] Update sonic-swss and sonic-utilities submodules
8807c4c 
sonic-swss
* Don't update pools when ingress_lossless_pool is created but the initialization hasn't finished yet (sonic-net#1685)
* Fix dynamic buffer bug occuring in rare condition (sonic-net#1678)

sonic-utilities
* [load_minigraph]: Avoid starting PFCWD for EPMS devicetype (sonic-net#1552)

Signed-off-by: Danny Allen <daall@microsoft.com>
@daall daall mentioned this pull request Apr 13, 2021
Merged
4 tasks
daall added a commit that referenced this pull request Apr 14, 2021
@daall
[202012][submodule] Update sonic-swss and sonic-utilities submodules (#…
c7c9141 
…7313)

sonic-swss
* Don't update pools when ingress_lossless_pool is created but the initialization hasn't finished yet (#1685)
* Fix dynamic buffer bug occuring in rare condition (#1678)

sonic-utilities
* [load_minigraph]: Avoid starting PFCWD for EPMS devicetype (#1552)

Signed-off-by: Danny Allen <daall@microsoft.com>
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
@stepanblyschak @raphaelt-nvidia
[sonic-swss] update sonic-swss submodule (sonic-net#7263)
f274f3f 
5c63670 (HEAD, origin/master, origin/HEAD) [intfmgrd] reach reconciled state at start when there are no interfaces configuration to process (sonic-net#1695)
66e1aab [Dynamic Buffer Calc] Enhancement: coding style and LGTM alerts (sonic-net#1693)
637e8d0 Skip Macsec test case till macsec orch code is made SAIv1.8.0 compatible (sonic-net#1688)
872b5cb [ci]: archive swss pytests (sonic-net#1690)
73cbd91 [Makefile] Reorder libsaimetadata and libswsscommon (sonic-net#1689)
cba6576 Correct the sflow default sample rate (sonic-net#1623)
aac71e6 Don't update pools when ingress_lossless_pool is created but the initialization hasn't finished yet (sonic-net#1685)
ae5f051 Fix dynamic buffer bug occuring in rare condition (sonic-net#1678)
691bd30 [voq/systemlag] Voq system lag functionality (sonic-net#1605)

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
@stepanblyschak
[sonic-swss] update sonic-swss submodule (sonic-net#7263)
16f00b9 
5c63670 (HEAD, origin/master, origin/HEAD) [intfmgrd] reach reconciled state at start when there are no interfaces configuration to process (sonic-net#1695)
66e1aab [Dynamic Buffer Calc] Enhancement: coding style and LGTM alerts (sonic-net#1693)
637e8d0 Skip Macsec test case till macsec orch code is made SAIv1.8.0 compatible (sonic-net#1688)
872b5cb [ci]: archive swss pytests (sonic-net#1690)
73cbd91 [Makefile] Reorder libsaimetadata and libswsscommon (sonic-net#1689)
cba6576 Correct the sflow default sample rate (sonic-net#1623)
aac71e6 Don't update pools when ingress_lossless_pool is created but the initialization hasn't finished yet (sonic-net#1685)
ae5f051 Fix dynamic buffer bug occuring in rare condition (sonic-net#1678)
691bd30 [voq/systemlag] Voq system lag functionality (sonic-net#1605)

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
@lguohan lguohan mentioned this pull request Aug 17, 2021
Merged
5 tasks
lguohan added a commit to lguohan/sonic-buildimage that referenced this pull request Aug 17, 2021
@lguohan
[submodule]: update sonic-utilities
9772d89 
* 0a145e8 2021-08-17 | Revert "[config][generic-update] Implementing patch sorting (sonic-net#1599)" (HEAD, origin/master, origin/HEAD) [Guohan Lu]
* dbcc6fd 2021-08-16 | [config reload]: fix the condition for checking if system is starting (sonic-net#1766) (HEAD, origin/master, origin/HEAD) [Guohan Lu]
* 2c7cfaa 2021-08-17 | [sonic-package-manager] switch from poetry-semver to semantic_version due to bugs found in poetry-semver (sonic-net#1710) [Stepan Blyshchak]
* 7821a3f 2021-08-13 | [vnet_route_check] don't hardcode prefix length of /24 (sonic-net#1756) [Stepan Blyshchak]
* 4175cb9 2021-08-11 | [show priority-group drop counters] Add user info output when user want to check PG counters and polling are disabled (sonic-net#1678) [Andriy Yurkiv]
* 920bb87 2021-08-10 | [config][generic-update] Implementing patch sorting (sonic-net#1599) [Mohamed Ghoneim]
* 30907c4 2021-08-06 | [config][interface][speed] Fixed the config interface speed in multiasic issue (sonic-net#1739) [Marty Y. Lok]
* 4b88e0e 2021-08-06 | [minigraph] Donot enable PFC watchdog for MgmtTsToR (sonic-net#1734) [Blueve]

Signed-off-by: Guohan Lu <lguohan@gmail.com>
@SuvarnaMeenakshi SuvarnaMeenakshi mentioned this pull request Aug 17, 2021
Merged
5 tasks
lguohan added a commit that referenced this pull request Aug 17, 2021
@lguohan
[submodule]: update sonic-utilities (#8494)
e6ea527 
* 0a145e8 2021-08-17 | Revert "[config][generic-update] Implementing patch sorting (#1599)" (HEAD, origin/master, origin/HEAD) [Guohan Lu]
* dbcc6fd 2021-08-16 | [config reload]: fix the condition for checking if system is starting (#1766) (HEAD, origin/master, origin/HEAD) [Guohan Lu]
* 2c7cfaa 2021-08-17 | [sonic-package-manager] switch from poetry-semver to semantic_version due to bugs found in poetry-semver (#1710) [Stepan Blyshchak]
* 7821a3f 2021-08-13 | [vnet_route_check] don't hardcode prefix length of /24 (#1756) [Stepan Blyshchak]
* 4175cb9 2021-08-11 | [show priority-group drop counters] Add user info output when user want to check PG counters and polling are disabled (#1678) [Andriy Yurkiv]
* 920bb87 2021-08-10 | [config][generic-update] Implementing patch sorting (#1599) [Mohamed Ghoneim]
* 30907c4 2021-08-06 | [config][interface][speed] Fixed the config interface speed in multiasic issue (#1739) [Marty Y. Lok]
* 4b88e0e 2021-08-06 | [minigraph] Donot enable PFC watchdog for MgmtTsToR (#1734) [Blueve]

Signed-off-by: Guohan Lu <lguohan@gmail.com>
judyjoseph added a commit that referenced this pull request Aug 20, 2021
@judyjoseph
Update sonic-platform-common with following commits
c95a9d1 
 1d3a810 [python coverage] fix result color bar (#202)
 3f7b359 Add a template function that returns list of asics on module (#185)
 abc2709 Fix decode error when parsing EEPROM fields (#199)
 789b41e Load interval from thermal_policy.json (#178)
 540ed1c Fix Xcvrd crash due to invalid key access in type_of_media_interface, host_electrical_interface, connector_dict (#206)
 716caf8 Unifying the platform api for get_pcie_aer_stats with PcieBase (#197)

Update sonic-utilities with following commit

 3f3974e [show priority-group drop counters] Add user info output when user want to check PG counters and polling are disabled (#1678)
 16606de Global and Interface commands for IPv6 Link local address enhancements (#1159)
volodymyrsamotiy added a commit to volodymyrsamotiy/sonic-buildimage that referenced this pull request Aug 26, 2021
@volodymyrsamotiy
[submodule][202012] Update sonic-utilities
bd7b965 
* a72e407 - (HEAD, origin/202012) [202012][fast-reboot] Remove FLEX_COUNTER_TABLE from config_db.json before reboot (sonic-net#1774) (19 hours ago) <Vaibhav Hemant Dixit>
* 205aff8 - (HEAD, origin/202012) [acl_loader]: add iptype match to the rules for dataplane acl (25 hours ago) <Guohan Lu>
* 8aa2226 - Add mock support for swsscommon classes (sonic-net#1780) (26 hours ago) <Qi Luo>
* d939cfb - [Show] Update the subcommands of Kdump. (sonic-net#1682) (3 days ago) <yozhao101>
* 6376b5c - [route_check] Filter out VNET routes (sonic-net#1612) (3 days ago) <Volodymyr Samotiy>
* ba1e457 - [show priority-group drop counters] Add user info output when user want to check PG counters and polling are disabled (sonic-net#1678) (2 weeks ago) <Andriy Yurkiv>
* 4e7707c - [minigraph] Donot enable PFC watchdog for MgmtTsToR (sonic-net#1734) (2 weeks ago) <Blueve>

Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
@stephenxs
Fix dynamic buffer bug occuring in rare condition (sonic-net#1678)
ae5f051 
What I did
Bug:
The buffermgrd can keep adding suffix to the buffer pool reference if the buffer pool isn't found when it is being referenced. In most of the cases, it's caused by wrong configuration.
Cause:
In handleBufferProfileTable, the value of each field is designated by a (lvalue) reference to the object in the tuple, which means the object in the tuple will be changed if the value is changed in the function.
Fix:
Pass the value of each field by value instead of reference.

- Why I did it
Fix bug.

- How I verified it
Manually test.

Signed-off-by: Stephen Sun stephens@nvidia.com
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this pull request Apr 28, 2022
@ayurkiv-nvda
[show priority-group drop counters] Add user info output when user wa…
4175cb9 
…nt to check PG counters and polling are disabled (sonic-net#1678)

Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>

What I did
Added additional output info for user when trying to show priority group counters and pg drop counters are disabled

How I did it
modify pg-drop script, add additional print during executing "show priority-group drop counters" if PG polling disabled

How to verify it
counterpoll pg-drop disable
show priority-group drop counters

Expect:
Warning: PG counters are disabled. Current stats may be outdated. Use 'counterpoll pg-drop enable' to enable'

Previous command output (if the output of a command-line utility has changed)
admin@r-tigon-04:/usr/local/bin$ show priority-group drop counters
Ingress PG dropped packets:
       Port    PG0    PG1    PG2    PG3    PG4    PG5    PG6    PG7
-----------  -----  -----  -----  -----  -----  -----  -----  -----
  Ethernet0      0      0      0      0      0      0      0      0
  Ethernet2      0      0      0      0      0      0      0      0
  Ethernet8      0      0      0      0      0      0      0      0
 Ethernet10      0      0      0      0      0      0      0      0
 Ethernet16      0      0      0      0      0      0      0      0

New command output (if the output of a command-line utility has changed)
admin@r-tigon-04:/usr/local/bin$ show priority-group drop counters
Warning: PG counters are disabled. Use 'counterpoll pg-drop enable' to enable polling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleveque jleveque jleveque approved these changes

@lguohan lguohan lguohan approved these changes

Assignees
No one assigned
Labels
Enhancement ➕ Platform: Inventec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@klhaung @lguohan @jleveque @stcheng