Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[console] use fixed console baud rate #1734

Merged
merged 1 commit into from
Nov 1, 2018
Merged

[console] use fixed console baud rate #1734

merged 1 commit into from
Nov 1, 2018

Conversation

yxieca
Copy link
Contributor

@yxieca yxieca commented May 23, 2018

Signed-off-by: Ying Xie ying.xie@microsoft.com

- What I did
When CONSOLE_SPEED is defined in /installer.conf, use the defined
speed. Otherwise, use 9600.

- How I did it
Check installer.conf at each boot up time and set baudrate accordingly.

- How to verify it
Tested on my dut with following scenarios:

  1. Without installer.conf: the console baudrate is fixed to 9600 after boot up.
  2. With installer.conf specifying a baudrate: the console baudrate is set to the expected value after boot up.
  3. Editing the baudrate in installer.conf in device folder to a different value. reboot the dut and the baudrate changes accordingly.

@yxieca yxieca requested a review from lguohan May 23, 2018 00:07
@yxieca
Copy link
Contributor Author

yxieca commented May 25, 2018

I rebased this change on top of latest master. Let's continue the discussions.

@yxieca
[console speed] lock console speed to start up speed
876b031 
Auto negotiating console speed could cause sonic to lock on a wrong
speed under rare conditions. The only way to come out of the wrong
speed is to issue line break or restart console service with forced
speed, or reboot sonic.

Lock down the console speed to avoid these situations.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@lguohan lguohan merged commit 5cff136 into sonic-net:master Nov 1, 2018
@yxieca yxieca deleted the baudrate branch November 2, 2018 16:11
judyjoseph added a commit that referenced this pull request Aug 7, 2021
@judyjoseph
Update sonic-utilities submodule
eee50a1 
8b149a3 Load the  database global_db only once for show cli  (#1712)
cd0e560 [config][interface][speed] Fixed the config interface speed in multiasic issue (#1739)
b595ba6 [fast-reboot] revert the change of disabling counter polling before fast-reboot (#1744)
8518820 [minigraph] Donot enable PFC watchdog for MgmtTsToR (#1734)
2213774 [CLI][show][bgp] Fix the show ip bgp network command (#1733)
3526507 [configlet] Python3 compatible syntax for extracting a key from the dict (#1721)
5b56b97 [sonic_installer] don't print errors when installing an image not supporting app ext (#1719)
a581955 [LLDP] Fix lldpshow script to enable display multiple MAC addresses on the same remote physical interface (#1657)
@lguohan lguohan mentioned this pull request Aug 17, 2021
Merged
5 tasks
lguohan added a commit to lguohan/sonic-buildimage that referenced this pull request Aug 17, 2021
@lguohan
[submodule]: update sonic-utilities
9772d89 
* 0a145e8 2021-08-17 | Revert "[config][generic-update] Implementing patch sorting (sonic-net#1599)" (HEAD, origin/master, origin/HEAD) [Guohan Lu]
* dbcc6fd 2021-08-16 | [config reload]: fix the condition for checking if system is starting (sonic-net#1766) (HEAD, origin/master, origin/HEAD) [Guohan Lu]
* 2c7cfaa 2021-08-17 | [sonic-package-manager] switch from poetry-semver to semantic_version due to bugs found in poetry-semver (sonic-net#1710) [Stepan Blyshchak]
* 7821a3f 2021-08-13 | [vnet_route_check] don't hardcode prefix length of /24 (sonic-net#1756) [Stepan Blyshchak]
* 4175cb9 2021-08-11 | [show priority-group drop counters] Add user info output when user want to check PG counters and polling are disabled (sonic-net#1678) [Andriy Yurkiv]
* 920bb87 2021-08-10 | [config][generic-update] Implementing patch sorting (sonic-net#1599) [Mohamed Ghoneim]
* 30907c4 2021-08-06 | [config][interface][speed] Fixed the config interface speed in multiasic issue (sonic-net#1739) [Marty Y. Lok]
* 4b88e0e 2021-08-06 | [minigraph] Donot enable PFC watchdog for MgmtTsToR (sonic-net#1734) [Blueve]

Signed-off-by: Guohan Lu <lguohan@gmail.com>
@SuvarnaMeenakshi SuvarnaMeenakshi mentioned this pull request Aug 17, 2021
Merged
5 tasks
lguohan added a commit that referenced this pull request Aug 17, 2021
@lguohan
[submodule]: update sonic-utilities (#8494)
e6ea527 
* 0a145e8 2021-08-17 | Revert "[config][generic-update] Implementing patch sorting (#1599)" (HEAD, origin/master, origin/HEAD) [Guohan Lu]
* dbcc6fd 2021-08-16 | [config reload]: fix the condition for checking if system is starting (#1766) (HEAD, origin/master, origin/HEAD) [Guohan Lu]
* 2c7cfaa 2021-08-17 | [sonic-package-manager] switch from poetry-semver to semantic_version due to bugs found in poetry-semver (#1710) [Stepan Blyshchak]
* 7821a3f 2021-08-13 | [vnet_route_check] don't hardcode prefix length of /24 (#1756) [Stepan Blyshchak]
* 4175cb9 2021-08-11 | [show priority-group drop counters] Add user info output when user want to check PG counters and polling are disabled (#1678) [Andriy Yurkiv]
* 920bb87 2021-08-10 | [config][generic-update] Implementing patch sorting (#1599) [Mohamed Ghoneim]
* 30907c4 2021-08-06 | [config][interface][speed] Fixed the config interface speed in multiasic issue (#1739) [Marty Y. Lok]
* 4b88e0e 2021-08-06 | [minigraph] Donot enable PFC watchdog for MgmtTsToR (#1734) [Blueve]

Signed-off-by: Guohan Lu <lguohan@gmail.com>
volodymyrsamotiy added a commit to volodymyrsamotiy/sonic-buildimage that referenced this pull request Aug 26, 2021
@volodymyrsamotiy
[submodule][202012] Update sonic-utilities
bd7b965 
* a72e407 - (HEAD, origin/202012) [202012][fast-reboot] Remove FLEX_COUNTER_TABLE from config_db.json before reboot (sonic-net#1774) (19 hours ago) <Vaibhav Hemant Dixit>
* 205aff8 - (HEAD, origin/202012) [acl_loader]: add iptype match to the rules for dataplane acl (25 hours ago) <Guohan Lu>
* 8aa2226 - Add mock support for swsscommon classes (sonic-net#1780) (26 hours ago) <Qi Luo>
* d939cfb - [Show] Update the subcommands of Kdump. (sonic-net#1682) (3 days ago) <yozhao101>
* 6376b5c - [route_check] Filter out VNET routes (sonic-net#1612) (3 days ago) <Volodymyr Samotiy>
* ba1e457 - [show priority-group drop counters] Add user info output when user want to check PG counters and polling are disabled (sonic-net#1678) (2 weeks ago) <Andriy Yurkiv>
* 4e7707c - [minigraph] Donot enable PFC watchdog for MgmtTsToR (sonic-net#1734) (2 weeks ago) <Blueve>

Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this pull request Apr 28, 2022
@Blueve
[minigraph] Donot enable PFC watchdog for MgmtTsToR (sonic-net#1734)
4b88e0e 
Signed-off-by: Jing Kan jika@microsoft.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiluo-msft qiluo-msft qiluo-msft left review comments

@lguohan lguohan lguohan left review comments

Assignees
No one assigned
Labels
Bug 🐛 Enhancement ➕
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yxieca @lguohan @qiluo-msft