Revert the feature: serial port watchdog service #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o rc.local (sonic-net#1752)" This reverts commit c105717.
yxieca
approved these changes
Jun 5, 2018
lguohan
pushed a commit
that referenced
this pull request
Jun 5, 2018
5 tasks
lguohan
added a commit
to lguohan/sonic-buildimage
that referenced
this pull request
Aug 17, 2021
* 0a145e8 2021-08-17 | Revert "[config][generic-update] Implementing patch sorting (sonic-net#1599)" (HEAD, origin/master, origin/HEAD) [Guohan Lu] * dbcc6fd 2021-08-16 | [config reload]: fix the condition for checking if system is starting (sonic-net#1766) (HEAD, origin/master, origin/HEAD) [Guohan Lu] * 2c7cfaa 2021-08-17 | [sonic-package-manager] switch from poetry-semver to semantic_version due to bugs found in poetry-semver (sonic-net#1710) [Stepan Blyshchak] * 7821a3f 2021-08-13 | [vnet_route_check] don't hardcode prefix length of /24 (sonic-net#1756) [Stepan Blyshchak] * 4175cb9 2021-08-11 | [show priority-group drop counters] Add user info output when user want to check PG counters and polling are disabled (sonic-net#1678) [Andriy Yurkiv] * 920bb87 2021-08-10 | [config][generic-update] Implementing patch sorting (sonic-net#1599) [Mohamed Ghoneim] * 30907c4 2021-08-06 | [config][interface][speed] Fixed the config interface speed in multiasic issue (sonic-net#1739) [Marty Y. Lok] * 4b88e0e 2021-08-06 | [minigraph] Donot enable PFC watchdog for MgmtTsToR (sonic-net#1734) [Blueve] Signed-off-by: Guohan Lu <lguohan@gmail.com>
5 tasks
lguohan
added a commit
that referenced
this pull request
Aug 17, 2021
* 0a145e8 2021-08-17 | Revert "[config][generic-update] Implementing patch sorting (#1599)" (HEAD, origin/master, origin/HEAD) [Guohan Lu] * dbcc6fd 2021-08-16 | [config reload]: fix the condition for checking if system is starting (#1766) (HEAD, origin/master, origin/HEAD) [Guohan Lu] * 2c7cfaa 2021-08-17 | [sonic-package-manager] switch from poetry-semver to semantic_version due to bugs found in poetry-semver (#1710) [Stepan Blyshchak] * 7821a3f 2021-08-13 | [vnet_route_check] don't hardcode prefix length of /24 (#1756) [Stepan Blyshchak] * 4175cb9 2021-08-11 | [show priority-group drop counters] Add user info output when user want to check PG counters and polling are disabled (#1678) [Andriy Yurkiv] * 920bb87 2021-08-10 | [config][generic-update] Implementing patch sorting (#1599) [Mohamed Ghoneim] * 30907c4 2021-08-06 | [config][interface][speed] Fixed the config interface speed in multiasic issue (#1739) [Marty Y. Lok] * 4b88e0e 2021-08-06 | [minigraph] Donot enable PFC watchdog for MgmtTsToR (#1734) [Blueve] Signed-off-by: Guohan Lu <lguohan@gmail.com>
5 tasks
qiluo-msft
pushed a commit
that referenced
this pull request
Jan 19, 2022
includes: 320591a [DualToR] Handle race condition between tunnel_decap and mux orchestrator (#2114) 5027a8f Handling Invalid CRM configuration gracefully (#2109) 0b120fa [ci]: use native arm64 and armhf pool (#2013) 394e88a Don't handle buffer pool watermark during warm reboot reconciling (#1987) 9008a01 patch for issue #1971 - enable Rx Drop handling for cisco-8000 (#2041) 2723ee3 create debug_shell_enable config to enable debug shell (#2060) d7be0b9 [request parser] Add unit tests for request parser for multiple values (#1766)
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
sonic-net#1766) What I did Add unit tests for request parser to parse multiple values. Why I did it Add unit tests for the feature added in PR sonic-net#1758. How I verified it Run unit tests locally and confirm the tests pass with the given conditions and constraints.
taras-keryk
pushed a commit
to taras-keryk/sonic-buildimage
that referenced
this pull request
Apr 28, 2022
…sonic-net#1766) When systemd services finished, the systemd status could running or degraded. Therefore, compare system status with starting directly. Here is what is happening on kvm switch. Some services cannot be started. Then, the system state is in degraded state. ``` admin@ARISTA01T1:~$ systemctl is-system-running starting admin@ARISTA01T1:~$ systemctl is-system-running degraded ``` Signed-off-by: Guohan Lu <lguohan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature breaks continous_reboot test on both Mellanox and Broadcom platforms