Remove unused packages in docker images and host #2807

qiluo-msft · 2019-04-20T00:38:17Z

To reduce image size.
Unused packages include:

python3.4 inside all container: never used
libpython3.6 inside snmp container: not used and not required by any python packages

Fixed the build dependencies of python3.6

Use apt-get purge instead of apt-get purge to clean up even configuration files.

Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>

jleveque · 2019-04-20T00:45:00Z

dockers/docker-snmp-sv2/Dockerfile.j2

@@ -60,7 +60,9 @@ RUN pip install /python-wheels/{{ whl }}
 RUN python3.6 -m sonic_ax_impl install

 # Clean up
-RUN apt-get -y purge libpython3.6-dev curl gcc make libdpkg-perl
+RUN apt-get -y purge libpython3.6-dev libpython3.6 curl gcc make libdpkg-perl


Should we move the -y after purge to align with all the other files while you're at it? (here and on line 65)? #Resolved

In my opinion, not necessary.

In reply to: 277117545 [](ancestors = 277117545)

Sure it's not necessary, just nice to unify everything.

lguohan · 2019-04-21T21:53:34Z

how much is reduced?

qiluo-msft · 2019-04-22T05:53:59Z

23.5 MB

jleveque · 2019-04-22T19:28:45Z

@qiluo-msft: Do you know if this will cherry-pick cleanly into the 201803 branch? If not, you will also need to create a similar PR there once this is approved and merged.

qiluo-msft · 2019-04-22T20:21:54Z

No clean cherry-pick. But should be a simple modification and I will submit a PR after this committed.

lguohan · 2019-04-24T00:26:23Z

can you provide more descriptions on the PR? not clear what you did in the PR.

* Remove unneeded packages in docker images and host * Remove libpython3.6 from snmp docker image

… (#2837) * Remove unneeded packages in docker images and host * Remove libpython3.6 from snmp docker image

* Remove unneeded packages in docker images and host * Remove libpython3.6 from snmp docker image

Why I did it 69abbc3c - (HEAD, origin/master, origin/HEAD) Revert "[GCU] Complete RDMA Platform Validation Checks [device][platform] Update Inventec new platform d6356 #2791" DellEMC S6100 Watchdog Support #2854 (8 minutes ago) 4fead896 - [sonic-package-manager] fix CLI plugin compatibility issue [sonic-utilities] advance submodule head to latest #2842 (27 hours ago) db61efca - [vlan][dhcp_relay] Clear dhcpv6 relay counter while deleting vlan ([201811] [services] Restart SwSS service upon unexpected critical process exit #2852) (33 hours ago) d5544b4a - [config] Generate sysinfo as needed when override config ([minigraph]: Add mirror type v6 condition #2836) (6 days ago) f258e2a3 - [GCU] Complete RDMA Platform Validation Checks ([device][platform] Update Inventec new platform d6356 #2791) (6 days ago) b4f4e63e - Revert "Revert frr route check ([mlnx] fix url inconsistency in fw.mk #2761)" (Support TACACS Accounting #2762) (7 days ago) 3d89589f - Update pcieutil error message on loading common pcie module (Enable Debugs in BCM Kernel-bde and Knet Modules #2786) (11 days ago) e6aacd37 - Update TRANSCEIVER_INFO table after CDB FW upgrade (Remove unused packages in docker images and host (#2807) #2837) (2 weeks ago) 33d665c4 - replace shell=True, replace xml, and replace exit() ([mellanox-simx] add ability to build simx-compatiable image #2664) (2 weeks ago) 9e510a83 - [chassis][voq[Add "config fabric port ..." commands and tests. (Watchdog enable/disable in DellEMC S6100 #2730) (2 weeks ago) aeb0dbc1 - Fix the invalid variable issue when set-fips in uboot (fix bug in file sonic-cfggen #2834) (3 weeks ago) 1e73632d - [test]: add UT coverage for GCU (Feed device info to orchagent process #2818) (3 weeks ago) 3a9995b6 - [config]Support multi-asic Golden Config override with fix ([mellanox] Update Mellanox MFT packedge #2825) (3 weeks ago) 3fb32588 - Revert "[chassis]: remote cli commands infra for sonic chassis ([mellanox] add makefiles to build Mellanox SDK from sources #2701)" ([dhcp_relay] Base DHCP Relay Docker container on Debian Stretch #2832) (3 weeks ago) 2ffe6e37 - [show][mlnx] replace shell=True, replace xml (Add support of HwSKU Mellanox-SN2700-C28D8 #2700) (3 weeks ago) a5091bba - [sonic_sku_create] remove shell=True, replace exit() with sys.exit() (removed exec from script which that prevents the further lines to be … #2816) (3 weeks ago) 71ef4f16 - [build] Fix base OS compilation issue caused by incompatibility with requests >= 2.29.0. ([201811][sairedis][utilities] advance sub module heads #2830) (3 weeks ago) 1097373b - [show] Added alias interface mode support for 'show interfaces counters ...' command ([kernel]: update sonic kernel to 4.9.0-8-2 #2468) (4 weeks ago) <Julian Chang - TW> 589375fc - correctly parsing complete ipv6 vnet info ([201811][mellanox] Update Mellanox FW version to 13.1910.0928 #2827) (4 weeks ago) 634ac77c - LAG keepalive script to reduce lacp session wait during warm-reboot (Set proper hostname on containers startup #2806) (4 weeks ago) 331c9de0 - [config]: Dynamically start and stop ndppd ([Arista] Add QoS needed files for Arista 7170 #2814) (4 weeks ago) d1f307d0 - [GCU]Fix rdma check failure ([device/celestica]: Add fwutil #2824) (4 weeks ago) ce81a340 - Revert "[config]Support multi-asic Golden Config override (Before issue “sonic-clear counters”, “show interface counters” result not complete #2738)" ([BGP docker]: start bgp_eoiu_mark service to populate bgp eoiu marker… #2823) (4 weeks ago) 61e0e810 - Added platform plugin support in load_minigraph ([db migrator] migrate the DB to latest schema when needed #2808) (4 weeks ago) d4355a96 - Change default CDB run mode to non-hitless (Revert "Watchdog enable/disable in DellEMC S6100 " #2817) (4 weeks ago) 88ffb167 - [config]config reload should generate sysinfo if missing ([Mellanox] Update SAI #2778) (4 weeks ago) 7443b9e5 - [sonic-package-manager] support extension with multiple YANG modules (dhcp_relay service stopped with "systemctl stop swss" but not restarted with "systemctl restart swss" #2752) (4 weeks ago) 522c3a9e - [sonic-package-manager] add support for multiple CLI plugin files (Updated Makefile infrastructure to build debug images. #2753) (4 weeks ago) b38fcfd1 - [show][muxcable] fix show mux hwmode muxdirection RC (syncd-rpc.mk: Fix stretch dockers build failure #2812) (5 weeks ago) 7e24463f - [chassis]: remote cli commands infra for sonic chassis ([mellanox] add makefiles to build Mellanox SDK from sources #2701) (6 weeks ago) bee593e4 - [DPB]Fixing typo in config breakout output ([submodule update]: Quagga bgpd crash fix #2802) (6 weeks ago) ada603c5 - [config]Support multi-asic Golden Config override (Before issue “sonic-clear counters”, “show interface counters” result not complete #2738) (6 weeks ago) 88a7daa8 - [show][barefoot] replace shell=True ([teamd] retry creating team_port after interface info changed #2699) (6 weeks ago) 5e99edb5 - [sonic_package_manager] replace shell=True (Upgrade Mellanox HW-MGMT: fix high CPU utilization issue #2726) (6 weeks ago) b547bb45 - [acl-loader] Only add default deny rule when table is L3 or L3V6 ([201811] [radvd] Build radvd from source; Patch so as not to treat out-of-range MTU as an error #2796) (6 weeks ago)

…lly (#15387) src/sonic-swss * 2aec547 - (HEAD -> 202205, origin/202205) [pfcwd] Enhance DLR_INIT based recovery and DLR_PACKET_ACTION for broadcom platforms (#2807) (4 days ago) [Neetha John] * fa4acd3 - Fix to substract the macsec sectag size from port MTU during InitializePort (#2789) (5 days ago) [judyjoseph]

…adcom platforms (sonic-net#2807) Signed-off-by: Neetha John <nejo@microsoft.com> What I did This PR contains the following changes * for brcm platforms that support DLR_INIT based recovery, use that method for both drop and forward action * While using DLR_INIT based recovery, do not update the pfc bitmask for that port * Update the logic to handle allowing drop/forward action on all ports without requiring a restart of swss * Mock tests for DLR_INIT and DLR_PACKET action Why I did it To provide support for DLR_INIT based pfcwd recovery on broadcom platforms in certain roles How I verified it * Mock tests * Tested on various brcm platforms (TD3 dual tor, Th2 T1, TD3 single tor) with a custom swss deb along with updated bcm config and verified that the pfcwd recovery mechanism is as expected on 202205 * Tested on td3 dual tor with custom deb along with updated bcm config and verified functionality working fine on internal branch

Why I did it 69abbc3c - (HEAD, origin/master, origin/HEAD) Revert "[GCU] Complete RDMA Platform Validation Checks [device][platform] Update Inventec new platform d6356 sonic-net#2791" DellEMC S6100 Watchdog Support sonic-net#2854 (8 minutes ago) 4fead896 - [sonic-package-manager] fix CLI plugin compatibility issue [sonic-utilities] advance submodule head to latest sonic-net#2842 (27 hours ago) db61efca - [vlan][dhcp_relay] Clear dhcpv6 relay counter while deleting vlan ([201811] [services] Restart SwSS service upon unexpected critical process exit sonic-net#2852) (33 hours ago) d5544b4a - [config] Generate sysinfo as needed when override config ([minigraph]: Add mirror type v6 condition sonic-net#2836) (6 days ago) f258e2a3 - [GCU] Complete RDMA Platform Validation Checks ([device][platform] Update Inventec new platform d6356 sonic-net#2791) (6 days ago) b4f4e63e - Revert "Revert frr route check ([mlnx] fix url inconsistency in fw.mk sonic-net#2761)" (Support TACACS Accounting sonic-net#2762) (7 days ago) 3d89589f - Update pcieutil error message on loading common pcie module (Enable Debugs in BCM Kernel-bde and Knet Modules sonic-net#2786) (11 days ago) e6aacd37 - Update TRANSCEIVER_INFO table after CDB FW upgrade (Remove unused packages in docker images and host (sonic-net#2807) sonic-net#2837) (2 weeks ago) 33d665c4 - replace shell=True, replace xml, and replace exit() ([mellanox-simx] add ability to build simx-compatiable image sonic-net#2664) (2 weeks ago) 9e510a83 - [chassis][voq[Add "config fabric port ..." commands and tests. (Watchdog enable/disable in DellEMC S6100 sonic-net#2730) (2 weeks ago) aeb0dbc1 - Fix the invalid variable issue when set-fips in uboot (fix bug in file sonic-cfggen sonic-net#2834) (3 weeks ago) 1e73632d - [test]: add UT coverage for GCU (Feed device info to orchagent process sonic-net#2818) (3 weeks ago) 3a9995b6 - [config]Support multi-asic Golden Config override with fix ([mellanox] Update Mellanox MFT packedge sonic-net#2825) (3 weeks ago) 3fb32588 - Revert "[chassis]: remote cli commands infra for sonic chassis ([mellanox] add makefiles to build Mellanox SDK from sources sonic-net#2701)" ([dhcp_relay] Base DHCP Relay Docker container on Debian Stretch sonic-net#2832) (3 weeks ago) 2ffe6e37 - [show][mlnx] replace shell=True, replace xml (Add support of HwSKU Mellanox-SN2700-C28D8 sonic-net#2700) (3 weeks ago) a5091bba - [sonic_sku_create] remove shell=True, replace exit() with sys.exit() (removed exec from script which that prevents the further lines to be … sonic-net#2816) (3 weeks ago) 71ef4f16 - [build] Fix base OS compilation issue caused by incompatibility with requests >= 2.29.0. ([201811][sairedis][utilities] advance sub module heads sonic-net#2830) (3 weeks ago) 1097373b - [show] Added alias interface mode support for 'show interfaces counters ...' command ([kernel]: update sonic kernel to 4.9.0-8-2 sonic-net#2468) (4 weeks ago) <Julian Chang - TW> 589375fc - correctly parsing complete ipv6 vnet info ([201811][mellanox] Update Mellanox FW version to 13.1910.0928 sonic-net#2827) (4 weeks ago) 634ac77c - LAG keepalive script to reduce lacp session wait during warm-reboot (Set proper hostname on containers startup sonic-net#2806) (4 weeks ago) 331c9de0 - [config]: Dynamically start and stop ndppd ([Arista] Add QoS needed files for Arista 7170 sonic-net#2814) (4 weeks ago) d1f307d0 - [GCU]Fix rdma check failure ([device/celestica]: Add fwutil sonic-net#2824) (4 weeks ago) ce81a340 - Revert "[config]Support multi-asic Golden Config override (Before issue “sonic-clear counters”, “show interface counters” result not complete sonic-net#2738)" ([BGP docker]: start bgp_eoiu_mark service to populate bgp eoiu marker… sonic-net#2823) (4 weeks ago) 61e0e810 - Added platform plugin support in load_minigraph ([db migrator] migrate the DB to latest schema when needed sonic-net#2808) (4 weeks ago) d4355a96 - Change default CDB run mode to non-hitless (Revert "Watchdog enable/disable in DellEMC S6100 " sonic-net#2817) (4 weeks ago) 88ffb167 - [config]config reload should generate sysinfo if missing ([Mellanox] Update SAI sonic-net#2778) (4 weeks ago) 7443b9e5 - [sonic-package-manager] support extension with multiple YANG modules (dhcp_relay service stopped with "systemctl stop swss" but not restarted with "systemctl restart swss" sonic-net#2752) (4 weeks ago) 522c3a9e - [sonic-package-manager] add support for multiple CLI plugin files (Updated Makefile infrastructure to build debug images. sonic-net#2753) (4 weeks ago) b38fcfd1 - [show][muxcable] fix show mux hwmode muxdirection RC (syncd-rpc.mk: Fix stretch dockers build failure sonic-net#2812) (5 weeks ago) 7e24463f - [chassis]: remote cli commands infra for sonic chassis ([mellanox] add makefiles to build Mellanox SDK from sources sonic-net#2701) (6 weeks ago) bee593e4 - [DPB]Fixing typo in config breakout output ([submodule update]: Quagga bgpd crash fix sonic-net#2802) (6 weeks ago) ada603c5 - [config]Support multi-asic Golden Config override (Before issue “sonic-clear counters”, “show interface counters” result not complete sonic-net#2738) (6 weeks ago) 88a7daa8 - [show][barefoot] replace shell=True ([teamd] retry creating team_port after interface info changed sonic-net#2699) (6 weeks ago) 5e99edb5 - [sonic_package_manager] replace shell=True (Upgrade Mellanox HW-MGMT: fix high CPU utilization issue sonic-net#2726) (6 weeks ago) b547bb45 - [acl-loader] Only add default deny rule when table is L3 or L3V6 ([201811] [radvd] Build radvd from source; Patch so as not to treat out-of-range MTU as an error sonic-net#2796) (6 weeks ago)

qiluo-msft added 2 commits April 19, 2019 19:06

Remove unneeded packages in docker images and host

0086527

Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>

Remove libpython3.6 from snmp docker image

522c10c

Signed-off-by: Qi Luo <qiluo-msft@users.noreply.github.com>

qiluo-msft requested review from jleveque and lguohan April 20, 2019 00:38

jleveque reviewed Apr 20, 2019

View reviewed changes

qiluo-msft added the Request for 201811 Branch label Apr 20, 2019

lguohan approved these changes Apr 30, 2019

View reviewed changes

qiluo-msft merged commit 6b3a26f into sonic-net:master Apr 30, 2019

qiluo-msft deleted the qiluo/mindocker branch April 30, 2019 00:21

qiluo-msft added a commit to qiluo-msft/sonic-buildimage that referenced this pull request Apr 30, 2019

Remove unused packages in docker images and host (sonic-net#2807)

b8a330e

* Remove unneeded packages in docker images and host * Remove libpython3.6 from snmp docker image

qiluo-msft mentioned this pull request Apr 30, 2019

Remove unused packages in docker images and host (#2807) #2837

Merged

yxieca pushed a commit that referenced this pull request Apr 30, 2019

Remove unused packages in docker images and host (#2807)

dd31c2d

* Remove unneeded packages in docker images and host * Remove libpython3.6 from snmp docker image

yxieca added the Included in 201811 Branch label Apr 30, 2019

lguohan pushed a commit that referenced this pull request May 1, 2019

[docker-base]: Remove unused packages in docker images and host (#2807)…

ac35206

… (#2837) * Remove unneeded packages in docker images and host * Remove libpython3.6 from snmp docker image

qiluo-msft mentioned this pull request May 14, 2019

[FRR]: Update frr to frr-7.0.1 #2899

Merged

MichelMoriniaux pushed a commit to criteo-forks/sonic-buildimage that referenced this pull request May 28, 2019

Remove unused packages in docker images and host (sonic-net#2807)

99145ce

* Remove unneeded packages in docker images and host * Remove libpython3.6 from snmp docker image

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove unused packages in docker images and host #2807

Remove unused packages in docker images and host #2807

qiluo-msft commented Apr 20, 2019 •

edited

Loading

jleveque Apr 20, 2019 •

edited by qiluo-msft

Loading

qiluo-msft Apr 20, 2019

jleveque Apr 20, 2019

lguohan commented Apr 21, 2019

qiluo-msft commented Apr 22, 2019

jleveque commented Apr 22, 2019

qiluo-msft commented Apr 22, 2019

lguohan commented Apr 24, 2019

Remove unused packages in docker images and host #2807

Remove unused packages in docker images and host #2807

Conversation

qiluo-msft commented Apr 20, 2019 • edited Loading

jleveque Apr 20, 2019 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

qiluo-msft Apr 20, 2019

Choose a reason for hiding this comment

jleveque Apr 20, 2019

Choose a reason for hiding this comment

lguohan commented Apr 21, 2019

qiluo-msft commented Apr 22, 2019

jleveque commented Apr 22, 2019

qiluo-msft commented Apr 22, 2019

lguohan commented Apr 24, 2019

qiluo-msft commented Apr 20, 2019 •

edited

Loading

jleveque Apr 20, 2019 •

edited by qiluo-msft

Loading