[minigraph.py] Generate items needed by streaming telemetry service #3759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
reviewed
Nov 15, 2019
src/sonic-config-engine/minigraph.py
Outdated
Comment on lines
632
to
634
| 'server_crt': '/etc/sonic/telemetry/streamingtelemetryserver.cer', | ||
| 'server_key': '/etc/sonic/telemetry/streamingtelemetryclient.key', | ||
| 'ca_crt': '/etc/sonic/telemetry/dsmsroot.cer' |
There was a problem hiding this comment.
What if we need other certificates on the SONiC box? Maybe the keys are too generic: "server_crt", "server_key", "ca_crt". Maybe we need to prefix them with the component they're used for, e.g., "telemetry_server_crt", "telemetry_server_key", "telemetry_ca_crt", etc.
Or maybe this should be moved out of the DEVICE_METADATA table and into the TELEMETRY table below?
@lguohan: What is your opinion here?
There was a problem hiding this comment.
Hi Joe, such keys are used in telemetry contrainers and already defined:
https://github.com/Azure/sonic-buildimage/blob/master/dockers/docker-sonic-telemetry/telemetry.sh
If we need change, we need change this place as well. It will break other partner using this feature now, if we device to use other key names.
There was a problem hiding this comment.
Ah. Good to know.
@lguohan: Should we merge this as-is and deal with making changes to support other certificates if and when we need them?
There was a problem hiding this comment.
@hui-ma: I think we can go ahead and merge this as-is for now, but I think we need to go back and think about a way to restructure this in order for SONiC to manage multiple keys/certs.
hui-ma
approved these changes
Nov 15, 2019
jleveque
suggested changes
Nov 20, 2019
jleveque
changed the title
jleveque
approved these changes
Nov 21, 2019
zhenggen-xu
pushed a commit
to zhenggen-xu/sonic-buildimage
that referenced
this pull request
Jan 10, 2020
mlok-nokia
pushed a commit
to mlok-nokia/sonic-buildimage
that referenced
this pull request
Feb 27, 2025
…atically (sonic-net#631) #### Why I did it src/sonic-utilities ``` * a663b17d - (HEAD -> 202405, origin/202405) Revert "enable pfcwd for backplane ports (sonic-net#3759)" (sonic-net#122) (22 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
mssonicbld
added a commit
that referenced
this pull request
Mar 2, 2025
…atically (#21343) #### Why I did it src/sonic-utilities ``` * 899ed9b9 - (HEAD -> master, origin/master, origin/HEAD) Remove Multi ASIC namespace Check. (#3783) (3 days ago) [Xincun Li] * 9f1eab43 - Memory Statistics Config and Show Commands (#3575) (3 days ago) [Kanza Latif] * 595c2aaa - Utilities Changes for DHCP DoS Mitigation Feature (#3301) (3 days ago) [Asad Raza] * a3d15bc1 - Add multi-asic support for dropconfig (#3735) (3 days ago) [HP] * 5ce06b27 - Add golden config check (#3770) (4 days ago) [Xincun Li] * 3c50deeb - Fix `vnet_route_check` for active and inactive routes, add `--all` option (#3763) (9 days ago) [mramezani95] * 40ba225f - Revert "enable pfcwd for backplane ports (#3759)" (#3767) (13 days ago) [Dashuai Zhang] * 2866ccd9 - enable pfcwd for backplane ports (#3759) (2 weeks ago) [Dashuai Zhang] * 3abd19e3 - [FC] remove FC delay field (#3577) (3 weeks ago) [Stepan Blyshchak] * 11c27163 - Improve SONiC disk checker to handle disk full case and mount overlay fs to allow remote user login. (#3700) (3 weeks ago) [Hua Liu] * 13619aa2 - [QOS] Skip showing unnecessary warning message (#3708) (3 weeks ago) [Vivek] * f4e6e5b8 - Fixing 'show ip bgp neighbor <ip>' in frr unified config mode (#3738) (3 weeks ago) [kalash-nexthop] * 9a18155e - Optimize lag_keepalive by crafting the LACPDU packet ourselves (#3170) (3 weeks ago) [Saikrishna Arcot] * a7deb8c0 - display proper message with proper errno for kvm. (#3750) (3 weeks ago) [Dawei Huang] * 865f196d - [Mellanox] Add new SN5640 platform and HwSKU (#3742) (4 weeks ago) [Noa Or] * 5fa85027 - [show_techsupport][pstore] Archive /var/lib/systemd/pstore info to techsupport (#3745) (4 weeks ago) [Marty Y. Lok] * 8f69d5a6 - sonic-utilities: WRED stats feature changes on sonic-utilities (#2807) (4 weeks ago) [Rajesh Perumal R] * 9d273f16 - Fix call for spanning-tree commands in dump script (#3723) (4 weeks ago) [DavidZagury] * 6d95d9bd - Make 'show ip bgp summary' work even when we don't have any peer groups (#3739) (4 weeks ago) [kalash-nexthop] * 7f3957c4 - Fix ssdhealth failure on VS platform (#3743) (4 weeks ago) [Vivek] * 97b4e4b8 - Fix show interface counters for Chassis Packet Supervisor (#3734) (4 weeks ago) [anamehra] * 414935b7 - Add recover asic_id config if load golden config. (#3711) (5 weeks ago) [Xincun Li] * 973cfdc3 - Remove partially installer image when image install failed. (#3712) (5 weeks ago) [Hua Liu] * 97c20ccd - CLI support for SmartSwitch PMON (#3271) (5 weeks ago) [rameshraghupathy] * 752c3d49 - [ACL] Display rule and table info written to APP DB (#3713) (5 weeks ago) [Vivek] * fbd0c3b1 - [show][interface] Add changes for show interface flap command (#3724) (5 weeks ago) [vdahiya12] * ddccabee - [show][interface] Add changes for show interface errors command (#3721) (5 weeks ago) [vdahiya12] * be870a6e - [config] Exit with non-zero when qos reload fail (#3710) (6 weeks ago) [Jianyue Wu] * ffa66e96 - Remove debug dump import by default (#3715) (6 weeks ago) [Vivek] * fc3a3cbe - [ssdhealth] Check for default device before falling back to discovery (#3693) (6 weeks ago) [Vivek] * 782c33a1 - [yang] Enforce yang full support in full config command (#3716) (6 weeks ago) [jingwenxie] * a5b7a904 - [show][interfaces] Add proposal for show interfaces flap (#3627) (6 weeks ago) [vdahiya12] * 0083a124 - sonic-utilities: add th5 hwskus to gcu conf file (#3714) (7 weeks ago) [Chris] * 81cf04f7 - [Mellanox] Add Mellanox-SN5610N-C256S2, Mellanox-SN5610N-C224O8 to GCU validators (#3658) (7 weeks ago) [noaOrMlnx] * 349a1018 - [db_migrator] Migrate tunnel table (#3704) (7 weeks ago) [Longxiang Lyu] * 0e327c5f - show ip interfaces: fix exception with BGP unnumbered (#3695) (8 weeks ago) [Brad House] * 7100f73b - [show_tech] modify generate_dump to includes BERT data and also the platform specified hw-mgmt info (#3676) (8 weeks ago) [Marty Y. Lok] * 80d46988 - Delete TRSNCEIVER tables while config reload (#3680) (8 weeks ago) [noaOrMlnx] * bf6ff9f9 - Enable multi asic golden config YANG validation. (#3685) (8 weeks ago) [Xincun Li] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added new keys to config DB needed for telemetry agent
- How I did it
- How to verify it
config load_minigraph. Once successful new added entries will appear in config_db
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)