[TSA]: Add community to the loopback prefix, when isolated #3708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
approved these changes
Nov 5, 2019
akokhan
reviewed
Nov 11, 2019
| @@ -235,7 +235,7 @@ sudo bash -c "echo '{ \"DEVICE_METADATA\": { \"localhost\": { \"default_bgp_stat | |||
| sudo cp $IMAGE_CONFIGS/snmp/snmp.yml $FILESYSTEM_ROOT/etc/sonic/ | |||
|
|
|||
| # Copy ASN configuration files | |||
| sudo cp $IMAGE_CONFIGS/asn/deployment_id_asn_map.yml $FILESYSTEM_ROOT/etc/sonic/ | |||
There was a problem hiding this comment.
Hi @pavel-shirshov
I think this change breaks bgp_speaker TCs.
TASK [test : fetch bgp speaker asn number from DUT] ****************************
Monday 11 November 2019 12:07:39 +0000 (0:00:00.110) 0:00:12.550 *******
�[0;31mfatal: [cab18-2-dut]: FAILED! => {"changed": true, "cmd": "sonic-cfggen -m -d -y /etc/sonic/deployment_id_asn_map.yml -v \"deployment_id_asn_map[DEVICE_METADATA['localhost']['deployment_id']]\"", "delta": "0:00:00.166444", "end": "2019-11-11 12:07:39.972509", "failed": true, "rc": 1, "start": "2019-11-11 12:07:39.806065", "stderr": "Traceback (most recent call last):\n File \"/usr/local/bin/sonic-cfggen\", line 318, in <module>\n main()\n File \"/usr/local/bin/sonic-cfggen\", line 250, in main\n with open(yaml_file, 'r') as stream:\nIOError: [Errno 2] No such file or directory: '/etc/sonic/deployment_id_asn_map.yml'", "stdout": "", "stdout_lines": [], "warnings": []}�[0m
Could you please check?
There was a problem hiding this comment.
Hi @akokhan
Thank you for your report. Can you please check the fix? sonic-net/sonic-mgmt#1204 ?
3 tasks
zhenggen-xu
pushed a commit
to zhenggen-xu/sonic-buildimage
that referenced
this pull request
Jan 10, 2020
…#3708) * Rename asn/deployment_id_asn_map.yaml to constants/constants.yaml * Fix bgp templates * Add community for loopback when bgpd is isolated * Use correct community value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
vtysh -ffunctionality instead ofvtysh -c- How to verify it
Build an image run on your dut
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)