[PATCH v1]: Adding set/get/del functionality to Table class #1

eladraz · 2016-03-10T12:36:03Z

This patchset adds set/get/del API to Table.
It also refactor ProducerTable and ConsumerTable to use new API

Signed-off-by: Elad Raz eladr@mellanox.com

To be sqaush with cf7eb02 ("common: Adding Table class"). Adding text: In addition Table class provide a direct access to Redis DB. The set() command writes to Redis using HSET command. Usage: DBConnector db(0, "localhost", 6379, 0); Table t(&db1, "A_TABLE"); FieldValueTuple a("field", "value"); vector<FieldValueTuple> attrs = { a }; t.set("key1", attrs); The get() command read values using the HGETALL command. Usage: vector<FieldValueTuple> v; if (!t.get("TEST", v)) { cout << "not exists" << endl; return 0; } for(auto i : v) { cout << fvField(i) << " = " << fvValue(i) << endl; } The del() command simply deletes an entry (Using DEL command) Signed-off-by: Elad Raz <eladr@mellanox.com>

To be squash to 093a828 ("common: Adding ProducerTable class") Signed-off-by: Elad Raz <eladr@mellanox.com>

To be squash to ea36e48 ("portsyncd: Initial commit portsyncd") Move the check API to Table::get() No commit message change Signed-off-by: Elad Raz <eladr@mellanox.com>

To be squash to 093a828 ("common: Adding ProducerTable class") Signed-off-by: Elad Raz <eladr@mellanox.com>

Remove peek() API, which is now Table::get() API To be squash to c5449c9 ("common: Adding ConsumerTable class") Please change commit message to remove peek() API for descriptor Signed-off-by: Elad Raz <eladr@mellanox.com>

stcheng · 2016-03-16T00:07:53Z

finished squash to one patch and merged to master.

* [mirrororch]: Set the VLAN header only when the packet is mirrored to a VLAN * Fix aclfield.mask (#1)

Sonic bm tor cli

updating to V2 repackage

* Fix the stack-overflow issue in AclOrch::getTableById() In case the table_id and m_mirrorTableId/m_mirrorTableId are empty The function would be called recursively without ending. ``` If we have some rule that does not have table defined, it will trigger this issue. (gdb) bt #0 0x00007f77ac5af3a9 in swss::Logger::write (this=0x7f77ac801ec0 <swss::Logger::getInstance()::m_logger>, prio=swss::Logger::SWSS_DEBUG, fmt=0x7f77ac5f1690 ":> %s: enter") at logger.cpp:209 #1 0x00000000004a5792 in AclOrch::getTableById (this=this@entry=0x1c722a0, table_id="") at aclorch.cpp:2617 #2 0x00000000004a59d1 in AclOrch::getTableById (this=this@entry=0x1c722a0, table_id="") at aclorch.cpp:2634 #3 0x00000000004a59d1 in AclOrch::getTableById (this=this@entry=0x1c722a0, table_id="") at aclorch.cpp:2634 ... #20944 0x00000000004a59d1 in AclOrch::getTableById (this=this@entry=0x1c722a0, table_id="") at aclorch.cpp:2634 #20945 0x00000000004ad3ce in AclOrch::doAclRuleTask (this=this@entry=0x1c722a0, consumer=...) at aclorch.cpp:2437 #20946 0x00000000004b04cd in AclOrch::doTask (this=0x1c722a0, consumer=...) at aclorch.cpp:2141 #20947 0x00000000004231b2 in Orch::doTask (this=0x1c722a0) at orch.cpp:369 #20948 0x000000000041c4e9 in OrchDaemon::start (this=this@entry=0x1c19960) at orchdaemon.cpp:376 #20949 0x0000000000409ffc in main (argc=<optimized out>, argv=0x7ffe2e392d68) at main.cpp:295 (gdb) p table_id $1 = "" (gdb) p m_mirrorTableId $2 = "" (gdb) p m_mirrorV6TableId $3 = "" ``` Signed-off-by: Zhenggen Xu <zxu@linkedin.com>

…dtel-one-watchlist_tests [aclorch] Create sonic-swss tests for dtel acl

Currently, ASAN sometimes reports the BufferOrch::m_buffer_type_maps and QosOrch::m_qos_maps as leaked. However, their lifetime is the lifetime of a process so they are not really 'leaked'. This also adds a simple way to add more suppressions later if required. Example of ASAN report: Direct leak of 48 byte(s) in 1 object(s) allocated from: #0 0x7f96aa952d30 in operator new(unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.5+0xead30) #1 0x55ca1da9f789 in __static_initialization_and_destruction_0 /__w/2/s/orchagent/bufferorch.cpp:39 #2 0x55ca1daa02af in _GLOBAL__sub_I_bufferorch.cpp /__w/2/s/orchagent/bufferorch.cpp:1321 #3 0x55ca1e2a9cd4 (/usr/bin/orchagent+0xe89cd4) Direct leak of 48 byte(s) in 1 object(s) allocated from: #0 0x7f96aa952d30 in operator new(unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.5+0xead30) #1 0x55ca1da6d2da in __static_initialization_and_destruction_0 /__w/2/s/orchagent/qosorch.cpp:80 #2 0x55ca1da6ecf2 in _GLOBAL__sub_I_qosorch.cpp /__w/2/s/orchagent/qosorch.cpp:2000 #3 0x55ca1e2a9cd4 (/usr/bin/orchagent+0xe89cd4) - What I did Added an lsan suppression config with static variable leak suppression - Why I did it To suppress ASAN false positives - How I verified it Run a test that produces the static variable leaks report and checked that report has these leaks suppressed. Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>

Currently, ASAN sometimes reports the BufferOrch::m_buffer_type_maps and QosOrch::m_qos_maps as leaked. However, their lifetime is the lifetime of a process so they are not really 'leaked'. This also adds a simple way to add more suppressions later if required. Example of ASAN report: Direct leak of 48 byte(s) in 1 object(s) allocated from: #0 0x7f96aa952d30 in operator new(unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.5+0xead30) sonic-net#1 0x55ca1da9f789 in __static_initialization_and_destruction_0 /__w/2/s/orchagent/bufferorch.cpp:39 sonic-net#2 0x55ca1daa02af in _GLOBAL__sub_I_bufferorch.cpp /__w/2/s/orchagent/bufferorch.cpp:1321 sonic-net#3 0x55ca1e2a9cd4 (/usr/bin/orchagent+0xe89cd4) Direct leak of 48 byte(s) in 1 object(s) allocated from: #0 0x7f96aa952d30 in operator new(unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.5+0xead30) sonic-net#1 0x55ca1da6d2da in __static_initialization_and_destruction_0 /__w/2/s/orchagent/qosorch.cpp:80 sonic-net#2 0x55ca1da6ecf2 in _GLOBAL__sub_I_qosorch.cpp /__w/2/s/orchagent/qosorch.cpp:2000 sonic-net#3 0x55ca1e2a9cd4 (/usr/bin/orchagent+0xe89cd4) - What I did Added an lsan suppression config with static variable leak suppression - Why I did it To suppress ASAN false positives - How I verified it Run a test that produces the static variable leaks report and checked that report has these leaks suppressed. Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>

…2446) * Add events publish * Added header file * signature fix * syntax * syntax * syntax * syntax * syntax * syntax * Updated fake code * Remove if and log messages for event_publish * Remove if and log messages for event_publish (#1) * Remove event_handle_t from signature and add globally * Remove extern orchdaemon.cpp * Revert unneeded changes Co-authored-by: zbud-msft <zainbudhwani@microsoft.com> Co-authored-by: Zain Budhwani <99770260+zbud-msft@users.noreply.github.com>

…up.py file (sonic-net#1)

**What I did** Fix the Mem Leak by moving the raw pointers in type_maps to use smart pointers **Why I did it** ``` Indirect leak of 83776 byte(s) in 476 object(s) allocated from: #0 0x7f0a2a414647 in operator new(unsigned long) ../../../../src/libsanitizer/asan/asan_new_delete.cpp:99 #1 0x5555590cc923 in __gnu_cxx::new_allocator, std::allocator > const, referenced_object> > >::allocate(unsigned long, void const*) /usr/include/c++/10/ext/new_allocator.h:115 #2 0x5555590cc923 in std::allocator_traits, std::allocator > const, referenced_object> > > >::allocate(std::allocator, std::allocator > const, referenced_object> > >&, unsigned long) /usr/include/c++/10/bits/alloc_traits.h:460 #3 0x5555590cc923 in std::_Rb_tree, std::allocator >, std::pair, std::allocator > const, referenced_object>, std::_Select1st, std::allocator > const, referenced_object> >, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::_M_get_node() /usr/include/c++/10/bits/stl_tree.h:584 #4 0x5555590cc923 in std::_Rb_tree_node, std::allocator > const, referenced_object> >* std::_Rb_tree, std::allocator >, std::pair, std::allocator > const, referenced_object>, std::_Select1st, std::allocator > const, referenced_object> >, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::_M_create_node, std::allocator > const&>, std::tuple<> >(std::piecewise_construct_t const&, std::tuple, std::allocator > const&>&&, std::tuple<>&&) /usr/include/c++/10/bits/stl_tree.h:634 #5 0x5555590cc923 in std::_Rb_tree_iterator, std::allocator > const, referenced_object> > std::_Rb_tree, std::allocator >, std::pair, std::allocator > const, referenced_object>, std::_Select1st, std::allocator > const, referenced_object> >, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::_M_emplace_hint_unique, std::allocator > const&>, std::tuple<> >(std::_Rb_tree_const_iterator, std::allocator > const, referenced_object> >, std::piecewise_construct_t const&, std::tuple, std::allocator > const&>&&, std::tuple<>&&) /usr/include/c++/10/bits/stl_tree.h:2461 #6 0x5555590e8757 in std::map, std::allocator >, referenced_object, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::operator[](std::__cxx11::basic_string, std::allocator > const&) /usr/include/c++/10/bits/stl_map.h:501 #7 0x5555590d48b0 in Orch::setObjectReference(std::map, std::allocator >, std::map, std::allocator >, referenced_object, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >*, std::less, std::allocator > >, std::allocator, std::allocator > const, std::map, std::allocator >, referenced_object, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >*> > >&, std::__cxx11::basic_string, std::allocator > const&, std::__cxx11::basic_string, std::allocator > const&, std::__cxx11::basic_string, std::allocator > const&, std::__cxx11::basic_string, std::allocator > const&) orchagent/orch.cpp:450 #8 0x5555594ff66b in QosOrch::handleQueueTable(Consumer&, std::tuple, std::allocator >, std::__cxx11::basic_string, std::allocator >, std::vector, std::allocator >, std::__cxx11::basic_string, std::allocator > >, std::allocator, std::allocator >, std::__cxx11::basic_string, std::allocator > > > > >&) orchagent/qosorch.cpp:1763 #9 0x5555594edbd6 in QosOrch::doTask(Consumer&) orchagent/qosorch.cpp:2179 #10 0x5555590c8743 in Consumer::drain() orchagent/orch.cpp:241 #11 0x5555590c8743 in Consumer::drain() orchagent/orch.cpp:238 #12 0x5555590c8743 in Consumer::execute() orchagent/orch.cpp:235 #13 0x555559090dad in OrchDaemon::start() orchagent/orchdaemon.cpp:755 #14 0x555558e9be25 in main orchagent/main.cpp:766 #15 0x7f0a299b6d09 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x23d09) ```

Darren Loher and others added 8 commits March 9, 2016 16:28

doc: Adding documentations

3c73b30

arch doc moved to sonic repo

66dd01d

adding schema doc

7049c67

common: ProducerTable: change set and del to inherit from Table APIs

fbd8fff

To be squash to 093a828 ("common: Adding ProducerTable class") Signed-off-by: Elad Raz <eladr@mellanox.com>

portsyncd: Migrate to Table::get() API

3facabc

To be squash to ea36e48 ("portsyncd: Initial commit portsyncd") Move the check API to Table::get() No commit message change Signed-off-by: Elad Raz <eladr@mellanox.com>

common: ProducerTable: Refactor API to use Table::formatHSET

f31f640

To be squash to 093a828 ("common: Adding ProducerTable class") Signed-off-by: Elad Raz <eladr@mellanox.com>

common: ConsumerTable: Remove peek() API

0d523ab

Remove peek() API, which is now Table::get() API To be squash to c5449c9 ("common: Adding ConsumerTable class") Please change commit message to remove peek() API for descriptor Signed-off-by: Elad Raz <eladr@mellanox.com>

stcheng force-pushed the master branch 2 times, most recently from 24aa2f6 to 6293c3d Compare March 15, 2016 20:24

stcheng closed this Mar 16, 2016

lguohan mentioned this pull request Apr 14, 2017

#1 AclOrch::collectCountersThread (pAclOrch=0x1614da0) at aclorch.cpp:1279 #190

Closed

pavel-shirshov mentioned this pull request Apr 30, 2017

GPF in orchagent. ACL counters related code #201

Closed

qiluo-msft added a commit that referenced this pull request Aug 9, 2017

Fix everflow for SAI 1.0 (#282)

47cd2ab

* [mirrororch]: Set the VLAN header only when the packet is mirrored to a VLAN * Fix aclfield.mask (#1)

jipanyang mentioned this pull request Oct 13, 2017

orchagent hangs at switchorch due to erase operation on map #347

Closed

marian-pritsak pushed a commit to marian-pritsak/sonic-swss that referenced this pull request Jun 22, 2018

Merge pull request sonic-net#1 from YonatanPitz/sonic_bm_tor_cli

abec020

Sonic bm tor cli

ishidawataru pushed a commit to ishidawataru/sonic-swss that referenced this pull request Aug 29, 2018

Merge pull request sonic-net#1 from tombo315/master

7bbe841

updating to V2 repackage

vemulabalaji mentioned this pull request Nov 21, 2018

syslog message with invalid subnetmask #701

Open

nikos-github mentioned this pull request Dec 6, 2018

mlnx-sn2100: syncd crash on config reload and orchagent termination #724

Open

skg-net mentioned this pull request Nov 27, 2019

Increase ip2me CIR/CBS for faster in-band file transfers #1000

Merged

garigipati mentioned this pull request May 22, 2020

Applying the same Vnet's twice causes orchagent crash #1298

Closed

rupesh-k mentioned this pull request Jul 2, 2020

Fix in script to avoid orchagent crash when port down followed by fdb… #1340

Merged

rajkumar38 mentioned this pull request Jul 29, 2020

[fdborch] Fixed Orchagent crash in FDB flush on port disable. #1369

Merged

raphaelt-nvidia mentioned this pull request Oct 14, 2021

Orchagent validates mirror session queue parameter against maximum value from SAI #1957

Merged

EdenGri referenced this pull request in EdenGri/sonic-swss Feb 28, 2022

use new file location for sys eeprom and sfp eeprom on msn2700 (#1)

d30a448

msosyak pushed a commit to msosyak/sonic-swss that referenced this pull request Apr 13, 2022

Merge pull request sonic-net#1 from KostiantynYarovyiBf/kyarovyi/acl-…

3fa44d8

…dtel-one-watchlist_tests [aclorch] Create sonic-swss tests for dtel acl

skbarista mentioned this pull request Nov 29, 2022

sonic-swss: Fix orchagent crash in generateQueueMapPerPort. #2552

Merged

jcaiMR mentioned this pull request Jan 30, 2023

[Workaround] EvpnRemoteVnip2pOrch warmboot check failure #2626

Merged

lukasstockner pushed a commit to genesiscloud/sonic-swss that referenced this pull request Apr 2, 2023

Initial add of EEPROM, LED, PSU and SFP package files, as well as set…

0581611

…up.py file (sonic-net#1)

bingwang-ms mentioned this pull request May 1, 2023

Combine v4 and v6 L3 ACL rules on optimized platforms #1267 #2735

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PATCH v1]: Adding set/get/del functionality to Table class #1

[PATCH v1]: Adding set/get/del functionality to Table class #1

eladraz commented Mar 10, 2016

stcheng commented Mar 16, 2016

[PATCH v1]: Adding set/get/del functionality to Table class #1

[PATCH v1]: Adding set/get/del functionality to Table class #1

Conversation

eladraz commented Mar 10, 2016

stcheng commented Mar 16, 2016