[PATCH v2]: teamsyncd #3

eladraz · 2016-03-16T08:57:31Z

This patchset adding support in reflection Linux LAG into Redis DB
The chosen Linux LAG implementation is teamd, since it's better than bond.

Signed-off-by: Elad Raz eladr@mellanox.com

Adding support of removeSelectable() API. This API can be invoked in any condition, including from readMe() API. Signed-off-by: Elad Raz <eladr@mellanox.com>

The teamsyncd listens to RTM_NEWLINK and RTM_DELLINK and creates or delete entries at the LAG_TABLE:<team0>. Example: 127.0.0.1:6379> HGETALL "LAG_TABLE:team0" 1) "admin_status" 2) "down" 3) "oper_status" 4) "down" 5) "mtu" 6) "1500" In addition for each team device, the teamsyncd listens to team events and reflects the LAG ports into the redis under: LAG_TABLE:<team0>:port For example: 127.0.0.1:6379> HGETALL "LAG_TABLE:team0:veth0" 1) "linkup" 2) "down" 3) "speed" 4) "0Mbit" 5) "duplex" 6) "half" Signed-off-by: Elad Raz <eladr@mellanox.com>

kcudnik · 2016-04-20T01:40:21Z

common/select.cpp

@@ -13,6 +13,16 @@ void Select::addSelectable(Selectable *c)
    m_objects.push_back(c);
 }

+void Select::removeSelectable(Selectable *c)
+{
+    for (auto i = m_objects.begin(); i != m_objects.end(); i++)


you could use std::find_first_of

lguohan · 2016-05-10T14:30:24Z

ack

stcheng · 2016-05-18T18:35:55Z

merged. thanks.

Add toggles for cache thresholds

* initial barefoot support october 2017 * import changes from telemetry branch * Fix merge issues w.r.t rel_6_0 branch * add validate and get port speed APIs - cleanup deletes from earlier checkin * missed changes from earlier * missed integration delete * trying to get close to master version - and not break other vendor * set the port config in the ASIC_DB * update hostif oper status besides the DB update * Fix compilation issues * merge closer to master - including spaces and comments * fix typos enable mirror * cosmetic fix * Fix errors due to saiacl.h changes * Fix more errors due to sai header file changes * fix the order of nexthop/neighbor delete * Fix compilation issues and few issues seen in testing * Changes needed to add new Dtel api support to sairedis * Report session DTel table related fixes * Add more error handling code * Fix logic to read table name and keys from m_toSync map * Update value for dtel actions * Handle boolean attributes to accept true/false as well as presence/absence * Fix merge errors * Incorporate configdb related changes for dtel * fix code merge issue * Incorporate configdb related changes for dtel * add pfc_detect lua script * Changes to incorporate new DTel SAI changes * SONiC changes due to DTel experimental SAI changes * cleanup configure.ac to allow barefoot platform includes * fix typo * revert commented tunneldecap * test selective tunneldecap * revert too ambitious an attempt and just push_back into vector! * change fec mode to string (from integer) * cleanup based on review * closer to 201712 - cosmetic cleanup * address review comments * fix format * Support for platforms based on Barefoot Networks' device (#452) * Fix issue with "config save" followed by reboot * Temp remove crmorch Currently orchagent crashes if crm is running. Needs to be fixed * Initial code changes to address community design review comments * Temp remove crmorch Currently orchagent crashes if crm is running. Needs to be fixed P.S This is actual commit that removes crm. Previous commit was to correct a typo, and has wrong commit message * More changes to address review comments * Fix build errors * Fix for orchagent crash * Fix queue report deletion error * Bug fixes * Re-enable crm orchagent (#3) * Add support for new watchlist attribute to enable/disable tail drop reporting * Add new VS test for Dataplane Telemetry feature * Add support for AN and FEC to be specified in port_config.ini * do not set autoneg if it is already set * Address review comments * Fix compilation errors * set port adv speed for AN and add test Signed-off-by: Guohan Lu <gulv@microsoft.com> * Convert all the tabs to spaces * Bring in changes for port an/fec from azure master * support autoneg and fec in port config ini file * if autoneg is specified, along with speed; speed is set seperately as port attribute * Address review comments * Remove trailing whitespaces * Fix vs test indentation * Address review comments * Fix for VS test * Fix VS test failure * Fix for VS test * More VS test fixes * Fix for test_mirror VS test that was failing due to new DTel ACL tables

Adding Documentation Signed-off-by: John Arnold johnar@microsoft.com

DBInterface supports redis connection options

* Fix the stack-overflow issue in AclOrch::getTableById() In case the table_id and m_mirrorTableId/m_mirrorTableId are empty The function would be called recursively without ending. ``` If we have some rule that does not have table defined, it will trigger this issue. (gdb) bt #0 0x00007f77ac5af3a9 in swss::Logger::write (this=0x7f77ac801ec0 <swss::Logger::getInstance()::m_logger>, prio=swss::Logger::SWSS_DEBUG, fmt=0x7f77ac5f1690 ":> %s: enter") at logger.cpp:209 #1 0x00000000004a5792 in AclOrch::getTableById (this=this@entry=0x1c722a0, table_id="") at aclorch.cpp:2617 #2 0x00000000004a59d1 in AclOrch::getTableById (this=this@entry=0x1c722a0, table_id="") at aclorch.cpp:2634 #3 0x00000000004a59d1 in AclOrch::getTableById (this=this@entry=0x1c722a0, table_id="") at aclorch.cpp:2634 ... #20944 0x00000000004a59d1 in AclOrch::getTableById (this=this@entry=0x1c722a0, table_id="") at aclorch.cpp:2634 #20945 0x00000000004ad3ce in AclOrch::doAclRuleTask (this=this@entry=0x1c722a0, consumer=...) at aclorch.cpp:2437 #20946 0x00000000004b04cd in AclOrch::doTask (this=0x1c722a0, consumer=...) at aclorch.cpp:2141 #20947 0x00000000004231b2 in Orch::doTask (this=0x1c722a0) at orch.cpp:369 #20948 0x000000000041c4e9 in OrchDaemon::start (this=this@entry=0x1c19960) at orchdaemon.cpp:376 #20949 0x0000000000409ffc in main (argc=<optimized out>, argv=0x7ffe2e392d68) at main.cpp:295 (gdb) p table_id $1 = "" (gdb) p m_mirrorTableId $2 = "" (gdb) p m_mirrorV6TableId $3 = "" ``` Signed-off-by: Zhenggen Xu <zxu@linkedin.com>

* Add fgnhg link handling changes for 201911 * Improve tests to include link handling, fix compilation issue after rebase

Currently, ASAN sometimes reports the BufferOrch::m_buffer_type_maps and QosOrch::m_qos_maps as leaked. However, their lifetime is the lifetime of a process so they are not really 'leaked'. This also adds a simple way to add more suppressions later if required. Example of ASAN report: Direct leak of 48 byte(s) in 1 object(s) allocated from: #0 0x7f96aa952d30 in operator new(unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.5+0xead30) #1 0x55ca1da9f789 in __static_initialization_and_destruction_0 /__w/2/s/orchagent/bufferorch.cpp:39 #2 0x55ca1daa02af in _GLOBAL__sub_I_bufferorch.cpp /__w/2/s/orchagent/bufferorch.cpp:1321 #3 0x55ca1e2a9cd4 (/usr/bin/orchagent+0xe89cd4) Direct leak of 48 byte(s) in 1 object(s) allocated from: #0 0x7f96aa952d30 in operator new(unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.5+0xead30) #1 0x55ca1da6d2da in __static_initialization_and_destruction_0 /__w/2/s/orchagent/qosorch.cpp:80 #2 0x55ca1da6ecf2 in _GLOBAL__sub_I_qosorch.cpp /__w/2/s/orchagent/qosorch.cpp:2000 #3 0x55ca1e2a9cd4 (/usr/bin/orchagent+0xe89cd4) - What I did Added an lsan suppression config with static variable leak suppression - Why I did it To suppress ASAN false positives - How I verified it Run a test that produces the static variable leaks report and checked that report has these leaks suppressed. Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>

Currently, ASAN sometimes reports the BufferOrch::m_buffer_type_maps and QosOrch::m_qos_maps as leaked. However, their lifetime is the lifetime of a process so they are not really 'leaked'. This also adds a simple way to add more suppressions later if required. Example of ASAN report: Direct leak of 48 byte(s) in 1 object(s) allocated from: #0 0x7f96aa952d30 in operator new(unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.5+0xead30) sonic-net#1 0x55ca1da9f789 in __static_initialization_and_destruction_0 /__w/2/s/orchagent/bufferorch.cpp:39 sonic-net#2 0x55ca1daa02af in _GLOBAL__sub_I_bufferorch.cpp /__w/2/s/orchagent/bufferorch.cpp:1321 sonic-net#3 0x55ca1e2a9cd4 (/usr/bin/orchagent+0xe89cd4) Direct leak of 48 byte(s) in 1 object(s) allocated from: #0 0x7f96aa952d30 in operator new(unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.5+0xead30) sonic-net#1 0x55ca1da6d2da in __static_initialization_and_destruction_0 /__w/2/s/orchagent/qosorch.cpp:80 sonic-net#2 0x55ca1da6ecf2 in _GLOBAL__sub_I_qosorch.cpp /__w/2/s/orchagent/qosorch.cpp:2000 sonic-net#3 0x55ca1e2a9cd4 (/usr/bin/orchagent+0xe89cd4) - What I did Added an lsan suppression config with static variable leak suppression - Why I did it To suppress ASAN false positives - How I verified it Run a test that produces the static variable leaks report and checked that report has these leaks suppressed. Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>

)

**What I did** Fix the Mem Leak by moving the raw pointers in type_maps to use smart pointers **Why I did it** ``` Indirect leak of 83776 byte(s) in 476 object(s) allocated from: #0 0x7f0a2a414647 in operator new(unsigned long) ../../../../src/libsanitizer/asan/asan_new_delete.cpp:99 #1 0x5555590cc923 in __gnu_cxx::new_allocator, std::allocator > const, referenced_object> > >::allocate(unsigned long, void const*) /usr/include/c++/10/ext/new_allocator.h:115 #2 0x5555590cc923 in std::allocator_traits, std::allocator > const, referenced_object> > > >::allocate(std::allocator, std::allocator > const, referenced_object> > >&, unsigned long) /usr/include/c++/10/bits/alloc_traits.h:460 #3 0x5555590cc923 in std::_Rb_tree, std::allocator >, std::pair, std::allocator > const, referenced_object>, std::_Select1st, std::allocator > const, referenced_object> >, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::_M_get_node() /usr/include/c++/10/bits/stl_tree.h:584 #4 0x5555590cc923 in std::_Rb_tree_node, std::allocator > const, referenced_object> >* std::_Rb_tree, std::allocator >, std::pair, std::allocator > const, referenced_object>, std::_Select1st, std::allocator > const, referenced_object> >, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::_M_create_node, std::allocator > const&>, std::tuple<> >(std::piecewise_construct_t const&, std::tuple, std::allocator > const&>&&, std::tuple<>&&) /usr/include/c++/10/bits/stl_tree.h:634 #5 0x5555590cc923 in std::_Rb_tree_iterator, std::allocator > const, referenced_object> > std::_Rb_tree, std::allocator >, std::pair, std::allocator > const, referenced_object>, std::_Select1st, std::allocator > const, referenced_object> >, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::_M_emplace_hint_unique, std::allocator > const&>, std::tuple<> >(std::_Rb_tree_const_iterator, std::allocator > const, referenced_object> >, std::piecewise_construct_t const&, std::tuple, std::allocator > const&>&&, std::tuple<>&&) /usr/include/c++/10/bits/stl_tree.h:2461 #6 0x5555590e8757 in std::map, std::allocator >, referenced_object, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::operator[](std::__cxx11::basic_string, std::allocator > const&) /usr/include/c++/10/bits/stl_map.h:501 #7 0x5555590d48b0 in Orch::setObjectReference(std::map, std::allocator >, std::map, std::allocator >, referenced_object, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >*, std::less, std::allocator > >, std::allocator, std::allocator > const, std::map, std::allocator >, referenced_object, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >*> > >&, std::__cxx11::basic_string, std::allocator > const&, std::__cxx11::basic_string, std::allocator > const&, std::__cxx11::basic_string, std::allocator > const&, std::__cxx11::basic_string, std::allocator > const&) orchagent/orch.cpp:450 #8 0x5555594ff66b in QosOrch::handleQueueTable(Consumer&, std::tuple, std::allocator >, std::__cxx11::basic_string, std::allocator >, std::vector, std::allocator >, std::__cxx11::basic_string, std::allocator > >, std::allocator, std::allocator >, std::__cxx11::basic_string, std::allocator > > > > >&) orchagent/qosorch.cpp:1763 #9 0x5555594edbd6 in QosOrch::doTask(Consumer&) orchagent/qosorch.cpp:2179 #10 0x5555590c8743 in Consumer::drain() orchagent/orch.cpp:241 #11 0x5555590c8743 in Consumer::drain() orchagent/orch.cpp:238 #12 0x5555590c8743 in Consumer::execute() orchagent/orch.cpp:235 #13 0x555559090dad in OrchDaemon::start() orchagent/orchdaemon.cpp:755 #14 0x555558e9be25 in main orchagent/main.cpp:766 #15 0x7f0a299b6d09 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x23d09) ```

Elad Raz added 2 commits March 16, 2016 10:42

common: select: Adding remove selectable option

7f9f4fb

Adding support of removeSelectable() API. This API can be invoked in any condition, including from readMe() API. Signed-off-by: Elad Raz <eladr@mellanox.com>

stcheng force-pushed the master branch from d2864a6 to 2b6997c Compare April 4, 2016 21:47

kcudnik reviewed Apr 20, 2016
View reviewed changes

stcheng closed this May 18, 2016

lguohan mentioned this pull request Apr 14, 2017

#1 AclOrch::collectCountersThread (pAclOrch=0x1614da0) at aclorch.cpp:1279 #190

Closed

pavel-shirshov mentioned this pull request Apr 30, 2017

GPF in orchagent. ACL counters related code #201

Closed

jipanyang mentioned this pull request Oct 13, 2017

orchagent hangs at switchorch due to erase operation on map #347

Closed

marian-pritsak pushed a commit to marian-pritsak/sonic-swss that referenced this pull request Jun 22, 2018

Merge pull request sonic-net#3 from YonatanPitz/sonic_bm_tor_cli

c1096da

Add toggles for cache thresholds

vharish02 pushed a commit to vharish02/sonic-swss that referenced this pull request Aug 6, 2018

Merge pull request sonic-net#3 from tombo315/gh-pages

37b4865

Adding Documentation Signed-off-by: John Arnold johnar@microsoft.com

ishidawataru pushed a commit to ishidawataru/sonic-swss that referenced this pull request Aug 29, 2018

Merge pull request sonic-net#3 from qiluo-msft/qiluo/redisarg

497bdfe

DBInterface supports redis connection options

vemulabalaji mentioned this pull request Nov 21, 2018

syslog message with invalid subnetmask #701

Open

vasant17 mentioned this pull request May 14, 2020

[DPB/VLAN] Add test VS cases and fix FDB flush issues #1242

Merged

garigipati mentioned this pull request May 22, 2020

Applying the same Vnet's twice causes orchagent crash #1298

Closed

rupesh-k mentioned this pull request Jul 2, 2020

Fix in script to avoid orchagent crash when port down followed by fdb… #1340

Merged

rajkumar38 mentioned this pull request Jul 29, 2020

[fdborch] Fixed Orchagent crash in FDB flush on port disable. #1369

Merged

kktheballer pushed a commit to kktheballer/sonic-swss that referenced this pull request Jan 23, 2021

Fgnhg link handling 201911 (sonic-net#3)

029298e

* Add fgnhg link handling changes for 201911 * Improve tests to include link handling, fix compilation issue after rebase

dgsudharsan referenced this pull request in dgsudharsan/sonic-swss Jun 10, 2021

Changes #3

fe36ee8

kktheballer pushed a commit to kktheballer/sonic-swss that referenced this pull request Jul 20, 2021

Fgnhg link handling 201911 (sonic-net#3)

090e15b

* Add fgnhg link handling changes for 201911 * Improve tests to include link handling, fix compilation issue after rebase

EdenGri referenced this pull request in EdenGri/sonic-swss Feb 28, 2022

Integrate generate_dump utility (#3)

033a58c

skbarista mentioned this pull request Nov 29, 2022

sonic-swss: Fix orchagent crash in generateQueueMapPerPort. #2552

Merged

jcaiMR mentioned this pull request Jan 30, 2023

[Workaround] EvpnRemoteVnip2pOrch warmboot check failure #2626

Merged

lukasstockner pushed a commit to genesiscloud/sonic-swss that referenced this pull request Apr 2, 2023

[bcmshell.py] Match extra whitespace before prompt in regex (sonic-net#3

560b465

)

vmittal-msft added a commit to vmittal-msft/sonic-swss that referenced this pull request Nov 22, 2023

Fix for VS tests sonic-net#3

22e3457

vmittal-msft added a commit to vmittal-msft/sonic-swss that referenced this pull request Nov 22, 2023

Fix for VS tests sonic-net#3

4d74792

vmittal-msft added a commit to vmittal-msft/sonic-swss that referenced this pull request Nov 22, 2023

Fix for VS tests sonic-net#3

93c6ee9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PATCH v2]: teamsyncd #3

[PATCH v2]: teamsyncd #3

eladraz commented Mar 16, 2016

kcudnik Apr 20, 2016

lguohan commented May 10, 2016

stcheng commented May 18, 2016

[PATCH v2]: teamsyncd #3

[PATCH v2]: teamsyncd #3

Conversation

eladraz commented Mar 16, 2016

kcudnik Apr 20, 2016

Choose a reason for hiding this comment

lguohan commented May 10, 2016

stcheng commented May 18, 2016