Add field methods to Table class #5

stcheng · 2016-03-18T00:29:38Z

No description provided.

stcheng · 2016-03-18T00:30:15Z

common/table.cpp

@@ -83,6 +83,61 @@ void Table::del(std::string key, std::string /* op */)
                           "DEL operation failed");
 }

+std::string Table::getField(std::string key, std::string field)


This function will be combined with tryGetField.

stcheng · 2016-03-18T21:20:58Z

common/table.cpp

@@ -83,6 +83,48 @@ void Table::del(std::string key, std::string /* op */)
                           "DEL operation failed");
 }

+bool Table::getField(std::string key, std::string field, std::string &value)
+{
+    redisReply *reply = (redisReply*)redisCommand(


Is it better to use RedisReply class to do the staffs? Similar to the previous Table::get function

stcheng · 2016-03-22T17:31:13Z

Acked-by: Shuotian Cheng shuche@microsoft.com

Signed-off-by: Kamil Cudnik <kcudnik@microsoft.com>

Sonic bm tor cli

* DPB test case * Update test case * Remove pdb statements * DPB test cases phase1 * DPB test cases phase1 updated * Addressed code-review comments by Xu

* Implement initial reinit logic and update logging * Fix sairedis logging * Use other db connection for notifications * Syncd get log level from redis * Build dummy port map * Add RedisClient class * Fix serialize bug for route and neighbor

@runtime

* initial barefoot checkin october 2017 * Revert "Merge branch 'master' of https://github.com/Azure/sonic-sairedis into rel_6_0" This reverts commit c48a7a20de2fb9e615535481f8727029440413bc, reversing changes made to aa5bf640db7b7fca245c1669eeb02198a50cb5c1. * missed integration diffs * Added new attr type support to sairedis. Also, some fixes for compilation issues * Changes to add new DTel api support in sairedis * Add new file to generate Dtel specific SAI stub API * Missed adding a file in the last commit * Fix ref point for SAI * Updated SAI repo to point to dtel_exp * Changes to handle new additions to DTel experimental SAI. Not compiled yet * handle platform specific lins in different directory (@runtime) * force order of library path to look for platform dir before lib dir * Change SAI branch refpoint * Update SAI submodule refpoint * enable fast-boot for barefoot platforms * Update ref point for SAI * SONiC changes due to DTel experimental SAI changes * allow Makefile to build for other platforms - restore it original for non-bfn platforms * allow clean build * Revert "allow clean build" This reverts commit adfdb8642fe0b5dbb4e19d13871172a03a8c883b. * Revert "allow Makefile to build for other platforms - restore it original for non-bfn platforms" This reverts commit d6b0ca34fcf63d0b79c801cd95d7ee2fe58d21ac. * makefile cleanup towards upstream * Support for platforms based on Barefoot Networks' device (sonic-net#304) * search for exact string - newer onie versions match multiple lines * Will need to revert this Should work without this change. Untested for now * SONiC sairedis changes needed to work with SAIv1.3 * Fix SAI path in gitmodules and add a comment * Remove sai thrift build hack * enable fast-boot for barefoot platforms * enable fast-boot for barefoot platforms * Add missing sai rpc hdr file path for bfn * Update SAI ref points * Multi p4 profile support for bfn sde (#5) * Remove code duplicated in merge * Keep fn in same order as azure master (sonic-net#8) * Address review comment * Link just bfn sai lib and shorten linking command by removing other libraries linked at compile time (#6) * Link only bfn sai lib * all unresolved symbols resolved at runtime * Preload some bfn libraries on syncd startup * Build fix * also remove commented code * Convert tabs to spaces * Fix alignment * Address upstream comment * BFN: link with just sai library for saisdkdump * Address review comments

… 3 (sonic-net#5)

**What I did** Fix the Mem Leak by moving the raw pointers in type_maps to use smart pointers **Why I did it** ``` Indirect leak of 83776 byte(s) in 476 object(s) allocated from: #0 0x7f0a2a414647 in operator new(unsigned long) ../../../../src/libsanitizer/asan/asan_new_delete.cpp:99 #1 0x5555590cc923 in __gnu_cxx::new_allocator, std::allocator > const, referenced_object> > >::allocate(unsigned long, void const*) /usr/include/c++/10/ext/new_allocator.h:115 #2 0x5555590cc923 in std::allocator_traits, std::allocator > const, referenced_object> > > >::allocate(std::allocator, std::allocator > const, referenced_object> > >&, unsigned long) /usr/include/c++/10/bits/alloc_traits.h:460 #3 0x5555590cc923 in std::_Rb_tree, std::allocator >, std::pair, std::allocator > const, referenced_object>, std::_Select1st, std::allocator > const, referenced_object> >, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::_M_get_node() /usr/include/c++/10/bits/stl_tree.h:584 #4 0x5555590cc923 in std::_Rb_tree_node, std::allocator > const, referenced_object> >* std::_Rb_tree, std::allocator >, std::pair, std::allocator > const, referenced_object>, std::_Select1st, std::allocator > const, referenced_object> >, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::_M_create_node, std::allocator > const&>, std::tuple<> >(std::piecewise_construct_t const&, std::tuple, std::allocator > const&>&&, std::tuple<>&&) /usr/include/c++/10/bits/stl_tree.h:634 #5 0x5555590cc923 in std::_Rb_tree_iterator, std::allocator > const, referenced_object> > std::_Rb_tree, std::allocator >, std::pair, std::allocator > const, referenced_object>, std::_Select1st, std::allocator > const, referenced_object> >, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::_M_emplace_hint_unique, std::allocator > const&>, std::tuple<> >(std::_Rb_tree_const_iterator, std::allocator > const, referenced_object> >, std::piecewise_construct_t const&, std::tuple, std::allocator > const&>&&, std::tuple<>&&) /usr/include/c++/10/bits/stl_tree.h:2461 #6 0x5555590e8757 in std::map, std::allocator >, referenced_object, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >::operator[](std::__cxx11::basic_string, std::allocator > const&) /usr/include/c++/10/bits/stl_map.h:501 #7 0x5555590d48b0 in Orch::setObjectReference(std::map, std::allocator >, std::map, std::allocator >, referenced_object, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >*, std::less, std::allocator > >, std::allocator, std::allocator > const, std::map, std::allocator >, referenced_object, std::less, std::allocator > >, std::allocator, std::allocator > const, referenced_object> > >*> > >&, std::__cxx11::basic_string, std::allocator > const&, std::__cxx11::basic_string, std::allocator > const&, std::__cxx11::basic_string, std::allocator > const&, std::__cxx11::basic_string, std::allocator > const&) orchagent/orch.cpp:450 #8 0x5555594ff66b in QosOrch::handleQueueTable(Consumer&, std::tuple, std::allocator >, std::__cxx11::basic_string, std::allocator >, std::vector, std::allocator >, std::__cxx11::basic_string, std::allocator > >, std::allocator, std::allocator >, std::__cxx11::basic_string, std::allocator > > > > >&) orchagent/qosorch.cpp:1763 #9 0x5555594edbd6 in QosOrch::doTask(Consumer&) orchagent/qosorch.cpp:2179 #10 0x5555590c8743 in Consumer::drain() orchagent/orch.cpp:241 #11 0x5555590c8743 in Consumer::drain() orchagent/orch.cpp:238 #12 0x5555590c8743 in Consumer::execute() orchagent/orch.cpp:235 #13 0x555559090dad in OrchDaemon::start() orchagent/orchdaemon.cpp:755 #14 0x555558e9be25 in main orchagent/main.cpp:766 #15 0x7f0a299b6d09 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x23d09) ```

stcheng reviewed Mar 18, 2016
View reviewed changes

kcudnik force-pushed the master branch from 2953876 to fc25608 Compare March 18, 2016 18:00

stcheng reviewed Mar 18, 2016
View reviewed changes

kcudnik force-pushed the master branch from fc25608 to cfd1439 Compare March 21, 2016 23:57

common: Add field methods to Table class

1ed0be7

Signed-off-by: Kamil Cudnik <kcudnik@microsoft.com>

kcudnik force-pushed the master branch from cfd1439 to 1ed0be7 Compare March 22, 2016 21:20

kcudnik merged commit 1ed0be7 into sonic-net:master Mar 22, 2016

jipanyang mentioned this pull request Oct 13, 2017

orchagent hangs at switchorch due to erase operation on map #347

Closed

marian-pritsak pushed a commit to marian-pritsak/sonic-swss that referenced this pull request Feb 14, 2018

Directed broadcast changes with testcase (sonic-net#5)

9df9722

marian-pritsak pushed a commit to marian-pritsak/sonic-swss that referenced this pull request Jun 22, 2018

Merge pull request sonic-net#5 from YonatanPitz/sonic_bm_tor_cli

ea8315d

Sonic bm tor cli

vasant17 added a commit to vasant17/sonic-swss that referenced this pull request Oct 31, 2019

DPB test case (sonic-net#5)

35d85ee

* DPB test case * Update test case * Remove pdb statements * DPB test cases phase1 * DPB test cases phase1 updated * Addressed code-review comments by Xu

vasant17 added a commit to vasant17/sonic-swss that referenced this pull request Nov 8, 2019

DPB test case (sonic-net#5)

2f2efeb

* DPB test case * Update test case * Remove pdb statements * DPB test cases phase1 * DPB test cases phase1 updated * Addressed code-review comments by Xu

garigipati mentioned this pull request May 22, 2020

Applying the same Vnet's twice causes orchagent crash #1298

Closed

rupesh-k mentioned this pull request Jul 2, 2020

Fix in script to avoid orchagent crash when port down followed by fdb… #1340

Merged

rajkumar38 mentioned this pull request Jul 29, 2020

[fdborch] Fixed Orchagent crash in FDB flush on port disable. #1369

Merged

dgsudharsan referenced this pull request in dgsudharsan/sonic-swss Jun 15, 2021

Changes #5 Fixing compilation

5db32ee

skbarista mentioned this pull request Nov 29, 2022

sonic-swss: Fix orchagent crash in generateQueueMapPerPort. #2552

Merged

jcaiMR mentioned this pull request Jan 30, 2023

[Workaround] EvpnRemoteVnip2pOrch warmboot check failure #2626

Merged

lukasstockner pushed a commit to genesiscloud/sonic-swss that referenced this pull request Apr 2, 2023

Make all 'except' statements compatible with both Python 2 and Python…

ba614d3

… 3 (sonic-net#5)

maulik-marvell mentioned this pull request Jul 21, 2023

[swss] BUFFER_PG and BUFFER_QUEUE configs are not getting applied on new ports created from dynamic breakout #2865

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add field methods to Table class #5

Add field methods to Table class #5

stcheng commented Mar 18, 2016

stcheng Mar 18, 2016

stcheng Mar 18, 2016

stcheng commented Mar 22, 2016

Add field methods to Table class #5

Add field methods to Table class #5

Conversation

stcheng commented Mar 18, 2016

stcheng Mar 18, 2016

Choose a reason for hiding this comment

stcheng Mar 18, 2016

Choose a reason for hiding this comment

stcheng commented Mar 22, 2016