Improve the way to check port type of RJ45 port #2249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Present/Not present => Link Up/Link Down Use the new platform API to test whether the port is an RJ45 port Signed-off-by: Stephen Sun <stephens@nvidia.com>
…esent status accordingly Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
…util Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: stephens <stephens@contoso.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: stephens <stephens@contoso.com>
stephenxs
requested review from
prgeor and
keboliu
and removed request for
prgeor
|
This pull request introduces 3 alerts when merging b30ab63 into 7070794 - view on LGTM.com new alerts:
|
|
PR checker failed because the depending PR has not been in. |
Signed-off-by: Stephen Sun <stephens@nvidia.com>
|
This pull request introduces 3 alerts when merging 5fa3e79 into 7070794 - view on LGTM.com new alerts:
|
…sence Signed-off-by: Stephen Sun <stephens@nvidia.com>
|
This pull request introduces 3 alerts when merging a3f6ee7 into c7389bd - view on LGTM.com new alerts:
|
Signed-off-by: Stephen Sun <stephens@nvidia.com>
|
This pull request introduces 3 alerts when merging edc5116 into 3600639 - view on LGTM.com new alerts:
|
Signed-off-by: Stephen Sun <stephens@nvidia.com>
|
This pull request introduces 3 alerts when merging 6369527 into df54138 - view on LGTM.com new alerts:
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
keboliu
previously approved these changes
Jul 14, 2022
prgeor
requested changes
Jul 21, 2022
Signed-off-by: Stephen Sun <stephens@nvidia.com>
prgeor
approved these changes
Jul 23, 2022
|
@stephenxs can you test this change on a platform having non-RJ45 ports? sfputil, intfutil and sfpshow command? |
Yes, I tested it. I will provide the results next Wednesday. |
Hi @prgeor This is the test results of a platform without RJ45 ports. show interface status show interfaces transceiver presence show interfaces transceiver lpmode sfpshow presence sfpshow eeprom sudo sfputil show presence sudo sfputil show eeprom |
|
@stephenxs can you add the result of "sfputil show eeprom -d" |
Hi @prgeor sfputil show eeprom -d |
keboliu
approved these changes
Jul 28, 2022
keboliu
pushed a commit
to keboliu/sonic-utilities
that referenced
this pull request
Aug 1, 2022
* Update the presence state of RJ45 port Present/Not present => Link Up/Link Down Use the new platform API to test whether the port is an RJ45 port Signed-off-by: Stephen Sun <stephens@nvidia.com> * Use new platform API to check whether a port is RJ45 and represent present status accordingly Signed-off-by: Stephen Sun <stephens@nvidia.com> * Adjust sfputil and testcases Signed-off-by: Stephen Sun <stephens@nvidia.com> * Adjust sfpshow Signed-off-by: Stephen Sun <stephens@nvidia.com> * Exact is_rj45_port to a common module shared between sfpshow and intfutil Signed-off-by: Stephen Sun <stephens@nvidia.com> * Fall back to old way for checking RJ45 port Signed-off-by: Stephen Sun <stephens@nvidia.com> * Move RJ45 part to platform_sfputil_helper Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove fallback mechanism in is_rj45_port Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove get_child_ports which is not used Signed-off-by: Stephen Sun <stephens@nvidia.com> * Temporarily commit Signed-off-by: Stephen Sun <stephens@nvidia.com> * Update unit test Signed-off-by: stephens <stephens@contoso.com> * Adjust unit test Signed-off-by: Stephen Sun <stephens@nvidia.com> * Commit missed files Signed-off-by: Stephen Sun <stephens@nvidia.com> * Add missing files Signed-off-by: stephens <stephens@contoso.com> * Fix typo Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove code that was committed by mistake. Signed-off-by: Stephen Sun <stephens@nvidia.com> * Fix an issue: the ports should be in nature order in sfputil show presence Signed-off-by: Stephen Sun <stephens@nvidia.com> * Fix present state for RJ45: Link Up/Down => Port Up/Down Signed-off-by: Stephen Sun <stephens@nvidia.com> * LGTM warning supression Signed-off-by: Stephen Sun <stephens@nvidia.com> * LGTM warning supression Signed-off-by: Stephen Sun <stephens@nvidia.com> * Move present state part into another PR Signed-off-by: Stephen Sun <stephens@nvidia.com> * Fix review comments Signed-off-by: Stephen Sun <stephens@nvidia.com> Co-authored-by: stephens <stephens@contoso.com> Conflicts: scripts/intfutil scripts/sfpshow sfputil/main.py tests/mock_platform_sfputil/mock_platform_sfputil.py tests/sfputil_test.py
This was referenced Aug 6, 2022
|
@stephenxs this change cannot be cherry-picked to 202205 cleanly, can you create separate PR? |
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Aug 9, 2022
Update sonic-utilities submodule pointer to include the following: * Fix GCU bug when backend service modifying config ([sonic-net#2295](sonic-net/sonic-utilities#2295)) * Fix issues for sonic_installer upgrade-docker and sonic_installer rollback-docker ([sonic-net#2278](sonic-net/sonic-utilities#2278)) * [crm] add checking for CRM interval range ([sonic-net#2293](sonic-net/sonic-utilities#2293)) * Fix the issue that sonic_platform is not installed on vs image ([sonic-net#2300](sonic-net/sonic-utilities#2300)) * Add FEC correctable and uncorrectable port stats ([sonic-net#2027](sonic-net/sonic-utilities#2027)) * Add CLI to configure YANG config validation ([sonic-net#2147](sonic-net/sonic-utilities#2147)) * Add override testcase to verify removal ([sonic-net#2288](sonic-net/sonic-utilities#2288)) * Fix version in db_migrator for ([sonic-net#2289](sonic-net/sonic-utilities#2289)) * [intfutil] Check whether the FEC mode is supported on the platform before configuring it to CONFIG_DB ([sonic-net#2223](sonic-net/sonic-utilities#2223)) * Transfer organization from Azure to sonic-net ([sonic-net#2284](sonic-net/sonic-utilities#2284)) * [watermarkstat] Fix CLI script for unconfigured PG counters ([sonic-net#2239](sonic-net/sonic-utilities#2239)) * Improve the way to check port type of RJ45 port ([sonic-net#2249](sonic-net/sonic-utilities#2249)) Signed-off-by: dprital <drorp@nvidia.com>
7 tasks
yxieca
pushed a commit
that referenced
this pull request
Aug 11, 2022
* Update the presence state of RJ45 port Present/Not present => Link Up/Link Down Use the new platform API to test whether the port is an RJ45 port Signed-off-by: Stephen Sun <stephens@nvidia.com> * Use new platform API to check whether a port is RJ45 and represent present status accordingly Signed-off-by: Stephen Sun <stephens@nvidia.com> * Adjust sfputil and testcases Signed-off-by: Stephen Sun <stephens@nvidia.com> * Adjust sfpshow Signed-off-by: Stephen Sun <stephens@nvidia.com> * Exact is_rj45_port to a common module shared between sfpshow and intfutil Signed-off-by: Stephen Sun <stephens@nvidia.com> * Fall back to old way for checking RJ45 port Signed-off-by: Stephen Sun <stephens@nvidia.com> * Move RJ45 part to platform_sfputil_helper Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove fallback mechanism in is_rj45_port Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove get_child_ports which is not used Signed-off-by: Stephen Sun <stephens@nvidia.com> * Temporarily commit Signed-off-by: Stephen Sun <stephens@nvidia.com> * Update unit test Signed-off-by: stephens <stephens@contoso.com> * Adjust unit test Signed-off-by: Stephen Sun <stephens@nvidia.com> * Commit missed files Signed-off-by: Stephen Sun <stephens@nvidia.com> * Add missing files Signed-off-by: stephens <stephens@contoso.com> * Fix typo Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove code that was committed by mistake. Signed-off-by: Stephen Sun <stephens@nvidia.com> * Fix an issue: the ports should be in nature order in sfputil show presence Signed-off-by: Stephen Sun <stephens@nvidia.com> * Fix present state for RJ45: Link Up/Down => Port Up/Down Signed-off-by: Stephen Sun <stephens@nvidia.com> * LGTM warning supression Signed-off-by: Stephen Sun <stephens@nvidia.com> * LGTM warning supression Signed-off-by: Stephen Sun <stephens@nvidia.com> * Move present state part into another PR Signed-off-by: Stephen Sun <stephens@nvidia.com> * Fix review comments Signed-off-by: Stephen Sun <stephens@nvidia.com> Co-authored-by: stephens <stephens@contoso.com>
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Aug 12, 2022
Update sonic-utilities submodule pointer to include the following: * Fix test failure in dump table test in 202205 ([sonic-net#2307](sonic-net/sonic-utilities#2307)) * Convert IPv6 addresses to lowercase in apply-patch ([sonic-net#2299](sonic-net/sonic-utilities#2299)) * [config][muxcable] add support to enable/disable ycable telemetry ([sonic-net#2297](sonic-net/sonic-utilities#2297)) * Fix GCU bug when backend service modifying config ([sonic-net#2295](sonic-net/sonic-utilities#2295)) * [intfutil] Check whether the FEC mode is supported on the platform before configuring it to CONFIG_DB ([sonic-net#2223](sonic-net/sonic-utilities#2223)) * Improve the way to check port type of RJ45 port ([sonic-net#2249](sonic-net/sonic-utilities#2249)) * sonic-utils: initial support for link-training ([sonic-net#2071](sonic-net/sonic-utilities#2071)) * Support to enable fips for the command sonic_installer (sonic-net#2154) ([sonic-net#2303](sonic-net/sonic-utilities#2303)) Signed-off-by: dprital <drorp@nvidia.com>
7 tasks
yxieca
added a commit
that referenced
this pull request
Aug 13, 2022
…"" This reverts commit 0df3ba8.
preetham-singh
pushed a commit
to preetham-singh/sonic-utilities
that referenced
this pull request
Nov 21, 2022
* Update the presence state of RJ45 port Present/Not present => Link Up/Link Down Use the new platform API to test whether the port is an RJ45 port Signed-off-by: Stephen Sun <stephens@nvidia.com> * Use new platform API to check whether a port is RJ45 and represent present status accordingly Signed-off-by: Stephen Sun <stephens@nvidia.com> * Adjust sfputil and testcases Signed-off-by: Stephen Sun <stephens@nvidia.com> * Adjust sfpshow Signed-off-by: Stephen Sun <stephens@nvidia.com> * Exact is_rj45_port to a common module shared between sfpshow and intfutil Signed-off-by: Stephen Sun <stephens@nvidia.com> * Fall back to old way for checking RJ45 port Signed-off-by: Stephen Sun <stephens@nvidia.com> * Move RJ45 part to platform_sfputil_helper Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove fallback mechanism in is_rj45_port Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove get_child_ports which is not used Signed-off-by: Stephen Sun <stephens@nvidia.com> * Temporarily commit Signed-off-by: Stephen Sun <stephens@nvidia.com> * Update unit test Signed-off-by: stephens <stephens@contoso.com> * Adjust unit test Signed-off-by: Stephen Sun <stephens@nvidia.com> * Commit missed files Signed-off-by: Stephen Sun <stephens@nvidia.com> * Add missing files Signed-off-by: stephens <stephens@contoso.com> * Fix typo Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove code that was committed by mistake. Signed-off-by: Stephen Sun <stephens@nvidia.com> * Fix an issue: the ports should be in nature order in sfputil show presence Signed-off-by: Stephen Sun <stephens@nvidia.com> * Fix present state for RJ45: Link Up/Down => Port Up/Down Signed-off-by: Stephen Sun <stephens@nvidia.com> * LGTM warning supression Signed-off-by: Stephen Sun <stephens@nvidia.com> * LGTM warning supression Signed-off-by: Stephen Sun <stephens@nvidia.com> * Move present state part into another PR Signed-off-by: Stephen Sun <stephens@nvidia.com> * Fix review comments Signed-off-by: Stephen Sun <stephens@nvidia.com> Co-authored-by: stephens <stephens@contoso.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new platform API to check whether a port is RJ45 when it is absent
Depends on sonic-net/sonic-platform-common#288, and sonic-net/sonic-buildimage#11401
Signed-off-by: Stephen Sun stephens@nvidia.com
What I did
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)