Transceiver eeprom dom CLI modification to show output from TRANSCEIVER_DOM_THRESHOLD table #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihir Patel <patelmi@microsoft.com>
Signed-off-by: Mihir Patel <patelmi@microsoft.com>
mihirpat1
changed the title
shyam77git
reviewed
Dec 5, 2022
| @@ -391,6 +391,7 @@ class SFPShow(object): | |||
| if dump_dom: | |||
| sfp_type = sfp_info_dict['type'] | |||
| dom_info_dict = state_db.get_all(state_db.STATE_DB, 'TRANSCEIVER_DOM_SENSOR|{}'.format(interface_name)) | |||
| dom_info_dict.update(state_db.get_all(state_db.STATE_DB, 'TRANSCEIVER_DOM_THRESHOLD|{}'.format(interface_name))) | |||
There was a problem hiding this comment.
@mihirpat1 : Please validate, add UT outcome of following CLIs:
specific port (optics EEPROM/DOM)
- show int trans eeprom Ethernet<> -n asic<>
- show int trans eeprom --dom Ethernet<> -n asic<>
all ports where optics inserted in LC/Fixed-chassis
3) show int trans eeprom
4)show int trans eeprom --dom
There was a problem hiding this comment.
I have now added the multi asic UT enclosure to sonic-net/sonic-platform-daemons#320.
https://github.com/sonic-net/sonic-platform-daemons/files/10157449/Unit-test_400ZR_Multiasic.txt
shyam77git
reviewed
Dec 5, 2022
shyam77git
approved these changes
Dec 5, 2022
|
@mihirpat1 if no change can you specify that in these section: New command output (if the output of a command-line utility has changed) |
prgeor
approved these changes
Dec 5, 2022
I have updated the PR description now with the above info. |
preetham-singh
pushed a commit
to preetham-singh/sonic-utilities
that referenced
this pull request
Dec 6, 2022
…ER_DOM_THRESHOLD table (sonic-net#2535) * EEPROM CLI support to dump output from TRANSCEIVER_DOM_THRESHOLD table Signed-off-by: Mihir Patel <patelmi@microsoft.com> * Resolved test failures Signed-off-by: Mihir Patel <patelmi@microsoft.com> Signed-off-by: Mihir Patel <patelmi@microsoft.com>
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Dec 6, 2022
Update sonic-utilities submodule pointer to include the following: * ca9a020 [generate_dump] [Mellanox] Fix the duplicate dfw dump collection problem by adding symlinks ([sonic-net#2536](sonic-net/sonic-utilities#2536)) * 92c7001 [config] Add check in config interface ip command to block if the interface is portchannel member ([sonic-net#2539](sonic-net/sonic-utilities#2539)) * e8130f5 [system-health] Improve code structure of system health CLIs ([sonic-net#2453](sonic-net/sonic-utilities#2453)) * 00c01b3 Transceiver eeprom dom CLI modification to show output from TRANSCEIVER_DOM_THRESHOLD table ([sonic-net#2535](sonic-net/sonic-utilities#2535)) * 42f51c2 sonic-utilities: Update config reload() to verify formatting of an input file ([sonic-net#2529](sonic-net/sonic-utilities#2529)) * a5e1e2b [GCU] Add RemoveCreateOnlyDependency Validator/Generator ([sonic-net#2500](sonic-net/sonic-utilities#2500)) * 6411b52 [QoS] Introduce delay to the qos reload flow ([sonic-net#2503](sonic-net/sonic-utilities#2503)) * fce7ec3 Use github code scanning instead of LGTM ([sonic-net#2530](sonic-net/sonic-utilities#2530)) * 91bd6de Change show kube command default value of insecure key to True ([sonic-net#2517](sonic-net/sonic-utilities#2517)) * c44c584 Add db_migrator_constants.py script to setup.py ([sonic-net#2534](sonic-net/sonic-utilities#2534)) * 6a3238e [drop counters] Fix CLI script for unconfigured PGs ([sonic-net#2518](sonic-net/sonic-utilities#2518)) * 263810b Update vrf add, del commands for duplicate/non-existing VRFs ([sonic-net#2467](sonic-net/sonic-utilities#2467)) * addae73 Port 202012 DB migration changes to newer branches ([sonic-net#2515](sonic-net/sonic-utilities#2515)) * 2af8cfa [VXLAN]Fixing traceback in show remotemac when mac moves during command execution ([sonic-net#2506](sonic-net/sonic-utilities#2506)) Signed-off-by: dprital <drorp@nvidia.com>
8 tasks
StormLiangMS
pushed a commit
that referenced
this pull request
Dec 30, 2022
…ER_DOM_THRESHOLD table (#2535) * EEPROM CLI support to dump output from TRANSCEIVER_DOM_THRESHOLD table Signed-off-by: Mihir Patel <patelmi@microsoft.com> * Resolved test failures Signed-off-by: Mihir Patel <patelmi@microsoft.com> Signed-off-by: Mihir Patel <patelmi@microsoft.com>
yxieca
pushed a commit
that referenced
this pull request
Jan 19, 2023
…ER_DOM_THRESHOLD table (#2535) * EEPROM CLI support to dump output from TRANSCEIVER_DOM_THRESHOLD table Signed-off-by: Mihir Patel <patelmi@microsoft.com> * Resolved test failures Signed-off-by: Mihir Patel <patelmi@microsoft.com> Signed-off-by: Mihir Patel <patelmi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This PR is needed along with sonic-net/sonic-platform-daemons#320 to continue supporting "show interface transceiver eeprom <port> -d" CLI since PR#320 is separating DOM threshold related information in a separate table entry (TRANSCEIVER_DOM_THRESHOLD from TRANSCEIVER_DOM_SENSOR) in state DB.
The change with this PR will ensure that the CLI output remains unchanged until sonic-net/sonic-buildimage#12911 is committed which will all together publish DOM threshold related information in a new CLI.
How I did it
dom_info_dict is now populated using information from both TRANSCEIVER_DOM_SENSOR as well as TRANSCEIVER_DOM_THRESHOLD.
How to verify it
Please refer to the enclosure attached to sonic-net/sonic-platform-daemons#320
Previous command output (if the output of a command-line utility has changed)
Overall, the "show interface transceiver eeprom <port> -d" command o/p will remain unchanged with this commit. The current code change is on the back end side where-in DOM threshold data is now being retrieved from TRANSCEIVER_DOM_THRESHOLD table.
New command output (if the output of a command-line utility has changed)
"show interface transceiver eeprom <port> -d" o/p will remain unchanged with this commit.
Signed-off-by: Mihir Patel patelmi@microsoft.com