Skip to content

Commit

Permalink
crash_test: fix incorrect passing of the memtablerep argument (#93)
Browse files Browse the repository at this point in the history
As part of #90, I accidentally added a comma at the end of the
line when choosing the memtable reperesntation to use. This is
a tuple construction syntax and was formatted as such by Black,
but unfortunately missed by me and during review.

Fix it by removing the comma so that the argument isn't passed
to db_stress as a Python tuple.
  • Loading branch information
isaac-io authored and Yuval-Ariel committed Apr 25, 2023
1 parent 892bf2d commit 187e1f8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tools/db_crashtest.py
Original file line number Diff line number Diff line change
Expand Up @@ -618,8 +618,8 @@ def finalize_and_sanitize(src_params, counter):
if dest_params.get("compression_type") != "zstd":
dest_params["compression_zstd_max_train_bytes"] = 0
if dest_params.get("allow_concurrent_memtable_write", 1) == 1:
dest_params["memtablerep"] = (
random.choice(["skip_list", "speedb.HashSpdRepFactory"]),
dest_params["memtablerep"] = random.choice(
["skip_list", "speedb.HashSpdRepFactory"]
)
if dest_params["mmap_read"] == 1:
dest_params["use_direct_io_for_flush_and_compaction"] = 0
Expand Down

0 comments on commit 187e1f8

Please sign in to comment.