crash_test: add the new memtable as a random choice (#89) #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently only the skip list memtable is being tested. Increase coverage by adding the new Speedb memtable as an option as well. For now we'll simply choose randomly between the two, without giving any one of them preference, but we may want to change that in the future.
|
Note: this can be merged only after #88. |
Yuval-Ariel
approved these changes
Jul 31, 2022
isaac-io
deleted the
89-crash_test-add-the-new-memtable-to-the-parameters-chosen
branch
isaac-io
added a commit
that referenced
this pull request
Aug 1, 2022
As part of #90, I accidentally added a comma at the end of the line when choosing the memtable reperesntation to use. This is a tuple construction syntax and was formatted as such by Black, but unfortunately missed by me and during review. Fix it by removing the comma so that the argument isn't passed to db_stress as a Python tuple.
isaac-io
added a commit
that referenced
this pull request
Aug 1, 2022
As part of #90, I accidentally added a comma at the end of the line when choosing the memtable reperesntation to use. This is a tuple construction syntax and was formatted as such by Black, but unfortunately missed by me and during review. Fix it by removing the comma so that the argument isn't passed to db_stress as a Python tuple.
isaac-io
added a commit
that referenced
this pull request
Oct 19, 2022
As part of #90, I accidentally added a comma at the end of the line when choosing the memtable reperesntation to use. This is a tuple construction syntax and was formatted as such by Black, but unfortunately missed by me and during review. Fix it by removing the comma so that the argument isn't passed to db_stress as a Python tuple.
isaac-io
added a commit
that referenced
this pull request
Oct 19, 2022
As part of #90, I accidentally added a comma at the end of the line when choosing the memtable reperesntation to use. This is a tuple construction syntax and was formatted as such by Black, but unfortunately missed by me and during review. Fix it by removing the comma so that the argument isn't passed to db_stress as a Python tuple.
isaac-io
added a commit
that referenced
this pull request
Oct 19, 2022
As part of #90, I accidentally added a comma at the end of the line when choosing the memtable reperesntation to use. This is a tuple construction syntax and was formatted as such by Black, but unfortunately missed by me and during review. Fix it by removing the comma so that the argument isn't passed to db_stress as a Python tuple.
Yuval-Ariel
pushed a commit
that referenced
this pull request
Nov 23, 2022
As part of #90, I accidentally added a comma at the end of the line when choosing the memtable reperesntation to use. This is a tuple construction syntax and was formatted as such by Black, but unfortunately missed by me and during review. Fix it by removing the comma so that the argument isn't passed to db_stress as a Python tuple.
Yuval-Ariel
pushed a commit
that referenced
this pull request
Nov 25, 2022
As part of #90, I accidentally added a comma at the end of the line when choosing the memtable reperesntation to use. This is a tuple construction syntax and was formatted as such by Black, but unfortunately missed by me and during review. Fix it by removing the comma so that the argument isn't passed to db_stress as a Python tuple.
Yuval-Ariel
pushed a commit
that referenced
this pull request
Apr 30, 2023
As part of #90, I accidentally added a comma at the end of the line when choosing the memtable reperesntation to use. This is a tuple construction syntax and was formatted as such by Black, but unfortunately missed by me and during review. Fix it by removing the comma so that the argument isn't passed to db_stress as a Python tuple.
udi-speedb
pushed a commit
that referenced
this pull request
Oct 31, 2023
As part of #90, I accidentally added a comma at the end of the line when choosing the memtable reperesntation to use. This is a tuple construction syntax and was formatted as such by Black, but unfortunately missed by me and during review. Fix it by removing the comma so that the argument isn't passed to db_stress as a Python tuple.
udi-speedb
pushed a commit
that referenced
this pull request
Dec 1, 2023
As part of #90, I accidentally added a comma at the end of the line when choosing the memtable reperesntation to use. This is a tuple construction syntax and was formatted as such by Black, but unfortunately missed by me and during review. Fix it by removing the comma so that the argument isn't passed to db_stress as a Python tuple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only the skip list memtable is being tested. Increase
coverage by adding the new Speedb memtable as an option as well.
For now we'll simply choose randomly between the two, without
giving any one of them preference, but we may want to change that
in the future.