Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash_test: add the new memtable to the parameters chosen #89

Closed
isaac-io opened this issue Jul 31, 2022 · 0 comments · Fixed by #90
Closed

crash_test: add the new memtable to the parameters chosen #89

isaac-io opened this issue Jul 31, 2022 · 0 comments · Fixed by #90
Assignees
Labels
enhancement New feature or request

Comments

@isaac-io
Copy link
Contributor

Currently only the skip list is being tested as part of the crash tests (whitebox/blackbox). Add the new Speedb memtable to the available choices (for now just randomly choose between the skip list and the Speedb one) in order to cover it as part of the crash tests as well.

@isaac-io isaac-io self-assigned this Jul 31, 2022
@isaac-io isaac-io added the enhancement New feature or request label Jul 31, 2022
isaac-io added a commit that referenced this issue Jul 31, 2022
Currently only the skip list memtable is being tested. Increase
coverage by adding the new Speedb memtable as an option as well.
For now we'll simply choose randomly between the two, without
giving any one of them preference, but we may want to change that
in the future.
@isaac-io isaac-io linked a pull request Jul 31, 2022 that will close this issue
isaac-io added a commit that referenced this issue Jul 31, 2022
Currently only the skip list memtable is being tested. Increase
coverage by adding the new Speedb memtable as an option as well.
For now we'll simply choose randomly between the two, without
giving any one of them preference, but we may want to change that
in the future.
isaac-io added a commit that referenced this issue Aug 1, 2022
…h test

The test seems to fail for now, so in order to avoid headaches for devs
working on `main`, let's not test the new memtable until the issues are
fixed.
isaac-io added a commit that referenced this issue Oct 19, 2022
Currently only the skip list memtable is being tested. Increase
coverage by adding the new Speedb memtable as an option as well.
For now we'll simply choose randomly between the two, without
giving any one of them preference, but we may want to change that
in the future.
isaac-io added a commit that referenced this issue Oct 19, 2022
Currently only the skip list memtable is being tested. Increase
coverage by adding the new Speedb memtable as an option as well.
For now we'll simply choose randomly between the two, without
giving any one of them preference, but we may want to change that
in the future.
isaac-io added a commit that referenced this issue Oct 19, 2022
Currently only the skip list memtable is being tested. Increase
coverage by adding the new Speedb memtable as an option as well.
For now we'll simply choose randomly between the two, without
giving any one of them preference, but we may want to change that
in the future.
Yuval-Ariel pushed a commit that referenced this issue Nov 23, 2022
Currently only the skip list memtable is being tested. Increase
coverage by adding the new Speedb memtable as an option as well.
For now we'll simply choose randomly between the two, without
giving any one of them preference, but we may want to change that
in the future.
Yuval-Ariel pushed a commit that referenced this issue Nov 25, 2022
Currently only the skip list memtable is being tested. Increase
coverage by adding the new Speedb memtable as an option as well.
For now we'll simply choose randomly between the two, without
giving any one of them preference, but we may want to change that
in the future.
Yuval-Ariel pushed a commit that referenced this issue Apr 30, 2023
Currently only the skip list memtable is being tested. Increase
coverage by adding the new Speedb memtable as an option as well.
For now we'll simply choose randomly between the two, without
giving any one of them preference, but we may want to change that
in the future.
udi-speedb pushed a commit that referenced this issue Oct 31, 2023
Currently only the skip list memtable is being tested. Increase
coverage by adding the new Speedb memtable as an option as well.
For now we'll simply choose randomly between the two, without
giving any one of them preference, but we may want to change that
in the future.
udi-speedb pushed a commit that referenced this issue Dec 1, 2023
Currently only the skip list memtable is being tested. Increase
coverage by adding the new Speedb memtable as an option as well.
For now we'll simply choose randomly between the two, without
giving any one of them preference, but we may want to change that
in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant