-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crash_test: memtablerep is incorrectly passed to db_stress #93
Labels
bug
Something isn't working
Comments
isaac-io
added a commit
that referenced
this issue
Aug 1, 2022
As part of #90, I accidentally added a comma at the end of the line when choosing the memtable reperesntation to use. This is a tuple construction syntax and was formatted as such by Black, but unfortunately missed by me and during review. Fix it by removing the comma so that the argument isn't passed to db_stress as a Python tuple.
isaac-io
added a commit
that referenced
this issue
Aug 1, 2022
As part of #90, I accidentally added a comma at the end of the line when choosing the memtable reperesntation to use. This is a tuple construction syntax and was formatted as such by Black, but unfortunately missed by me and during review. Fix it by removing the comma so that the argument isn't passed to db_stress as a Python tuple.
isaac-io
added a commit
that referenced
this issue
Aug 1, 2022
…h test The test seems to fail for now, so in order to avoid headaches for devs working on `main`, let's not test the new memtable until the issues are fixed.
isaac-io
added a commit
that referenced
this issue
Oct 19, 2022
As part of #90, I accidentally added a comma at the end of the line when choosing the memtable reperesntation to use. This is a tuple construction syntax and was formatted as such by Black, but unfortunately missed by me and during review. Fix it by removing the comma so that the argument isn't passed to db_stress as a Python tuple.
isaac-io
added a commit
that referenced
this issue
Oct 19, 2022
As part of #90, I accidentally added a comma at the end of the line when choosing the memtable reperesntation to use. This is a tuple construction syntax and was formatted as such by Black, but unfortunately missed by me and during review. Fix it by removing the comma so that the argument isn't passed to db_stress as a Python tuple.
isaac-io
added a commit
that referenced
this issue
Oct 19, 2022
As part of #90, I accidentally added a comma at the end of the line when choosing the memtable reperesntation to use. This is a tuple construction syntax and was formatted as such by Black, but unfortunately missed by me and during review. Fix it by removing the comma so that the argument isn't passed to db_stress as a Python tuple.
Yuval-Ariel
pushed a commit
that referenced
this issue
Nov 23, 2022
As part of #90, I accidentally added a comma at the end of the line when choosing the memtable reperesntation to use. This is a tuple construction syntax and was formatted as such by Black, but unfortunately missed by me and during review. Fix it by removing the comma so that the argument isn't passed to db_stress as a Python tuple.
Yuval-Ariel
pushed a commit
that referenced
this issue
Nov 25, 2022
As part of #90, I accidentally added a comma at the end of the line when choosing the memtable reperesntation to use. This is a tuple construction syntax and was formatted as such by Black, but unfortunately missed by me and during review. Fix it by removing the comma so that the argument isn't passed to db_stress as a Python tuple.
Yuval-Ariel
pushed a commit
that referenced
this issue
Apr 30, 2023
As part of #90, I accidentally added a comma at the end of the line when choosing the memtable reperesntation to use. This is a tuple construction syntax and was formatted as such by Black, but unfortunately missed by me and during review. Fix it by removing the comma so that the argument isn't passed to db_stress as a Python tuple.
udi-speedb
pushed a commit
that referenced
this issue
Oct 31, 2023
As part of #90, I accidentally added a comma at the end of the line when choosing the memtable reperesntation to use. This is a tuple construction syntax and was formatted as such by Black, but unfortunately missed by me and during review. Fix it by removing the comma so that the argument isn't passed to db_stress as a Python tuple.
udi-speedb
pushed a commit
that referenced
this issue
Dec 1, 2023
As part of #90, I accidentally added a comma at the end of the line when choosing the memtable reperesntation to use. This is a tuple construction syntax and was formatted as such by Black, but unfortunately missed by me and during review. Fix it by removing the comma so that the argument isn't passed to db_stress as a Python tuple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After the changes in #90, running crash test fails wit the following output:
The reason is a bug on my part when I added the choice between the skip list memtable and the Speed one and accidentally added a comma to the end of the line, which was later formatted by
black
with a proper tuple construction.To Reproduce
make crash_test
Expected behavior
The test doesn't crash because of the choice of memtable.
System (please complete the following information)
Additional context
N/A
The text was updated successfully, but these errors were encountered: