forked from magento/magento2
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Fix issue 21177 - Cart page cross-sell product add-to-cart button issue resolved #15
Open
speedy008
wants to merge
2,036
commits into
2.2-develop
Choose a base branch
from
2.2-develop-PR-port-21178
base: 2.2-develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gned in admin panel magento#19333
[performance] MAGETWO-97094: [BackPort][MC-5663] Enable caching of AJAX requests on Varnish/Fastly
Accepted Public Pull Requests: - magento#21081: [Backport] MAGETWO-95819: Customer registration fields not translated (by @tdgroot) - magento#19333: Fix issue 19328 - Success Message Icon vertically misaligned in admin panel (by @speedy008) Fixed GitHub Issues: - magento#19328: Success Message Icon vertically misaligned in admin panel (reported by @speedy008) has been fixed in magento#19333 by @speedy008 in 2.2-develop branch Related commits: 1. 4fcc190 2. aa13b7d 3. 330b6cc 4. 5cab3ff 5. 373c3b3 6. 07216dd 7. b7fa7f5
…setup with different product urls issue magento#21140 - Merge Pull Request magento#21140 from janakbhimani/magento2:2.2-develop-PR-port-19798 - Merged commits: 1. bd1e538 2. a886103 3. 78df524 4. 7ebc03f 5. 7e4fe31
…erentStoreViewsTest fails because of bad design
Fixed issues: - [MAGETWO-97898](https://jira.corp.magento.com/browse/MAGETWO-97898) [Magento Cloud] Store switcher URL redirects to the same store
…page Price field misaligned on mobile view magento#21114 - Merge Pull Request magento#21114 from amol2jcommerce/magento2:2.2-develop-PR-port-20159 - Merged commits: 1. cb67c97 2. 665dbef 3. 246a344 4. 09c0f01
…ng to default when you checked Use system value magento#20566
…bar fixed using designing changes. magento#20845
Accepted Public Pull Requests: - magento#20566: [Backport] Number of Lines in a Street Address not setting to default when you checked Use system value (by @XxXgeoXxX) - magento#21123: [Backport] Add filter for `NOT FIND_IN_SET` sql conditions (by @mageprince) - magento#21124: [Backport] issue fixed magento#20382 (by @irajneeshgupta) - magento#20845: [Backport] Empty block rendering in My Account page sidebar fixed using designing changes. (by @mage2pratik) Fixed GitHub Issues: - magento#13675: Magento 2 :- Number of Lines in a Street Address not setting to default when you checked Use system value in Magento 2.1.7 (reported by @pradeeprcs) has been fixed in magento#20566 by @XxXgeoXxX in 2.2-develop branch Related commits: 1. ca9bb26 - magento#20382: View and Edit Cart link not aligned in middle because bellow the link a blank div (class="minicart-widgets") existing has 15px margin top, this div (class="minicart-widgets" ) should be display none or should not come if has no content, should only display if has content (reported by @irajneeshgupta) has been fixed in magento#21124 by @irajneeshgupta in 2.2-develop branch Related commits: 1. 05848e5 - magento#19139: Empty block rendering in My Account page sidebar (reported by @rafaelstz) has been fixed in magento#20845 by @mage2pratik in 2.2-develop branch Related commits: 1. e1e4f1b
…g with multi currency when option price type is percentage magento#21263
…alog rule condition combination magento#21269
…: The attribute 'as' is not allowed. (CSS preloading) magento#21261
…label not aligned in mobile view magento#20539
- Merge Pull Request magento#20781 from amol2jcommerce/magento2:cms-page-top-spacing-issue-2.2 - Merged commits: 1. 7383946
…rder async email sending when order was created with disabled email sending magento#20954 - Merge Pull Request magento#20954 from serhiyzhovnir/magento2:2.2-develop-PR-port-18698 - Merged commits: 1. 9b6ef59 2. d70186b
…option is_default magento#21164 - Merge Pull Request magento#21164 from mage2pratik/magento2:2.2-develop-PR-port-20913 - Merged commits: 1. 11cafc3 2. c1f3f36 3. 7b8ec80
Accepted Public Pull Requests: - magento#21287: [Backport] Small refactor of getFrontName (by @mage2pratik) - magento#21282: [Backport] hardcoded table name (by @keyuremipro) - magento#21262: [Backport] Fixed issue Unable to open URL for downloadable product (by @amol2jcommerce) - magento#21263: [Backport] Fixed Custom option price calculation is wrong with multi currency when option price type is percentage (by @amol2jcommerce) - magento#21269: [Backport] Fixed issue if there are multiple skus in catalog rule condition combination (by @mage2pratik) - magento#21273: [Backport] Special price date from issue resolve (by @tufahu) - magento#21261: [Backport] magento#18347 - Element 'css', attribute 'as': The attribute 'as' is not allowed. (CSS preloading) (by @amol2jcommerce) - magento#20539: [Backport] issue fixed magento#20299 Order item details label not aligned in mobile view (by @irajneeshgupta) Fixed GitHub Issues: - magento#18944: Unable to open URL for downloadable product in 2.2.6 (reported by @supportnubix) has been fixed in magento#21262 by @amol2jcommerce in 2.2-develop branch Related commits: 1. f0670b6 2. 04f6cfe 3. a89e6ed 4. 7058adb 5. dac6687 6. fc90509 7. 71a5f5d 8. 0fc730b 9. be3a545 10. e5d04fa 11. 9817c50 - magento#19561: Custom option price calculation is wrong with multi currency when option price type is percentage. (reported by @nimitaemipro) has been fixed in magento#21263 by @amol2jcommerce in 2.2-develop branch Related commits: 1. cbf2c01 2. ee8402f 3. 5c073d9 4. 040c20e - magento#18158: 2.2.6 "Special price date from" Failed to parse time string (reported by @Cristiano81) has been fixed in magento#21273 by @tufahu in 2.2-develop branch Related commits: 1. 4d9e6c8 2. 5235674 3. ad5bf08 - magento#18347: Element 'css', attribute 'as': The attribute 'as' is not allowed. (CSS preloading) (reported by @benoitrenaud) has been fixed in magento#21261 by @amol2jcommerce in 2.2-develop branch Related commits: 1. 46572af - magento#20299: Order item details label not aligned in mobile view (reported by @swetacedcoss) has been fixed in magento#20539 by @irajneeshgupta in 2.2-develop branch Related commits: 1. 867f474 2. 362f81f
…rder async email sending when order was created with disabled email sending magento#20954
…: Bundle product table d… magento#21242
[TSG-CSL3] For 2.2 (pr21)
- merged latest code from mainline branch
Accepted Public Pull Requests: - magento#20954: [Backport] magento#18698 Fixed order email sending via order async email sending when order was created with disabled email sending (by @serhiyzhovnir) - magento#20781: [Backport] cms-page-top-spacing-issue-2.2 (by @amol2jcommerce) - magento#21242: [Backport] bundle-product-table-data-grouped-alignment :: Bundle product table d� (by @amol2jcommerce) - magento#21247: [Backport] Assign with and, or, replaced by &&, || (by @Dharmeshvaja91) - magento#21164: [Backport] Solved swagger response of product attribute option is_default (by @mage2pratik) Fixed GitHub Issues: - magento#18698: Magento triggers and sends some of order emails exactly one month later,while the order email was not enabled then (reported by @PiroozMB) has been fixed in magento#20954 by @serhiyzhovnir in 2.2-develop branch Related commits: 1. 9b6ef59 2. d70186b - magento#20755: cms page top spacing issue at mobile (reported by @priti2jcommerce) has been fixed in magento#20781 by @amol2jcommerce in 2.2-develop branch Related commits: 1. 7383946 - magento#18525: Incorrect Swager Definition for eav-data-attribute-option-interface (reported by @vetshopdeveloper) has been fixed in magento#21164 by @mage2pratik in 2.2-develop branch Related commits: 1. 11cafc3 2. c1f3f36 3. 7b8ec80
speedy008
force-pushed
the
2.2-develop-PR-port-21178
branch
from
February 19, 2019 09:29
25a3675
to
e2bb5a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#21178
Description (*)
Cart page cross-sell product add-to-cart button issue resolved
Magento 2.3-develop
Fixed Issues (if relevant)
1.magento#21177: Cart Page cross sell product Add to cart button overlapping
Manual testing scenarios (*)
1.Add any product to cart into frontend(Note : This product must have cross-sell product added from backend )
2.Check Cross-sell product into 640 * 767 screen.
Contribution checklist (*)