-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
corrected typo and added parameter for cluster (#1) #1717
Conversation
Current coverage is 76.11%@@ master #1717 diff @@
==========================================
Files 95 95
Lines 10348 10349 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 8155 7877 -278
- Misses 2193 2472 +279
Partials 0 0
|
* spotify/master: (25 commits) Version 2.2.0 Add tests for hashing parameters (spotify#1719) Update call to iteritems in luigi/tools/deps: deprecated in Python 3 (spotify#1749) Reset terminal colors in external_program (spotify#1742) Caches get_autoconfig_client on a per-thread basis Fix bug with GCSFlagTarget Add additional event handlers to tasks (spotify#1698) Reduce number of get_params calls in common_params. Removes redundant function definitions from rpc and server (spotify#1734) Fix salesforce default content type (spotify#1724) Rename MockTarget class variable _fn to path Remove MockTarget path property Deprecated LocalTarget fn propery Add note about underscore in parameter names (spotify#1729) Remove tracking url callback hack (spotify#1722) Consistent Luigi spelling in docs (spotify#1723) Update example_top_artists.rst (spotify#1662) Add combiner to docstrings in mrrunner Add luigi-deps-tree visualising tool (spotify#1680) Adding release step for Debian packages. (spotify#1718) ...
* track exit codes * only throw on essential containers non-zero * handle ECS container reason failure, add tests for ECSTask failures * reorganize task status tracking a bit * add AWS_DEFAULT_PROFILE env var to tox passthru
@@ -12,6 +12,7 @@ deps= | |||
nose<2.0 | |||
unittest2<2.0 | |||
boto<3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know nothing about boto. But is it possible to remove boto
dependency now that you introduce boto3
?
* spotify/master: (24 commits) Add DateSecondParameter to parameter.py (spotify#1779) tox: Specify sphinx dependency better flake8: Unbreak travis build Excludes .tox from flake8 to prevent checking third-party libraries (spotify#1785) README: Remove monthly downloads badge Rename CentralPlannerScheduler to Scheduler (spotify#1781) Remove abstract Scheduler class (spotify#1778) Assistants: Don't affect longevity of tasks (spotify#1772) tests: Skip a inttermittently failing s3 test (spotify#1777) Update retcodes to handle new cases (spotify#1771) tests: Fix warning in remote_scheduler_test.py (spotify#1774) Remove sitecustomize file (spotify#1755) Fix exist method for ftp server Update copy() to return number and size of files copied Remove the confusing "dummy_test_module" directory (spotify#1756) Disable codecov comments on GitHub PRs (spotify#1754) Fix "owner_email" log message. (spotify#1762) docs: Install sphinx 1.4.4 in setup.py (spotify#1761) docs: Set minimum versions for sphinx (spotify#1760) Normalize ListParameter to be Immutable (spotify#1759) ...
We are facing the same issue, any progress on merging this PR? Kr, Wouter |
This PR #2045 fixes the same issue. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If closed, you may revisit when your time allows and reopen! Thank you for your contributions. |
Description
I corrected a typo and added a parameter to the task run
Motivation and Context
It both solves a bug ( the typo was critical) and allows for more configuration. It was blocking for us at some point to not be able to run tasks on clusters other than the default one.
Have you tested this? If so, how?
I ran my code (not sharable) and it worked just fine.