Added cluster support for ECS and corrected status debug message #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vanhove, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jfeala and @adamchainz to be potential reviewers. |
dlstadther
requested changes
Feb 27, 2017
luigi/contrib/ecs.py
Outdated
| @@ -133,6 +132,7 @@ class ECSTask(luigi.Task): | |||
|
|
|||
| task_def_arn = luigi.Parameter(default=None) | |||
| task_def = luigi.Parameter(default=None) | |||
| cluster = luigi.Parameter(default=None) | |||
There was a problem hiding this comment.
Could you update the above docstring to include this parameter and a description? (I don't use ECS, so perhaps this is obvious and unnecessary)
There was a problem hiding this comment.
I updated the docstring
|
Also, can you confirm that this replaces PR #1717 ? |
|
Afraid I'm useless as a reviewer, I barely know what luigi is |
dlstadther
approved these changes
Feb 27, 2017
|
@jfeala Thanks for pointing that out. I pushed the change. |
|
@vanhove Thanks for your first github contribution! Sorry for such delay in merging! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added luigi.Parameter for cluster to be able to use another cluster then the default one.
Fixed an issue with the status in debug message when following up running ECS tasks.
Motivation and Context
I needed support to run ECS tasks on other clusters then the default one.
Have you tested this? If so, how?
I ran my jobs with this code and it works for me.