Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By default auto discover files of any type, and run any applicable tools on them. (#432) #435

Merged
merged 27 commits into from
Jul 25, 2022

Conversation

xydesa
Copy link
Collaborator

@xydesa xydesa commented Jul 8, 2022

Also only output to terminal by default. Adding do_nothing tool plugin.

#432

@xydesa xydesa requested a review from denewiler July 8, 2022 16:15
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #435 (4da40b3) into main (62815a0) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #435   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        57    +1     
  Lines         3269      3288   +19     
=========================================
+ Hits          3269      3288   +19     
Impacted Files Coverage Δ
statick_tool/config.py 100.00% <100.00%> (ø)
...tatick_tool/plugins/tool/do_nothing_tool_plugin.py 100.00% <100.00%> (ø)
statick_tool/statick.py 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@xydesa xydesa changed the title by default auto discover files of any type, and run any applicable tools on them. by default auto discover files of any type, and run any applicable tools on them. (#432) Jul 14, 2022
@xydesa xydesa changed the title by default auto discover files of any type, and run any applicable tools on them. (#432) By default auto discover files of any type, and run any applicable tools on them. (#432) Jul 14, 2022
@tdenewiler
Copy link
Contributor

I tested against a pure Python package and it works as described. I specified a user path and it used the default level specified in profile.yaml from that path. Then I did not specify a user path and it used the default level with default tool flags. This is a nice improvement.

xydesa and others added 2 commits July 25, 2022 10:58
…_plugin.py

Co-authored-by: Thomas Denewiler <40217061+denewiler@users.noreply.github.com>
@denewiler
Copy link
Collaborator

LGTM

@denewiler denewiler merged commit 60a1fae into sscpac:main Jul 25, 2022
@denewiler denewiler mentioned this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants