-
-
Notifications
You must be signed in to change notification settings - Fork 15
ClusterResources should take the operator and controller names separately #482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
7 tasks
nightkr
added a commit
that referenced
this issue
Oct 17, 2022
5 tasks
Comment on the PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently,
ClusterResources
takes a singlemanager
argument that must be unique per controller. The documentation suggests identifying both the controller and operator names (foo-operator_foo-controller
), but in practice many single-controller operators just use the operator name (foo-operator
).This is not only inconsistent across the platform, but can lead to orphaned resources during upgrades that add more controllers (necessitating a switch to the expanded format). Additionally, it's generally a convention that un-namedspaced identifiers are reserved for the cluster administrators and users, third-party software should use the
ns/id
format for string keys (such as field managers or labels).Acceptance
ClusterResources::new
takes separate arguments for the operator and controller nameslabels::get_recommended_labels
takes separate arguments for the operator and controller namesmanaged-by
labels and field managers follow theoperator/controller
formatzookeeper.stackable.tech
rather thanzookeeper-operator
)The text was updated successfully, but these errors were encountered: