[Merged by Bors] - Separate operator and controller names #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightkr
added
type/bug
release-note/action-required
nightkr
commented
Oct 17, 2022
src/builder/meta.rs
Outdated
Comment on lines
156
to
159
| operator_name: &str, | ||
| controller_name: &str, | ||
| app_role: &str, | ||
| app_role_group: &str, |
There was a problem hiding this comment.
This triggers a cargo warning due to #491, not sure if we want to tackle that in this PR...
There was a problem hiding this comment.
I'd be fine with munging it together but I'd appreciate it if you could bring it up at the daily or arch meeting to see if there are any objections (I don't expect any tbh.).
If you decide to let me know please.
There was a problem hiding this comment.
There was a problem hiding this comment.
Updated to account for #491 being merged.
siegfriedweber
requested review from
siegfriedweber
and removed request for
a team
5 tasks
bors bot
pushed a commit
that referenced
this pull request
Nov 11, 2022
## Description Hopefully this should help clarify how the different names hold together, and help make it clearer how to adjust for later changes going forward. This doesn't cover `role_group_selector_labels` or `role_selector_labels` since they have a more obvious inherent structure to them, and I don't see them changing as much (especially since they are effectively part of the public API). This is kind of coupled to #492, do we want to merge that into this PR or do that one on top of this afterwards? Fixes #491. Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de>
sbernauer
approved these changes
Nov 11, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 11, 2022
## Description Fixes #482 Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #482
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information