Swift 3 Migration #500
Closed
Swift 3 Migration #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing imports
Closes #457: Split up tests into more Travis jobs.
Run desired unit tests instead of only Mac.
Makefile: re-add scheme default
|
Thanks for your contribution! However I'm going to to close this in favor of #502 which is targeting master and has a passing test suite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
I believe I may have completed the Swift 3 migration. Please have a go at it and see if there's anything missing.
@stephencelis I understand you may be busy, but would appreciate it if you could have a look at this.
Related to #497, #455.