fix: update @web3-storage/access dep to fix email + issue #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trying to auth with an email with a + in it currently fails, upgrade to the latest version of @web3-storage/access which fixes that.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bfab958:
|
|
yep, same way as storacha/w3cli#73
<storacha/w3cli#73>
…On Thu, Apr 6, 2023 at 6:53 PM Benjamin Goering ***@***.***> wrote:
Trying to auth with an email with a + in it currently fails,
Fails how?
This way or another way? storacha/w3cli#73
<storacha/w3cli#73>
—
Reply to this email directly, view it on GitHub
<#503 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAIWNYZF2YES6SQVLDWZDW75XR3ANCNFSM6AAAAAAWWAUBFY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
gobengo
approved these changes
Apr 10, 2023
This was referenced Apr 10, 2023
travis
pushed a commit
that referenced
this pull request
May 9, 2023
🤖 I have created a release *beep* *boop* --- ## [4.2.0](keyring-core-v4.1.1...keyring-core-v4.2.0) (2023-05-08) ### Features * update to latest version of ucanto and [@web3-storage](https://github.com/web3-storage) libraries ([#514](#514)) ([e1ee301](e1ee301)) * upload progress ([#499](#499)) ([6c9de97](6c9de97)) ### Bug Fixes * update @web3-storage/access dep to fix email + issue ([#503](#503)) ([d3b0bba](d3b0bba)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
travis
pushed a commit
that referenced
this pull request
May 9, 2023
🤖 I have created a release *beep* *boop* --- ## [5.2.0](react-keyring-v5.1.1...react-keyring-v5.2.0) (2023-05-09) ### Features * update to latest version of ucanto and [@web3-storage](https://github.com/web3-storage) libraries ([#514](#514)) ([e1ee301](e1ee301)) * upload progress ([#499](#499)) ([6c9de97](6c9de97)) * w3console cleanup and updates to packages to support it ([#507](#507)) ([78aee2a](78aee2a)) ### Bug Fixes * update @web3-storage/access dep to fix email + issue ([#503](#503)) ([d3b0bba](d3b0bba)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
travis
pushed a commit
that referenced
this pull request
May 9, 2023
🤖 I have created a release *beep* *boop* --- ## [4.2.0](vue-keyring-v4.1.1...vue-keyring-v4.2.0) (2023-05-09) ### Features * update to latest version of ucanto and [@web3-storage](https://github.com/web3-storage) libraries ([#514](#514)) ([e1ee301](e1ee301)) * upload progress ([#499](#499)) ([6c9de97](6c9de97)) * w3console cleanup and updates to packages to support it ([#507](#507)) ([78aee2a](78aee2a)) ### Bug Fixes * update @web3-storage/access dep to fix email + issue ([#503](#503)) ([d3b0bba](d3b0bba)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
travis
pushed a commit
that referenced
this pull request
May 9, 2023
🤖 I have created a release *beep* *boop* --- ## [4.2.0](solid-keyring-v4.1.0...solid-keyring-v4.2.0) (2023-05-09) ### Features * update to latest version of ucanto and [@web3-storage](https://github.com/web3-storage) libraries ([#514](#514)) ([e1ee301](e1ee301)) * upload progress ([#499](#499)) ([6c9de97](6c9de97)) * w3console cleanup and updates to packages to support it ([#507](#507)) ([78aee2a](78aee2a)) ### Bug Fixes * more email type ([#494](#494)) ([355e794](355e794)) * update @web3-storage/access dep to fix email + issue ([#503](#503)) ([d3b0bba](d3b0bba)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [4.2.0](storacha/w3ui@keyring-core-v4.1.1...keyring-core-v4.2.0) (2023-05-08) ### Features * update to latest version of ucanto and [@web3-storage](https://github.com/web3-storage) libraries ([storacha#514](storacha/w3ui#514)) ([f70ca5f](storacha/w3ui@f70ca5f)) * upload progress ([storacha#499](storacha/w3ui#499)) ([81ae196](storacha/w3ui@81ae196)) ### Bug Fixes * update @web3-storage/access dep to fix email + issue ([storacha#503](storacha/w3ui#503)) ([19b2c0a](storacha/w3ui@19b2c0a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [5.2.0](storacha/w3ui@react-keyring-v5.1.1...react-keyring-v5.2.0) (2023-05-09) ### Features * update to latest version of ucanto and [@web3-storage](https://github.com/web3-storage) libraries ([storacha#514](storacha/w3ui#514)) ([f70ca5f](storacha/w3ui@f70ca5f)) * upload progress ([storacha#499](storacha/w3ui#499)) ([81ae196](storacha/w3ui@81ae196)) * w3console cleanup and updates to packages to support it ([storacha#507](storacha/w3ui#507)) ([f6fdf8e](storacha/w3ui@f6fdf8e)) ### Bug Fixes * update @web3-storage/access dep to fix email + issue ([storacha#503](storacha/w3ui#503)) ([19b2c0a](storacha/w3ui@19b2c0a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [4.2.0](storacha/w3ui@vue-keyring-v4.1.1...vue-keyring-v4.2.0) (2023-05-09) ### Features * update to latest version of ucanto and [@web3-storage](https://github.com/web3-storage) libraries ([storacha#514](storacha/w3ui#514)) ([f70ca5f](storacha/w3ui@f70ca5f)) * upload progress ([storacha#499](storacha/w3ui#499)) ([81ae196](storacha/w3ui@81ae196)) * w3console cleanup and updates to packages to support it ([storacha#507](storacha/w3ui#507)) ([f6fdf8e](storacha/w3ui@f6fdf8e)) ### Bug Fixes * update @web3-storage/access dep to fix email + issue ([storacha#503](storacha/w3ui#503)) ([19b2c0a](storacha/w3ui@19b2c0a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [4.2.0](storacha/w3ui@solid-keyring-v4.1.0...solid-keyring-v4.2.0) (2023-05-09) ### Features * update to latest version of ucanto and [@web3-storage](https://github.com/web3-storage) libraries ([storacha#514](storacha/w3ui#514)) ([f70ca5f](storacha/w3ui@f70ca5f)) * upload progress ([storacha#499](storacha/w3ui#499)) ([81ae196](storacha/w3ui@81ae196)) * w3console cleanup and updates to packages to support it ([storacha#507](storacha/w3ui#507)) ([f6fdf8e](storacha/w3ui@f6fdf8e)) ### Bug Fixes * more email type ([storacha#494](storacha/w3ui#494)) ([1c0db4f](storacha/w3ui@1c0db4f)) * update @web3-storage/access dep to fix email + issue ([storacha#503](storacha/w3ui#503)) ([19b2c0a](storacha/w3ui@19b2c0a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to auth with an email with a + in it currently fails, upgrade to the latest version of @web3-storage/access which fixes that.
While I was in here I did a bit of refactoring so that only
keyring-coredepends on@web3-storage/access