Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert that space/info succeeds for spaces w/ storage provider registered via provider/add invocation #497

Closed
gobengo opened this issue Mar 7, 2023 · 1 comment · Fixed by #510
Closed

assert that space/info succeeds for spaces w/ storage provider registered via provider/add invocation #497

gobengo opened this issue Mar 7, 2023 · 1 comment · Fixed by #510
Assignees
@gobengo

Comments

@gobengo
Copy link
Contributor

gobengo commented Mar 7, 2023

Motivation:

  • @Gozala asked me to
  • it'll make it so that when w3infra invokes space/info as part of handling store/add that its not rejected
@gobengo gobengo self-assigned this Mar 7, 2023
@Gozala
Copy link
Contributor

Gozala commented Mar 8, 2023

Long term we should probably do #495, but for now this would unblock the store/* and upload/* with new account stuff.

@gobengo gobengo mentioned this issue Mar 8, 2023
Merged
@gobengo gobengo linked a pull request Mar 8, 2023 that will close this issue
feat: space/info will not error for spaces that have had storage provider added via provider/add #510
Merged
gobengo added a commit that referenced this issue Mar 8, 2023
@gobengo @Gozala
feat: space/info will not error for spaces that have had storage prov…
ea4e872 
…ider added via provider/add (#510)

Motivation:
* #497 
* @Gozala and I talked about doing this minimally just to make sure that
when w3infra calls this as part of handling `store/add` that it will
work.

---------

Co-authored-by: Irakli Gozalishvili <contact@gozala.io>
gobengo added a commit that referenced this issue Apr 11, 2023
@gobengo @Gozala
feat: space/info will not error for spaces that have had storage prov…
362024f 
…ider added via provider/add (#510)

Motivation:
* #497 
* @Gozala and I talked about doing this minimally just to make sure that
when w3infra calls this as part of handling `store/add` that it will
work.

---------

Co-authored-by: Irakli Gozalishvili <contact@gozala.io>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 17, 2025
@github-actions @travis
chore(main): release solid-keyring 4.2.0 (storacha#497)
101c164 
🤖 I have created a release *beep* *boop*
---


##
[4.2.0](storacha/w3ui@solid-keyring-v4.1.0...solid-keyring-v4.2.0)
(2023-05-09)


### Features

* update to latest version of ucanto and
[@web3-storage](https://github.com/web3-storage) libraries
([storacha#514](storacha/w3ui#514))
([e1ee301](storacha/w3ui@e1ee301))
* upload progress
([storacha#499](storacha/w3ui#499))
([6c9de97](storacha/w3ui@6c9de97))
* w3console cleanup and updates to packages to support it
([storacha#507](storacha/w3ui#507))
([78aee2a](storacha/w3ui@78aee2a))


### Bug Fixes

* more email type
([storacha#494](storacha/w3ui#494))
([355e794](storacha/w3ui@355e794))
* update @web3-storage/access dep to fix email + issue
([storacha#503](storacha/w3ui#503))
([d3b0bba](storacha/w3ui@d3b0bba))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Peeja pushed a commit to storacha/upload-service that referenced this issue Jan 29, 2025
@github-actions @travis
chore(main): release solid-keyring 4.2.0 (storacha#497)
fa3f951 
🤖 I have created a release *beep* *boop*
---


##
[4.2.0](storacha/w3ui@solid-keyring-v4.1.0...solid-keyring-v4.2.0)
(2023-05-09)


### Features

* update to latest version of ucanto and
[@web3-storage](https://github.com/web3-storage) libraries
([storacha#514](storacha/w3ui#514))
([f70ca5f](storacha/w3ui@f70ca5f))
* upload progress
([storacha#499](storacha/w3ui#499))
([81ae196](storacha/w3ui@81ae196))
* w3console cleanup and updates to packages to support it
([storacha#507](storacha/w3ui#507))
([f6fdf8e](storacha/w3ui@f6fdf8e))


### Bug Fixes

* more email type
([storacha#494](storacha/w3ui#494))
([1c0db4f](storacha/w3ui@1c0db4f))
* update @web3-storage/access dep to fix email + issue
([storacha#503](storacha/w3ui#503))
([19b2c0a](storacha/w3ui@19b2c0a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gobengo gobengo

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Gozala @gobengo