Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: types so that w3infra would have been evident #507

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

Gozala
Copy link
Contributor

@Gozala Gozala commented Mar 8, 2023

No description provided.

url: URL
headers: {
'x-amz-checksum-sha256': string
'content-length': string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what motivated adding this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because w3infra passes content-length as number which was not included here. This made type checker pass but test fail because it checked against string. If this type existed this would have been caught without back and forth.

@Gozala Gozala merged commit 544a838 into main Mar 8, 2023
@Gozala Gozala deleted the fix/w3infra-incompat branch March 8, 2023 18:08
Gozala pushed a commit that referenced this pull request Mar 8, 2023
🤖 I have created a release *beep* *boop*
---


##
[1.0.3](upload-api-v1.0.2...upload-api-v1.0.3)
(2023-03-08)


### Bug Fixes

* switch upload-api to node16
([#509](#509))
([698a033](698a033))
* types so that w3infra would have been evident
([#507](#507))
([544a838](544a838))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
gobengo pushed a commit that referenced this pull request Apr 11, 2023
🤖 I have created a release *beep* *boop*
---


##
[1.0.3](upload-api-v1.0.2...upload-api-v1.0.3)
(2023-03-08)


### Bug Fixes

* switch upload-api to node16
([#509](#509))
([92a708b](92a708b))
* types so that w3infra would have been evident
([#507](#507))
([d694669](d694669))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 17, 2025
…ha#507)

Integrate some learnings from creating a new app from the ground up with
some tasks I've been meaning to do for a little while to clean up
w3console. This is mostly either:
a) extracting components to their own files OR
b) lifting up types to eliminate 2-level-deep dependencies (ie, allowing
w3console to only depend on the `@w3ui/react-*` packages rather than
pulling in `@w3ui/*-core` and `multiformats`)
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 17, 2025
🤖 I have created a release *beep* *boop*
---


##
[5.1.0](storacha/w3ui@uploader-core-v5.0.0...uploader-core-v5.1.0)
(2023-05-09)


### Features

* update to latest version of ucanto and
[@web3-storage](https://github.com/web3-storage) libraries
([storacha#514](storacha/w3ui#514))
([e1ee301](storacha/w3ui@e1ee301))
* upload progress
([storacha#499](storacha/w3ui#499))
([6c9de97](storacha/w3ui@6c9de97))
* w3console cleanup and updates to packages to support it
([storacha#507](storacha/w3ui#507))
([78aee2a](storacha/w3ui@78aee2a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 17, 2025
🤖 I have created a release *beep* *boop*
---


##
[4.1.0](storacha/w3ui@react-uploader-v4.0.1...react-uploader-v4.1.0)
(2023-05-09)


### Features

* update to latest version of ucanto and
[@web3-storage](https://github.com/web3-storage) libraries
([storacha#514](storacha/w3ui#514))
([e1ee301](storacha/w3ui@e1ee301))
* upload progress
([storacha#499](storacha/w3ui#499))
([6c9de97](storacha/w3ui@6c9de97))
* w3console cleanup and updates to packages to support it
([storacha#507](storacha/w3ui#507))
([78aee2a](storacha/w3ui@78aee2a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 17, 2025
🤖 I have created a release *beep* *boop*
---


##
[5.2.0](storacha/w3ui@react-keyring-v5.1.1...react-keyring-v5.2.0)
(2023-05-09)


### Features

* update to latest version of ucanto and
[@web3-storage](https://github.com/web3-storage) libraries
([storacha#514](storacha/w3ui#514))
([e1ee301](storacha/w3ui@e1ee301))
* upload progress
([storacha#499](storacha/w3ui#499))
([6c9de97](storacha/w3ui@6c9de97))
* w3console cleanup and updates to packages to support it
([storacha#507](storacha/w3ui#507))
([78aee2a](storacha/w3ui@78aee2a))


### Bug Fixes

* update @web3-storage/access dep to fix email + issue
([storacha#503](storacha/w3ui#503))
([d3b0bba](storacha/w3ui@d3b0bba))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 17, 2025
🤖 I have created a release *beep* *boop*
---


##
[1.5.0](storacha/w3ui@w3console-v1.4.1...w3console-v1.5.0)
(2023-05-09)


### Features

* add warnings about the public and permanent nature of w3up uploads
([storacha#502](storacha/w3ui#502))
([6cc58f8](storacha/w3ui@6cc58f8)),
closes [storacha#464](storacha/w3ui#464)
* get w3console looking acceptable on mobile
([storacha#500](storacha/w3ui#500))
([118cb22](storacha/w3ui@118cb22))
* remove space creator from sidebar
([storacha#509](storacha/w3ui#509))
([40bc621](storacha/w3ui@40bc621))
* update to latest version of ucanto and
[@web3-storage](https://github.com/web3-storage) libraries
([storacha#514](storacha/w3ui#514))
([e1ee301](storacha/w3ui@e1ee301))
* upload progress
([storacha#499](storacha/w3ui#499))
([6c9de97](storacha/w3ui@6c9de97))
* w3console cleanup and updates to packages to support it
([storacha#507](storacha/w3ui#507))
([78aee2a](storacha/w3ui@78aee2a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 17, 2025
🤖 I have created a release *beep* *boop*
---


##
[4.2.0](storacha/w3ui@vue-keyring-v4.1.1...vue-keyring-v4.2.0)
(2023-05-09)


### Features

* update to latest version of ucanto and
[@web3-storage](https://github.com/web3-storage) libraries
([storacha#514](storacha/w3ui#514))
([e1ee301](storacha/w3ui@e1ee301))
* upload progress
([storacha#499](storacha/w3ui#499))
([6c9de97](storacha/w3ui@6c9de97))
* w3console cleanup and updates to packages to support it
([storacha#507](storacha/w3ui#507))
([78aee2a](storacha/w3ui@78aee2a))


### Bug Fixes

* update @web3-storage/access dep to fix email + issue
([storacha#503](storacha/w3ui#503))
([d3b0bba](storacha/w3ui@d3b0bba))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 17, 2025
🤖 I have created a release *beep* *boop*
---


##
[4.1.0](storacha/w3ui@vue-uploader-v4.0.0...vue-uploader-v4.1.0)
(2023-05-09)


### Features

* upload progress
([storacha#499](storacha/w3ui#499))
([6c9de97](storacha/w3ui@6c9de97))
* w3console cleanup and updates to packages to support it
([storacha#507](storacha/w3ui#507))
([78aee2a](storacha/w3ui@78aee2a))


### Bug Fixes

* tweak READMEs for packages that release-please didn't release right
([storacha#440](storacha/w3ui#440))
([845a6b6](storacha/w3ui@845a6b6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 17, 2025
🤖 I have created a release *beep* *boop*
---


##
[4.2.0](storacha/w3ui@solid-keyring-v4.1.0...solid-keyring-v4.2.0)
(2023-05-09)


### Features

* update to latest version of ucanto and
[@web3-storage](https://github.com/web3-storage) libraries
([storacha#514](storacha/w3ui#514))
([e1ee301](storacha/w3ui@e1ee301))
* upload progress
([storacha#499](storacha/w3ui#499))
([6c9de97](storacha/w3ui@6c9de97))
* w3console cleanup and updates to packages to support it
([storacha#507](storacha/w3ui#507))
([78aee2a](storacha/w3ui@78aee2a))


### Bug Fixes

* more email type
([storacha#494](storacha/w3ui#494))
([355e794](storacha/w3ui@355e794))
* update @web3-storage/access dep to fix email + issue
([storacha#503](storacha/w3ui#503))
([d3b0bba](storacha/w3ui@d3b0bba))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 17, 2025
🤖 I have created a release *beep* *boop*
---


##
[4.1.0](storacha/w3ui@solid-uploader-v4.0.0...solid-uploader-v4.1.0)
(2023-05-09)


### Features

* upload progress
([storacha#499](storacha/w3ui#499))
([6c9de97](storacha/w3ui@6c9de97))
* w3console cleanup and updates to packages to support it
([storacha#507](storacha/w3ui#507))
([78aee2a](storacha/w3ui@78aee2a))


### Bug Fixes

* tweak READMEs for packages that release-please didn't release right
([storacha#440](storacha/w3ui#440))
([845a6b6](storacha/w3ui@845a6b6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 29, 2025
…ha#507)

Integrate some learnings from creating a new app from the ground up with
some tasks I've been meaning to do for a little while to clean up
w3console. This is mostly either:
a) extracting components to their own files OR
b) lifting up types to eliminate 2-level-deep dependencies (ie, allowing
w3console to only depend on the `@w3ui/react-*` packages rather than
pulling in `@w3ui/*-core` and `multiformats`)
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 29, 2025
🤖 I have created a release *beep* *boop*
---


##
[5.1.0](storacha/w3ui@uploader-core-v5.0.0...uploader-core-v5.1.0)
(2023-05-09)


### Features

* update to latest version of ucanto and
[@web3-storage](https://github.com/web3-storage) libraries
([storacha#514](storacha/w3ui#514))
([f70ca5f](storacha/w3ui@f70ca5f))
* upload progress
([storacha#499](storacha/w3ui#499))
([81ae196](storacha/w3ui@81ae196))
* w3console cleanup and updates to packages to support it
([storacha#507](storacha/w3ui#507))
([f6fdf8e](storacha/w3ui@f6fdf8e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 29, 2025
🤖 I have created a release *beep* *boop*
---


##
[4.1.0](storacha/w3ui@react-uploader-v4.0.1...react-uploader-v4.1.0)
(2023-05-09)


### Features

* update to latest version of ucanto and
[@web3-storage](https://github.com/web3-storage) libraries
([storacha#514](storacha/w3ui#514))
([f70ca5f](storacha/w3ui@f70ca5f))
* upload progress
([storacha#499](storacha/w3ui#499))
([81ae196](storacha/w3ui@81ae196))
* w3console cleanup and updates to packages to support it
([storacha#507](storacha/w3ui#507))
([f6fdf8e](storacha/w3ui@f6fdf8e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 29, 2025
🤖 I have created a release *beep* *boop*
---


##
[5.2.0](storacha/w3ui@react-keyring-v5.1.1...react-keyring-v5.2.0)
(2023-05-09)


### Features

* update to latest version of ucanto and
[@web3-storage](https://github.com/web3-storage) libraries
([storacha#514](storacha/w3ui#514))
([f70ca5f](storacha/w3ui@f70ca5f))
* upload progress
([storacha#499](storacha/w3ui#499))
([81ae196](storacha/w3ui@81ae196))
* w3console cleanup and updates to packages to support it
([storacha#507](storacha/w3ui#507))
([f6fdf8e](storacha/w3ui@f6fdf8e))


### Bug Fixes

* update @web3-storage/access dep to fix email + issue
([storacha#503](storacha/w3ui#503))
([19b2c0a](storacha/w3ui@19b2c0a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 29, 2025
🤖 I have created a release *beep* *boop*
---


##
[1.5.0](storacha/w3ui@w3console-v1.4.1...w3console-v1.5.0)
(2023-05-09)


### Features

* add warnings about the public and permanent nature of w3up uploads
([storacha#502](storacha/w3ui#502))
([ad0632c](storacha/w3ui@ad0632c)),
closes [storacha#464](storacha/w3ui#464)
* get w3console looking acceptable on mobile
([storacha#500](storacha/w3ui#500))
([3e512df](storacha/w3ui@3e512df))
* remove space creator from sidebar
([storacha#509](storacha/w3ui#509))
([d5f5536](storacha/w3ui@d5f5536))
* update to latest version of ucanto and
[@web3-storage](https://github.com/web3-storage) libraries
([storacha#514](storacha/w3ui#514))
([f70ca5f](storacha/w3ui@f70ca5f))
* upload progress
([storacha#499](storacha/w3ui#499))
([81ae196](storacha/w3ui@81ae196))
* w3console cleanup and updates to packages to support it
([storacha#507](storacha/w3ui#507))
([f6fdf8e](storacha/w3ui@f6fdf8e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 29, 2025
🤖 I have created a release *beep* *boop*
---


##
[4.2.0](storacha/w3ui@vue-keyring-v4.1.1...vue-keyring-v4.2.0)
(2023-05-09)


### Features

* update to latest version of ucanto and
[@web3-storage](https://github.com/web3-storage) libraries
([storacha#514](storacha/w3ui#514))
([f70ca5f](storacha/w3ui@f70ca5f))
* upload progress
([storacha#499](storacha/w3ui#499))
([81ae196](storacha/w3ui@81ae196))
* w3console cleanup and updates to packages to support it
([storacha#507](storacha/w3ui#507))
([f6fdf8e](storacha/w3ui@f6fdf8e))


### Bug Fixes

* update @web3-storage/access dep to fix email + issue
([storacha#503](storacha/w3ui#503))
([19b2c0a](storacha/w3ui@19b2c0a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 29, 2025
🤖 I have created a release *beep* *boop*
---


##
[4.1.0](storacha/w3ui@vue-uploader-v4.0.0...vue-uploader-v4.1.0)
(2023-05-09)


### Features

* upload progress
([storacha#499](storacha/w3ui#499))
([81ae196](storacha/w3ui@81ae196))
* w3console cleanup and updates to packages to support it
([storacha#507](storacha/w3ui#507))
([f6fdf8e](storacha/w3ui@f6fdf8e))


### Bug Fixes

* tweak READMEs for packages that release-please didn't release right
([storacha#440](storacha/w3ui#440))
([9b8a9c8](storacha/w3ui@9b8a9c8))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 29, 2025
🤖 I have created a release *beep* *boop*
---


##
[4.2.0](storacha/w3ui@solid-keyring-v4.1.0...solid-keyring-v4.2.0)
(2023-05-09)


### Features

* update to latest version of ucanto and
[@web3-storage](https://github.com/web3-storage) libraries
([storacha#514](storacha/w3ui#514))
([f70ca5f](storacha/w3ui@f70ca5f))
* upload progress
([storacha#499](storacha/w3ui#499))
([81ae196](storacha/w3ui@81ae196))
* w3console cleanup and updates to packages to support it
([storacha#507](storacha/w3ui#507))
([f6fdf8e](storacha/w3ui@f6fdf8e))


### Bug Fixes

* more email type
([storacha#494](storacha/w3ui#494))
([1c0db4f](storacha/w3ui@1c0db4f))
* update @web3-storage/access dep to fix email + issue
([storacha#503](storacha/w3ui#503))
([19b2c0a](storacha/w3ui@19b2c0a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Peeja pushed a commit to storacha/upload-service that referenced this pull request Jan 29, 2025
🤖 I have created a release *beep* *boop*
---


##
[4.1.0](storacha/w3ui@solid-uploader-v4.0.0...solid-uploader-v4.1.0)
(2023-05-09)


### Features

* upload progress
([storacha#499](storacha/w3ui#499))
([81ae196](storacha/w3ui@81ae196))
* w3console cleanup and updates to packages to support it
([storacha#507](storacha/w3ui#507))
([f6fdf8e](storacha/w3ui@f6fdf8e))


### Bug Fixes

* tweak READMEs for packages that release-please didn't release right
([storacha#440](storacha/w3ui#440))
([9b8a9c8](storacha/w3ui@9b8a9c8))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Travis Vachon <travis.vachon@protocol.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants