Skip to content

Conversation

@cstockton
Copy link
Contributor

  • Added a test for double invites
  • Fixed control flow to send another invite

Bug introduced in:
#2034

Fixes:
#2057

* Added a test for double invites
* Fixed control flow to send another invite

Bug introduced in:
#2034

Fixes:
#2057
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15642769682

Details

  • 26 of 32 (81.25%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 70.114%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/invite.go 26 32 81.25%
Totals Coverage Status
Change from base Build 15576512475: 0.02%
Covered Lines: 11350
Relevant Lines: 16188

💛 - Coveralls

@tuladhar
Copy link

Thanks @cstockton! I've compared the changes with the previously working reinvite code on v1.174.0, LGTM.

@cstockton cstockton merged commit 96469bd into master Jun 16, 2025
7 checks passed
@cstockton cstockton deleted the cs/invite-fix branch June 16, 2025 13:19
hf pushed a commit that referenced this pull request Jul 8, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.177.0](v2.176.1...v2.177.0)
(2025-07-05)


### Features

* add option to disable writing to `audit_log_entries`
([#2073](#2073))
([80758dd](80758dd))
* add snapchat provider
([#2071](#2071))
([fca8ea4](fca8ea4))
* enhance login analytics
([#2078](#2078))
([1aed4a2](1aed4a2))
* fallback to jwt secret if alg is `HS256` and the `kid` is not
recognized ([#2072](#2072))
([8fa99bd](8fa99bd))
* ignore `aud` claim from admin jwt (`service_role` never had one)
([#2070](#2070))
([57eddcb](57eddcb))


### Bug Fixes

* add missing provider info to signedup audit logs
([#2061](#2061))
([c6e0cbe](c6e0cbe))
* **auditlog:** keep writing to logs even postgres is disabled
([#2076](#2076))
([b89bc32](b89bc32))
* do not log fatal when http server successfully closes
([#2065](#2065))
([1f7de6c](1f7de6c))
* invites should send another email when user exists
([#2058](#2058))
([96469bd](96469bd))
* use `appleid.apple.com` as default issuer
([#2068](#2068))
([963a781](963a781))
* use `split_words` config option for `AuditLog`
([#2075](#2075))
([7ecb234](7ecb234))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
cemalkilic pushed a commit that referenced this pull request Aug 7, 2025
* Added a test for double invites
* Fixed control flow to send another invite

Bug introduced in:
#2034

Fixes:
#2057

Co-authored-by: Chris Stockton <chris.stockton@supabase.io>
cemalkilic pushed a commit that referenced this pull request Aug 7, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.177.0](v2.176.1...v2.177.0)
(2025-07-05)


### Features

* add option to disable writing to `audit_log_entries`
([#2073](#2073))
([80758dd](80758dd))
* add snapchat provider
([#2071](#2071))
([fca8ea4](fca8ea4))
* enhance login analytics
([#2078](#2078))
([1aed4a2](1aed4a2))
* fallback to jwt secret if alg is `HS256` and the `kid` is not
recognized ([#2072](#2072))
([8fa99bd](8fa99bd))
* ignore `aud` claim from admin jwt (`service_role` never had one)
([#2070](#2070))
([57eddcb](57eddcb))


### Bug Fixes

* add missing provider info to signedup audit logs
([#2061](#2061))
([c6e0cbe](c6e0cbe))
* **auditlog:** keep writing to logs even postgres is disabled
([#2076](#2076))
([b89bc32](b89bc32))
* do not log fatal when http server successfully closes
([#2065](#2065))
([1f7de6c](1f7de6c))
* invites should send another email when user exists
([#2058](#2058))
([96469bd](96469bd))
* use `appleid.apple.com` as default issuer
([#2068](#2068))
([963a781](963a781))
* use `split_words` config option for `AuditLog`
([#2075](#2075))
([7ecb234](7ecb234))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
issuedat pushed a commit that referenced this pull request Sep 30, 2025
* Added a test for double invites
* Fixed control flow to send another invite

Bug introduced in:
#2034

Fixes:
#2057

Co-authored-by: Chris Stockton <chris.stockton@supabase.io>
issuedat pushed a commit that referenced this pull request Sep 30, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.177.0](v2.176.1...v2.177.0)
(2025-07-05)


### Features

* add option to disable writing to `audit_log_entries`
([#2073](#2073))
([80758dd](80758dd))
* add snapchat provider
([#2071](#2071))
([fca8ea4](fca8ea4))
* enhance login analytics
([#2078](#2078))
([1aed4a2](1aed4a2))
* fallback to jwt secret if alg is `HS256` and the `kid` is not
recognized ([#2072](#2072))
([8fa99bd](8fa99bd))
* ignore `aud` claim from admin jwt (`service_role` never had one)
([#2070](#2070))
([57eddcb](57eddcb))


### Bug Fixes

* add missing provider info to signedup audit logs
([#2061](#2061))
([c6e0cbe](c6e0cbe))
* **auditlog:** keep writing to logs even postgres is disabled
([#2076](#2076))
([b89bc32](b89bc32))
* do not log fatal when http server successfully closes
([#2065](#2065))
([1f7de6c](1f7de6c))
* invites should send another email when user exists
([#2058](#2058))
([96469bd](96469bd))
* use `appleid.apple.com` as default issuer
([#2068](#2068))
([963a781](963a781))
* use `split_words` config option for `AuditLog`
([#2075](#2075))
([7ecb234](7ecb234))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants