Skip to content

fix(auditlog): keep writing to logs even postgres is disabled #2076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2025
Merged

fix(auditlog): keep writing to logs even postgres is disabled #2076

merged 2 commits into from
Jul 3, 2025

Conversation

@cemalkilic
Copy link
Contributor

@cemalkilic cemalkilic commented Jul 3, 2025 •
edited
Loading

move DisablePostgres check after payload mutation to ensure auth_event logs have the same data prior to introduce of the DisablePostgres config

@cemalkilic
fix(auditlog): keep writing to logs even postgres is disabled
73a7e1a 
move `DisablePostgres` check after payload mutation to ensure auth_event logs have the same data as before
@cemalkilic cemalkilic requested a review from a team as a code owner July 3, 2025 09:18
@coveralls
Copy link

coveralls commented Jul 3, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 16053775860

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • 52 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 70.094%
Files with Coverage Reduction New Missed Lines %
internal/api/auth.go 13 77.67%
internal/api/external.go 39 74.96%
Totals Coverage Status
Change from base Build 16045670700: -0.02%
Covered Lines: 11447
Relevant Lines: 16331
💛 - Coveralls

hf
hf reviewed Jul 3, 2025
View reviewed changes
@cemalkilic cemalkilic merged commit b89bc32 into master Jul 3, 2025
7 checks passed
@cemalkilic cemalkilic deleted the cemal/audit-logs-prevent-only-writing-postgres branch July 3, 2025 15:26
@github-actions github-actions bot mentioned this pull request Jul 3, 2025
Merged
hf pushed a commit that referenced this pull request Jul 8, 2025
@github-actions
chore(master): release 2.177.0 (#2059)
48aa34c 
🤖 I have created a release *beep* *boop*
---


##
[2.177.0](v2.176.1...v2.177.0)
(2025-07-05)


### Features

* add option to disable writing to `audit_log_entries`
([#2073](#2073))
([80758dd](80758dd))
* add snapchat provider
([#2071](#2071))
([fca8ea4](fca8ea4))
* enhance login analytics
([#2078](#2078))
([1aed4a2](1aed4a2))
* fallback to jwt secret if alg is `HS256` and the `kid` is not
recognized ([#2072](#2072))
([8fa99bd](8fa99bd))
* ignore `aud` claim from admin jwt (`service_role` never had one)
([#2070](#2070))
([57eddcb](57eddcb))


### Bug Fixes

* add missing provider info to signedup audit logs
([#2061](#2061))
([c6e0cbe](c6e0cbe))
* **auditlog:** keep writing to logs even postgres is disabled
([#2076](#2076))
([b89bc32](b89bc32))
* do not log fatal when http server successfully closes
([#2065](#2065))
([1f7de6c](1f7de6c))
* invites should send another email when user exists
([#2058](#2058))
([96469bd](96469bd))
* use `appleid.apple.com` as default issuer
([#2068](#2068))
([963a781](963a781))
* use `split_words` config option for `AuditLog`
([#2075](#2075))
([7ecb234](7ecb234))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
cemalkilic added a commit that referenced this pull request Aug 7, 2025
@cemalkilic
fix(auditlog): keep writing to logs even postgres is disabled (#2076)
d107bb8 
move `DisablePostgres` check after payload mutation to ensure auth_event
logs have the same data prior to introduce of the `DisablePostgres`
config
cemalkilic pushed a commit that referenced this pull request Aug 7, 2025
@github-actions @cemalkilic
chore(master): release 2.177.0 (#2059)
464a8ec 
🤖 I have created a release *beep* *boop*
---


##
[2.177.0](v2.176.1...v2.177.0)
(2025-07-05)


### Features

* add option to disable writing to `audit_log_entries`
([#2073](#2073))
([80758dd](80758dd))
* add snapchat provider
([#2071](#2071))
([fca8ea4](fca8ea4))
* enhance login analytics
([#2078](#2078))
([1aed4a2](1aed4a2))
* fallback to jwt secret if alg is `HS256` and the `kid` is not
recognized ([#2072](#2072))
([8fa99bd](8fa99bd))
* ignore `aud` claim from admin jwt (`service_role` never had one)
([#2070](#2070))
([57eddcb](57eddcb))


### Bug Fixes

* add missing provider info to signedup audit logs
([#2061](#2061))
([c6e0cbe](c6e0cbe))
* **auditlog:** keep writing to logs even postgres is disabled
([#2076](#2076))
([b89bc32](b89bc32))
* do not log fatal when http server successfully closes
([#2065](#2065))
([1f7de6c](1f7de6c))
* invites should send another email when user exists
([#2058](#2058))
([96469bd](96469bd))
* use `appleid.apple.com` as default issuer
([#2068](#2068))
([963a781](963a781))
* use `split_words` config option for `AuditLog`
([#2075](#2075))
([7ecb234](7ecb234))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
issuedat pushed a commit that referenced this pull request Sep 30, 2025
@cemalkilic @issuedat
fix(auditlog): keep writing to logs even postgres is disabled (#2076)
17e65b6 
move `DisablePostgres` check after payload mutation to ensure auth_event
logs have the same data prior to introduce of the `DisablePostgres`
config
issuedat pushed a commit that referenced this pull request Sep 30, 2025
@github-actions @issuedat
chore(master): release 2.177.0 (#2059)
0821560 
🤖 I have created a release *beep* *boop*
---


##
[2.177.0](v2.176.1...v2.177.0)
(2025-07-05)


### Features

* add option to disable writing to `audit_log_entries`
([#2073](#2073))
([80758dd](80758dd))
* add snapchat provider
([#2071](#2071))
([fca8ea4](fca8ea4))
* enhance login analytics
([#2078](#2078))
([1aed4a2](1aed4a2))
* fallback to jwt secret if alg is `HS256` and the `kid` is not
recognized ([#2072](#2072))
([8fa99bd](8fa99bd))
* ignore `aud` claim from admin jwt (`service_role` never had one)
([#2070](#2070))
([57eddcb](57eddcb))


### Bug Fixes

* add missing provider info to signedup audit logs
([#2061](#2061))
([c6e0cbe](c6e0cbe))
* **auditlog:** keep writing to logs even postgres is disabled
([#2076](#2076))
([b89bc32](b89bc32))
* do not log fatal when http server successfully closes
([#2065](#2065))
([1f7de6c](1f7de6c))
* invites should send another email when user exists
([#2058](#2058))
([96469bd](96469bd))
* use `appleid.apple.com` as default issuer
([#2068](#2068))
([963a781](963a781))
* use `split_words` config option for `AuditLog`
([#2075](#2075))
([7ecb234](7ecb234))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hf hf hf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cemalkilic @coveralls @hf