fix: do not log fatal when http server successfully closes #2065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 15903453920Details
💛 - Coveralls |
hf
approved these changes
Jun 26, 2025
hf
pushed a commit
that referenced
this pull request
Jul 8, 2025
🤖 I have created a release *beep* *boop* --- ## [2.177.0](v2.176.1...v2.177.0) (2025-07-05) ### Features * add option to disable writing to `audit_log_entries` ([#2073](#2073)) ([80758dd](80758dd)) * add snapchat provider ([#2071](#2071)) ([fca8ea4](fca8ea4)) * enhance login analytics ([#2078](#2078)) ([1aed4a2](1aed4a2)) * fallback to jwt secret if alg is `HS256` and the `kid` is not recognized ([#2072](#2072)) ([8fa99bd](8fa99bd)) * ignore `aud` claim from admin jwt (`service_role` never had one) ([#2070](#2070)) ([57eddcb](57eddcb)) ### Bug Fixes * add missing provider info to signedup audit logs ([#2061](#2061)) ([c6e0cbe](c6e0cbe)) * **auditlog:** keep writing to logs even postgres is disabled ([#2076](#2076)) ([b89bc32](b89bc32)) * do not log fatal when http server successfully closes ([#2065](#2065)) ([1f7de6c](1f7de6c)) * invites should send another email when user exists ([#2058](#2058)) ([96469bd](96469bd)) * use `appleid.apple.com` as default issuer ([#2068](#2068)) ([963a781](963a781)) * use `split_words` config option for `AuditLog` ([#2075](#2075)) ([7ecb234](7ecb234)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
cemalkilic
added a commit
that referenced
this pull request
Aug 7, 2025
## What kind of change does this PR introduce? do not log fatal when http server successfully closes
cemalkilic
pushed a commit
that referenced
this pull request
Aug 7, 2025
🤖 I have created a release *beep* *boop* --- ## [2.177.0](v2.176.1...v2.177.0) (2025-07-05) ### Features * add option to disable writing to `audit_log_entries` ([#2073](#2073)) ([80758dd](80758dd)) * add snapchat provider ([#2071](#2071)) ([fca8ea4](fca8ea4)) * enhance login analytics ([#2078](#2078)) ([1aed4a2](1aed4a2)) * fallback to jwt secret if alg is `HS256` and the `kid` is not recognized ([#2072](#2072)) ([8fa99bd](8fa99bd)) * ignore `aud` claim from admin jwt (`service_role` never had one) ([#2070](#2070)) ([57eddcb](57eddcb)) ### Bug Fixes * add missing provider info to signedup audit logs ([#2061](#2061)) ([c6e0cbe](c6e0cbe)) * **auditlog:** keep writing to logs even postgres is disabled ([#2076](#2076)) ([b89bc32](b89bc32)) * do not log fatal when http server successfully closes ([#2065](#2065)) ([1f7de6c](1f7de6c)) * invites should send another email when user exists ([#2058](#2058)) ([96469bd](96469bd)) * use `appleid.apple.com` as default issuer ([#2068](#2068)) ([963a781](963a781)) * use `split_words` config option for `AuditLog` ([#2075](#2075)) ([7ecb234](7ecb234)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
issuedat
pushed a commit
that referenced
this pull request
Sep 30, 2025
## What kind of change does this PR introduce? do not log fatal when http server successfully closes
issuedat
pushed a commit
that referenced
this pull request
Sep 30, 2025
🤖 I have created a release *beep* *boop* --- ## [2.177.0](v2.176.1...v2.177.0) (2025-07-05) ### Features * add option to disable writing to `audit_log_entries` ([#2073](#2073)) ([80758dd](80758dd)) * add snapchat provider ([#2071](#2071)) ([fca8ea4](fca8ea4)) * enhance login analytics ([#2078](#2078)) ([1aed4a2](1aed4a2)) * fallback to jwt secret if alg is `HS256` and the `kid` is not recognized ([#2072](#2072)) ([8fa99bd](8fa99bd)) * ignore `aud` claim from admin jwt (`service_role` never had one) ([#2070](#2070)) ([57eddcb](57eddcb)) ### Bug Fixes * add missing provider info to signedup audit logs ([#2061](#2061)) ([c6e0cbe](c6e0cbe)) * **auditlog:** keep writing to logs even postgres is disabled ([#2076](#2076)) ([b89bc32](b89bc32)) * do not log fatal when http server successfully closes ([#2065](#2065)) ([1f7de6c](1f7de6c)) * invites should send another email when user exists ([#2058](#2058)) ([96469bd](96469bd)) * use `appleid.apple.com` as default issuer ([#2068](#2068)) ([963a781](963a781)) * use `split_words` config option for `AuditLog` ([#2075](#2075)) ([7ecb234](7ecb234)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
do not log fatal when http server successfully closes