Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fan speed control generates invalid g-code moves randomly #4254

Closed
shengyan opened this issue May 5, 2024 · 1 comment
Closed

Fan speed control generates invalid g-code moves randomly #4254

shengyan opened this issue May 5, 2024 · 1 comment
Labels
bug Something isn't working as intended fix is live in the last release Please download /build the last release and try to reproduce.

Comments

@shengyan
Copy link

shengyan commented May 5, 2024

What happened?

I have noticed some missing lines on external perimeter on multiple prints since I switch to 2.5.59.8, previously I use 2.3.57.12.
By checking the g-code file, I found something like M106 S255G1 X56.624 Y28.869 E0.09313 on multiple location. It should take up two lines if it was generated correctly.

Project file & How to reproduce

  • default fan speed: 80%
  • overhangs perimeter fan speed: 100%
  • speedup time: 1s
  • kickstart duration: 1s
  • slice a large object, or the invalid line may not occur.
    bug report - invalid lines.zip

Version

2.5.59.9

Operating system

No response

Printer model

No response
@supermerill supermerill added the bug Something isn't working as intended label May 15, 2024
@supermerill
Copy link
Owner

nice catch.

@supermerill supermerill added the fixed for the next version That means that you should be able to test it in the latest nightly build label May 15, 2024
supermerill added a commit that referenced this issue May 15, 2024
@supermerill
Fix fan mover gcode corruption
5a884c3 
#4254
supermerill added a commit that referenced this issue May 20, 2024
@supermerill
Fix fan mover gcode corruption
a4b97ba 
#4254
@supermerill supermerill added fix is live in the last release Please download /build the last release and try to reproduce. and removed fixed for the next version That means that you should be able to test it in the latest nightly build labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as intended fix is live in the last release Please download /build the last release and try to reproduce.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shengyan @supermerill