Iron #373

xsebek · 2022-06-08T22:15:30Z

add iron ore, iron mine and iron vein (closes Add iron to allow more advanced recipes #93)
- split gear into iron/wooden gear
- add metal drill
- add faster recipes with the metal drill
add compass (closes Compass device #341)
handle multiple entities providing the same capability
- try to find if the robot has at least one entity providing the capability
- when no entity could provide the capability rejects it too
list required devices in the Incapable error (closes Suggest required entities #342)

byorgey

Some initial comments. I haven't finished looking carefully through the changes regarding how we check for required devices etc.

data/entities.yaml

src/Swarm/Game/Step.hs

xsebek · 2022-06-09T11:14:33Z

Thanks for taking a look @byorgey, the copy-pasting is definitely a problem 😅

I spent most type debugging the capability checking, so now that it (hopefully?) works I will come back and streamline it.

byorgey · 2022-06-09T17:12:56Z

By the way, I very much like all the new recipes, the way metal drill does things faster than a regular drill, etc.

- add iron ore - add iron mine and iron vein - section the recipes for easier discoverability

- split gear into iron/wooden gear

- add drill test challenge! - add recipes with metal drill - make iron veins slightly more likely

- try to find if robot has at least one entity providing capability - when no entity could provide the capability reject it too This "improvement" only concerns build and reprogram comands. They could use a refactor after this, as the common capability checking part should be moved into helper function or to Entity.hs

Co-authored-by: Brent Yorgey <byorgey@gmail.com>

Closes swarm-game#341

xsebek · 2022-06-10T17:06:24Z

That Restyled action is a bit annoying since I by mistake pushed to my repo which confused Restyled and it wants to merge to main. 🤦

bench/Benchmark.hs

data/recipes.yaml

src/Swarm/Game/Step.hs

- refactor out required device checking to common function - add a fun little linguistic function :)

There are a few reasons for this: - we do not have direction map entry for it (uses default) - it makes it easier to check - like forward is (1*dir) and back (-dir) so down is (0*dir) Really it is the weirdest direction because once you turn down you can not look up again without compass.

byorgey

Everything looks good to me, but there's still something I don't understand going on with drilling in creative mode.

data/entities.yaml

data/scenarios/03Challenges/02-drill_test.yaml

src/Swarm/Game/Entity.hs

src/Swarm/Game/Scenario.hs

src/Swarm/Game/Step.hs

src/Swarm/Util/Yaml.hs

byorgey · 2022-06-11T19:33:48Z

src/Swarm/Game/Step.hs

+                    )
+    -- check that there are in fact devices to provide every required capability
+    (creative || not (any null deviceSets))
+      `holdsOrFail` [singularSubjectVerb subject "can", "not perform an impossible task"]


To make sure I'm understanding correctly, if this "impossible task" error is triggered, it means that there do not exist any devices to provide the required capability, right? As in, we have some capability but no actual devices yet in entities.yaml which provide it?

Hmm, I actually got this error while playing in classic mode and it's very mysterious. How hard would it be to output the name of the capability for which there is no device, with a message apologizing and a link to the issue tracker?

I expected this to only come up for CGod tier tasks, like create "life", where the message would make sense.

Maybe I could check if it is CGod and otherwise link to the issue. Something like:

[ singularSubjectVerb subject "do", "not have", indefiniteQ capName , "capability, because no device provides it." , "\nSee https://github.com/swarm-game/swarm/issues/26." ]

However, I feel like it should be Incapable exceptions job to figure this out. EDIT: Actually Incapable is a different situation, but I wish I could use some common code for it here.

Some of it was common, but building and reprogramming can give a more specialised error message, so I keep some duplicate code. Oh well, at least I get to close #342 😇

Also, just an update: the reason I got this error while playing in classic mode was actually due to #389 . So that was making it more mysterious than necessary.

src/Swarm/Language/Syntax.hs

Co-authored-by: Brent Yorgey <byorgey@gmail.com>

- fixes swarm-game#342

xsebek · 2022-06-12T15:33:29Z

Everything looks good to me, but there's still something I don't understand going on with drilling in creative mode.

@byorgey it was actually more than drilling, by mistake I did not install any required entities if they were not present in inventory.

The commit 9e24293 should fix that 🙂

byorgey · 2022-06-12T19:35:45Z

src/Swarm/Game/Exception.hs

+formatIncapable em f caps tm
+  | CGod `S.member` caps =
+    unlinesExText
+      [ "Can not perform an impossible task:"


I think this error message could still be improved. I don't think it is going to make much sense if a player stumbles across it. e.g. imagine that they type as accidentally and notice that it has a type, then they wonder what it does so they try it out. They are going to wonder why the task is impossible. Somehow we should convey that this is a command that is not available during normal play. We can definitely make it funny though. Some ideas:

"This command is not available to mere mortals" / "This command is forbidden"

"Thou shalt not utter such blasphemy"

If we wanted to be more informative and less funny, "This command is only available to system robots and scenario definitions".

I guess the Elden ring is now popular, so blasphemy it is:

incapableError (S.singleton CGod) (TConst As) -- Thee shalt not utter such blasphemy: -- 'as' -- If't be true thee wanteth to playeth god, then tryeth Creative game.

byorgey · 2022-06-12T20:00:25Z

This is looking great! 🚀

byorgey · 2022-06-13T16:01:06Z

So I ran into one additional issue while testing out some things. In creative mode I tried something like this:

def forever = \c. c ; forever c end
def unblock = try {drill forward} {} end
def push = unblock; move end

build {forever (push; build {turn right; forever push})}

The intention is to make a robot that moves in a straight line forever, drilling through obstacles along the way, and at each step creating a robot that does the same in a perpendicular direction. This should be a very quick way to drill through all the mountains in a particular quadrant. Obviously this would be very expensive to do in classic mode, but I think it should work in creative mode.

However, it doesn't work. The initial robot works fine, drilling along and building another robot at each step. However, all those secondary robots don't end up with a drill device, and crash with a fatal error when they try to execute the drill command.

byorgey · 2022-06-13T16:47:17Z

But up to you whether we want to go ahead and merge this and file a separate issue re the problems I mentioned above! At this point I would actually lean towards doing it that way rather than hold this up longer.

byorgey · 2022-06-13T23:05:18Z

A capability error reporting bug that I am likewise happy to split out into a separate issue after merging this, just want to write it down while it's fresh in my head:

Start a classic mode game with --cheat
Switch into creative mode and create "branch predictor"
Switch back out of creative mode
Type build {move; if (1 > 2) {} {}}
- As expected we get an error saying no device provides the compare capability.
Now type build {move; turn left; if (1 > 2) {} {}}
- All we have done is add turn left; we would expect to get the same error. Instead we get an error like You do not have the devices required for: 'move; turn left; if (1 > 2) {noop} {noop}' please obtain: - branch predictor
- But we do have a branch predictor, so this error is bogus. Not sure yet whether the capability checking or error reporting is to blame.

xsebek · 2022-06-14T15:58:21Z

@byorgey I think your first bug is present on main too, the Drill capability is not reported by requiredCaps.
The difference is, that I call that a Fatal error because build should have given it to the robot, while main drives the robots to rocks and there they stop without a drill.

See the debug logs I added:

Main

Iron

I was also missing standard devices, so I added them back:

I have no idea what the second bug is, but I hope it is not really my fault 😄

Fixes the mistake introduces in #373.

- fix the mistake introduces in #373

xsebek requested a review from byorgey June 8, 2022 22:15

restyled-io bot mentioned this pull request Jun 8, 2022

Restyle Iron #374

Closed

byorgey reviewed Jun 9, 2022

View reviewed changes

This was referenced Jun 9, 2022

Nested definitions #349

Closed

Prevent base from being able to move too early #334

Closed

xsebek added 4 commits June 10, 2022 13:47

Add iron

c94c499

- add iron ore - add iron mine and iron vein - section the recipes for easier discoverability

Make iron gear

d231ab8

- split gear into iron/wooden gear

Make iron or wooden motors and gears

95752fc

Add metal drill recipes

99ce4d2

- add drill test challenge! - add recipes with metal drill - make iron veins slightly more likely

xsebek force-pushed the iron branch from bfd5149 to 801002c Compare June 10, 2022 11:50

xsebek and others added 2 commits June 10, 2022 13:54

Fix entity attributes (thanks @byorgey)

06b9f28

Co-authored-by: Brent Yorgey <byorgey@gmail.com>

xsebek force-pushed the iron branch from 801002c to 06b9f28 Compare June 10, 2022 11:55

xsebek added 2 commits June 10, 2022 14:40

Fix iron plate description

5650d51

Add compass device

7cee36f

Closes swarm-game#341

restyled-io bot mentioned this pull request Jun 10, 2022

Restyle Iron #383

Closed

xsebek force-pushed the iron branch from 8911b10 to b4e37b4 Compare June 10, 2022 15:32

Disallow cardinal diretion values without compass

dd03922

xsebek force-pushed the iron branch from b4e37b4 to dd03922 Compare June 10, 2022 15:35

byorgey reviewed Jun 10, 2022

View reviewed changes

bench/Benchmark.hs Show resolved Hide resolved

byorgey reviewed Jun 10, 2022

View reviewed changes

data/recipes.yaml Show resolved Hide resolved

byorgey reviewed Jun 10, 2022

View reviewed changes

src/Swarm/Game/Step.hs Outdated Show resolved Hide resolved

byorgey mentioned this pull request Jun 10, 2022

Design and implement more capabilities and devices #26

Closed

21 tasks

xsebek added 4 commits June 10, 2022 23:23

Refactor checking required devices

be8eb73

- refactor out required device checking to common function - add a fun little linguistic function :)

Improve drilling direction error message

d0ba08a

Inline moves in benchmark

e5a4571

byorgey reviewed Jun 11, 2022

View reviewed changes

xsebek and others added 7 commits June 12, 2022 11:29

Fix wording (thanks @byorgey)

79eddbc

Co-authored-by: Brent Yorgey <byorgey@gmail.com>

Explain ignoreOK

7a5e4cf

Differentiate exception for CGod and others

6c01e62

Use common code for incapable exception

c29558c

- fixes swarm-game#342

Rename fromE

dcbd614

Improve and test incapable exception

e916322

Fix creative robots not getting devices

9e24293

restyled-io bot mentioned this pull request Jun 12, 2022

Restyle Iron #386

Closed

Restyled by fourmolu

a8c83be

xsebek marked this pull request as ready for review June 12, 2022 14:16

byorgey approved these changes Jun 12, 2022

View reviewed changes

byorgey mentioned this pull request Jun 12, 2022

Capability checking does not respect name shadowing #389

Closed

byorgey mentioned this pull request Jun 13, 2022

Device to give exceptions capability #132

Closed

xsebek added 2 commits June 14, 2022 17:42

Add standard devices

6365428

Explain blasphemy better

8ab3ef7

xsebek added the merge me Trigger the merge process of the Pull request. label Jun 14, 2022

Merge branch 'main' into iron

950256a

mergify bot merged commit bda16b7 into swarm-game:main Jun 14, 2022

xsebek mentioned this pull request Jun 14, 2022

Inner build does not correctly require Drill #394

Closed

byorgey mentioned this pull request Jun 14, 2022

Wrong device reported missing #397

Closed

xsebek added a commit that referenced this pull request Jun 22, 2022

Fix reprogram requiring wrong inventory

1af512f

Fixes the mistake introduces in #373.

xsebek mentioned this pull request Jun 22, 2022

Fix reprogram requiring wrong inventory #464

Merged

mergify bot pushed a commit that referenced this pull request Jun 22, 2022

Fix reprogram requiring wrong inventory (#464)

a170379

- fix the mistake introduces in #373

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Iron #373

Iron #373

xsebek commented Jun 8, 2022 •

edited

Loading

byorgey left a comment

xsebek commented Jun 9, 2022

byorgey commented Jun 9, 2022

xsebek commented Jun 10, 2022

byorgey left a comment

byorgey Jun 11, 2022

byorgey Jun 11, 2022

xsebek Jun 12, 2022 •

edited

Loading

xsebek Jun 12, 2022 •

edited

Loading

byorgey Jun 13, 2022

xsebek commented Jun 12, 2022

byorgey Jun 12, 2022

xsebek Jun 14, 2022

byorgey commented Jun 12, 2022

byorgey commented Jun 13, 2022

byorgey commented Jun 13, 2022

byorgey commented Jun 13, 2022 •

edited

Loading

xsebek commented Jun 14, 2022

Iron #373

Iron #373

Conversation

xsebek commented Jun 8, 2022 • edited Loading

byorgey left a comment

Choose a reason for hiding this comment

xsebek commented Jun 9, 2022

byorgey commented Jun 9, 2022

xsebek commented Jun 10, 2022

byorgey left a comment

Choose a reason for hiding this comment

byorgey Jun 11, 2022

Choose a reason for hiding this comment

byorgey Jun 11, 2022

Choose a reason for hiding this comment

xsebek Jun 12, 2022 • edited Loading

Choose a reason for hiding this comment

xsebek Jun 12, 2022 • edited Loading

Choose a reason for hiding this comment

byorgey Jun 13, 2022

Choose a reason for hiding this comment

xsebek commented Jun 12, 2022

byorgey Jun 12, 2022

Choose a reason for hiding this comment

xsebek Jun 14, 2022

Choose a reason for hiding this comment

byorgey commented Jun 12, 2022

byorgey commented Jun 13, 2022

byorgey commented Jun 13, 2022

byorgey commented Jun 13, 2022 • edited Loading

xsebek commented Jun 14, 2022

Main

Iron

xsebek commented Jun 8, 2022 •

edited

Loading

xsebek Jun 12, 2022 •

edited

Loading

xsebek Jun 12, 2022 •

edited

Loading

byorgey commented Jun 13, 2022 •

edited

Loading