Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream changes #2

Merged
merged 36 commits into from
Jul 31, 2024
Merged

Merge upstream changes #2

merged 36 commits into from
Jul 31, 2024

Conversation

tobyhodges
Copy link
Member

KoenLeuveld and others added 30 commits June 5, 2023 14:57
the PR was missing the last `git restore` needed to put `mars.txt` back in the state at the beginning of the episode (before the ill-considered change)
As I followed along, the $ git diff HEAD~3 is back one commit further than my history. It is possible if a previous aside is followed that this might not generate an error about that version not existing, however, the output shown indicates no such commit. So the command is inconsistent with the output shown. A simple fix is to replace the "3" with a "2"
Add descriptive alt text to all images
Incorrect number of commits before head for shown output.
In episode 5, mention that both `git log` and `git show` display IDs that can identify commits.
Copy link

⚠️ WARNING ⚠️

This pull request contains a mix of workflow files and regular files. This could be malicious. No preview will be created.

regular files:

  • episodes/01-basics.md
  • episodes/03-create.md
  • episodes/04-changes.md
  • episodes/05-history.md
  • episodes/07-github.md
  • episodes/08-collab.md
  • episodes/09-conflict.md
  • episodes/12-citation.md
  • episodes/13-hosting.md
  • episodes/14-supplemental-rstudio.md
  • episodes/fig/git-restore.svg
  • episodes/fig/git_staging.svg
  • episodes/fig/github-add-collaborators.png

workflow files:

  • .github/workflows/README.md
  • .github/workflows/sandpaper-version.txt

@tobyhodges tobyhodges merged commit a11734e into main Jul 31, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.