-
Notifications
You must be signed in to change notification settings - Fork 6
Add ability to serialize Distributions and RegressionDatasets. #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1589f1a to
ca742da
Compare
to help users identify the source of serialization issues.
ca742da to
947f0bd
Compare
| */ | ||
| template <class Archive> | ||
| typename std::enable_if<valid_output_serializer<ModelFit, Archive>::value, | ||
| void>::type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this hurts me :( I feel like we should extend the character limit on our formatter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah kinda annoying. I guess it's already a pretty difficult line to read, so doesn't make it that much worse :)
| public: | ||
| SerializableDiagonalMatrix() : BaseClass(){}; | ||
|
|
||
| SerializableDiagonalMatrix(const BaseClass &other) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you implicitly get SerializableDiagonalMatrix(const BaseClass &&other) I think, so that's the only scenario where you don't actually need to copy.
kmdade
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
This gives you the ability to serialize a
RegressionDatasetprovided theFeatureTypeis also serializable. This can come in handy when it's costly to parse data and convert it into the requiredfeaturesandtargets. For example, you can now you can do something like:Allowing you to read them in much faster next time,